mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-03-13 14:27:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

ITS#9059 Document why we do FIND_CSN

Browse Source
This commit is contained in:
Ondřej Kuzník 2020-05-01 09:03:46 +01:00 committed by Quanah Gibson-Mount
parent 709d805f84
commit f3952d947b
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
servers/slapd/overlays/syncprov.c
View File

@ -2882,7 +2882,18 @@ no_change: if ( !(op->o_sync_mode & SLAP_SYNC_PERSIST) ) {
ldap_pvt_thread_mutex_unlock( &sl->sl_mutex );
}
}
/* Is the CSN still present in the database? */
/*
* If sessionlog wasn't useful, see if we can find at least one entry
* that hasn't changed based on the cookie.
*
* TODO: Using mincsn only (rather than the whole cookie) will
* under-approximate the set of entries that haven't changed, but we
* can't look up CSNs by serverid with the current indexing support.
*
* As a result, dormant serverids in the cluster become mincsns and
* more likely to make syncprov_findcsn(,FIND_CSN,) fail -> triggering
* an expensive refresh...
*/
if ( !do_present ) {
gotstate = 1;
} else if ( syncprov_findcsn( op, FIND_CSN, &mincsn ) != LDAP_SUCCESS ) {