mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-03-07 14:18:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

NO-OP must be critical and apply to selected operations (ITS#5758)

Browse Source
This commit is contained in:
Pierangelo Masarati 2008-10-20 23:16:40 +00:00
parent 18e3573c81
commit e233a8e9ee
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
servers/slapd/controls.c
View File

@ -1038,6 +1038,26 @@ static int parseNoOp (
return LDAP_PROTOCOL_ERROR;
}
if ( !ctrl->ldctl_iscritical ) {
rs->sr_text = "noop control not critical";
return LDAP_PROTOCOL_ERROR;
}
switch ( op->o_tag ) {
case LDAP_REQ_ADD:
case LDAP_REQ_MODIFY:
case LDAP_REQ_RENAME:
case LDAP_REQ_DELETE:
/* NOTE: only selected extended operations should be eligible;
* checking is delegated to the appropriate handlers */
case LDAP_REQ_EXTENDED:
break;
default:
rs->sr_text = "noop control on non-allowed operation";
return LDAP_PROTOCOL_ERROR;
}
op->o_noop = ctrl->ldctl_iscritical
? SLAP_CONTROL_CRITICAL
: SLAP_CONTROL_NONCRITICAL;