mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-01-12 10:54:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

ITS#7168 Fix count constraint when using multiple modifications

Browse Source 
Constraint overlay doesn't take into account multiple modifications when using
count.

Red Hat Bugzilla: #742163
This commit is contained in:
Jan Synacek 2012-06-19 07:00:26 +02:00 committed by Howard Chu
parent 39481d50e0
commit bb8112c382
1 changed files with 80 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

117
servers/slapd/overlays/constraint.c
View File

@ -837,6 +837,68 @@ add_violation:
}
static int
constraint_check_count_violation( Modifications *m, Entry *target_entry, constraint *cp )
{
BerVarray b = NULL;
unsigned ce = 0;
unsigned ca;
int j;
for ( j = 0; cp->ap[j]; j++ ) {
ca = 0;
/* Get this attribute count */
if ( target_entry )
ce = constraint_count_attr( target_entry, cp->ap[j] );
for( ; m; m = m->sml_next ) {
if ( cp->ap[j] == m->sml_desc ) {
switch ( m->sml_op ) {
case LDAP_MOD_DELETE:
if (( b = m->sml_values ) == NULL || b[0].bv_val == NULL ) {
ce = 0;
}
else {
/* No need to check for values' validity. Invalid values
* cause the whole transaction to die anyway. */
for ( ca = 0; b[ca].bv_val; ++ca );
ce -= ca;
}
break;
case LDAP_MOD_ADD:
if (( b = m->sml_values ) == NULL || b[0].bv_val == NULL )
continue;
for ( ca = 0; b[ca].bv_val; ++ca );
ce += ca;
break;
case LDAP_MOD_REPLACE:
if (( b = m->sml_values ) == NULL || b[0].bv_val == NULL )
continue;
for ( ca = 0; b[ca].bv_val; ++ca );
ce = ca;
break;
default:
/* impossible! assert? */
return 1;
}
Debug(LDAP_DEBUG_TRACE,
"==> constraint_check_count_violation ce = %u, "
"ca = %u, cp->count = %lu\n",
ce, ca, (unsigned long) cp->count);
}
}
}
return ( ce > cp->count );
}
static int
constraint_update( Operation *op, SlapReply *rs )
{
@ -850,6 +912,8 @@ constraint_update( Operation *op, SlapReply *rs )
struct berval rsv = BER_BVC("modify breaks constraint");
int rc;
char *msg = NULL;
int is_v;
int first = 1;
if (get_relax(op)) {
return SLAP_CB_CONTINUE;
@ -880,10 +944,12 @@ constraint_update( Operation *op, SlapReply *rs )
/* Do we need to count attributes? */
for(cp = c; cp; cp = cp->ap_next) {
if (cp->count != 0 || cp->set || cp->restrict_lud != 0) {
op->o_bd = on->on_info->oi_origdb;
rc = be_entry_get_rw( op, &op->o_req_ndn, NULL, NULL, 0, &target_entry );
op->o_bd = be;
if (first) {
op->o_bd = on->on_info->oi_origdb;
rc = be_entry_get_rw( op, &op->o_req_ndn, NULL, NULL, 0, &target_entry );
op->o_bd = be;
first = 0;
}
if (rc != 0 || target_entry == NULL) {
Debug(LDAP_DEBUG_TRACE,
"==> constraint_update rc = %d DN=\"%s\"%s\n",
@ -893,7 +959,16 @@ constraint_update( Operation *op, SlapReply *rs )
rc = LDAP_CONSTRAINT_VIOLATION;
goto mod_violation;
}
break;
is_v = constraint_check_count_violation(m, target_entry, cp);
Debug(LDAP_DEBUG_TRACE,
"==> constraint_update is_v: %d\n", is_v, 0, 0);
if (is_v) {
rc = LDAP_CONSTRAINT_VIOLATION;
goto mod_violation;
}
}
}
@ -912,10 +987,6 @@ constraint_update( Operation *op, SlapReply *rs )
if ((( b = m->sml_values ) == NULL ) || (b[0].bv_val == NULL))
continue;
/* Get this attribute count, if needed */
if (target_entry)
ce = constraint_count_attr(target_entry, m->sml_desc);
for(cp = c; cp; cp = cp->ap_next) {
int j;
for (j = 0; cp->ap[j]; j++) {
@ -929,34 +1000,6 @@ constraint_update( Operation *op, SlapReply *rs )
continue;
}
if (cp->count != 0) {
unsigned ca;
if (m->sml_op == LDAP_MOD_DELETE)
ce = 0;
for (ca = 0; b[ca].bv_val; ++ca);
Debug(LDAP_DEBUG_TRACE,
"==> constraint_update ce = %u, "
"ca = %u, cp->count = %lu\n",
ce, ca, (unsigned long) cp->count);
if (m->sml_op == LDAP_MOD_ADD) {
if (ca + ce > cp->count) {
rc = LDAP_CONSTRAINT_VIOLATION;
goto mod_violation;
}
}
if (m->sml_op == LDAP_MOD_REPLACE) {
if (ca > cp->count) {
rc = LDAP_CONSTRAINT_VIOLATION;
goto mod_violation;
}
ce = ca;
}
}
/* DELETE are to be ignored beyond this point */
if (( m->sml_op & LDAP_MOD_OP ) == LDAP_MOD_DELETE)
continue;