mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-01-24 13:24:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

ITS#6518 When using proxyauthz, replace existing control - (async)meta

Browse Source
This commit is contained in:
Ondřej Kuzník 2021-02-01 16:40:02 +00:00
parent 4a02ae132d
commit ac70b01bc4
2 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
servers/slapd/back-asyncmeta/bind.c
View File

@ -1258,7 +1258,7 @@ asyncmeta_controls_add( Operation *op,
LDAPControl **ctrls = NULL;
/* set to the maximum number of controls this backend can add */
LDAPControl c[ 2 ] = {{ 0 }};
int n = 0, i, j1 = 0, j2 = 0;
int n = 0, i, j1 = 0, j2 = 0, skipped = 0;
*pctrls = NULL;
@ -1344,12 +1344,21 @@ asyncmeta_controls_add( Operation *op,
i = 0;
if ( op->o_ctrls ) {
LDAPControl *proxyauthz = ldap_control_find(
LDAP_CONTROL_PROXY_AUTHZ, op->o_ctrls, NULL );
for ( i = 0; op->o_ctrls[ i ]; i++ ) {
ctrls[ i + j1 ] = op->o_ctrls[ i ];
if ( proxyauthz && proxyauthz == op->o_ctrls[ i ] ) {
/* Frontend has already checked only one is present */
assert( skipped == 0 );
skipped++;
continue;
}
ctrls[ i + j1 - skipped ] = op->o_ctrls[ i ];
}
}
n += j1;
n += j1 - skipped;
if ( j2 ) {
ctrls[ n ] = (LDAPControl *)&ctrls[ n + j2 + 1 ] + j1;
*ctrls[ n ] = c[ j1 ];

15
servers/slapd/back-meta/bind.c
View File

@ -1633,7 +1633,7 @@ meta_back_controls_add(
LDAPControl **ctrls = NULL;
/* set to the maximum number of controls this backend can add */
LDAPControl c[ 2 ] = {{ 0 }};
int n = 0, i, j1 = 0, j2 = 0;
int n = 0, i, j1 = 0, j2 = 0, skipped = 0;
*pctrls = NULL;
@ -1719,12 +1719,21 @@ meta_back_controls_add(
i = 0;
if ( op->o_ctrls ) {
LDAPControl *proxyauthz = ldap_control_find(
LDAP_CONTROL_PROXY_AUTHZ, op->o_ctrls, NULL );
for ( i = 0; op->o_ctrls[ i ]; i++ ) {
ctrls[ i + j1 ] = op->o_ctrls[ i ];
if ( proxyauthz && proxyauthz == op->o_ctrls[ i ] ) {
/* Frontend has already checked only one is present */
assert( skipped == 0 );
skipped++;
continue;
}
ctrls[ i + j1 - skipped ] = op->o_ctrls[ i ];
}
}
n += j1;
n += j1 - skipped;
if ( j2 ) {
ctrls[ n ] = (LDAPControl *)&ctrls[ n + j2 + 1 ] + j1;
*ctrls[ n ] = c[ j1 ];