mirror of
https://git.openldap.org/openldap/openldap.git
synced 2024-12-15 03:01:09 +08:00
Add XXX comment to cache modified from underneath kludge.
This commit is contained in:
parent
12cd6ddfb1
commit
a3f9a59e4b
@ -145,7 +145,7 @@ id2entry_rw( Backend *be, ID id, int rw )
|
||||
ldbm_cache_close( be, db );
|
||||
|
||||
if ( e == NULL ) {
|
||||
Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld ) (failed)\n",
|
||||
Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld ) (failed)\n",
|
||||
rw ? "w" : "r", id, 0 );
|
||||
return( NULL );
|
||||
}
|
||||
@ -160,7 +160,10 @@ id2entry_rw( Backend *be, ID id, int rw )
|
||||
if( cache_add_entry_rw( &li->li_cache, e, rw ) != 0 ) {
|
||||
entry_free( e );
|
||||
|
||||
/* maybe the entry got added underneath us */
|
||||
/* XXX this is a kludge.
|
||||
* maybe the entry got added underneath us
|
||||
* There are many underlying race condtions in the cache/disk code.
|
||||
*/
|
||||
if ( (e = cache_find_entry_id( &li->li_cache, id, rw )) != NULL ) {
|
||||
Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld ) 0x%lx (cache)\n",
|
||||
rw ? "w" : "r", id, (unsigned long) e );
|
||||
|
Loading…
Reference in New Issue
Block a user