mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2024-12-21 03:10:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

note a potential problem

Browse Source
This commit is contained in:
Pierangelo Masarati 2003-12-13 17:21:17 +00:00
parent 5a00f25542
commit 6e5ddd6420
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
servers/slapd/sasl.c
View File

@ -1794,6 +1794,13 @@ int slap_sasl_getdn( Connection *conn, Operation *op, char *id, int len,
len = dn->bv_len + sizeof("uid=")-1 + sizeof(",cn=auth")-1; len = dn->bv_len + sizeof("uid=")-1 + sizeof(",cn=auth")-1;
/* username may have embedded realm name */ /* username may have embedded realm name */
/* FIXME:
* 1) userids can legally have embedded '@' chars
* 2) we're mucking with memory we do not possess
* 3) this should not be required, since we're
* mostly doing strncpy's so we know how much
* memory to copy ...
*/
if( ( realm = strchr( dn->bv_val, '@') ) ) { if( ( realm = strchr( dn->bv_val, '@') ) ) {
*realm++ = '\0'; *realm++ = '\0';
len += sizeof(",cn=")-2; len += sizeof(",cn=")-2;
@ -1842,7 +1849,7 @@ int slap_sasl_getdn( Connection *conn, Operation *op, char *id, int len,
LDAP_LOG( TRANSPORT, ENTRY, LDAP_LOG( TRANSPORT, ENTRY,
"slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val, 0, 0 ); "slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val, 0, 0 );
#else #else
Debug( LDAP_DEBUG_TRACE, "getdn: u:id converted to %s\n", dn->bv_val,0,0 ); Debug( LDAP_DEBUG_TRACE, "slap_sasl_getdn: u:id converted to %s\n", dn->bv_val,0,0 );
#endif #endif
} else { } else {