From 375bc1ace7862ecafb2c4061203c537ae6532085 Mon Sep 17 00:00:00 2001 From: Hallvard Furuseth Date: Thu, 21 Apr 2011 17:50:50 +0200 Subject: [PATCH] ITS#6929 fclose(password file) on failure. lutil_get_filed_password() bug; klocwork issue#203. --- libraries/liblutil/passfile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libraries/liblutil/passfile.c b/libraries/liblutil/passfile.c index 11d16c7841..52225146e2 100644 --- a/libraries/liblutil/passfile.c +++ b/libraries/liblutil/passfile.c @@ -65,6 +65,7 @@ lutil_get_filed_password( passwd->bv_val = (char *) ber_memalloc( passwd->bv_len + 1 ); if( passwd->bv_val == NULL ) { perror( filename ); + fclose( f ); return -1; } @@ -79,6 +80,7 @@ lutil_get_filed_password( ber_memfree( passwd->bv_val ); passwd->bv_val = NULL; passwd->bv_len = 0; + fclose( f ); return -1; } nleft = passwd->bv_len; @@ -92,6 +94,7 @@ lutil_get_filed_password( ber_memfree( passwd->bv_val ); passwd->bv_val = NULL; passwd->bv_len = 0; + fclose( f ); return -1; }