mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2025-03-07 14:18:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

don't rely on attribute values in the returned entry: the control may act on attribute values not requested

Browse Source
This commit is contained in:
Pierangelo Masarati 2008-10-25 11:06:29 +00:00
parent 3b42e19253
commit 2c60719a13
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
servers/slapd/overlays/deref.c
View File

@ -280,16 +280,29 @@ deref_response( Operation *op, SlapReply *rs )
LDAPControl *ctrl, **ctrlsp; LDAPControl *ctrl, **ctrlsp;
AccessControlState acl_state = ACL_STATE_INIT; AccessControlState acl_state = ACL_STATE_INIT;
static char dummy = '\0'; static char dummy = '\0';
Entry *ebase;
int i; int i;
op->o_bd->bd_info = (BackendInfo *)dc->dc_on->on_info; op->o_bd->bd_info = (BackendInfo *)dc->dc_on->on_info;
rc = overlay_entry_get_ov( op, &rs->sr_entry->e_nname, NULL, NULL, 0, &ebase, dc->dc_on );
if ( rc != LDAP_SUCCESS || ebase == NULL ) {
op->o_bd->bd_info = bi;
return SLAP_CB_CONTINUE;
}
for ( ds = dc->dc_ds; ds; ds = ds->ds_next ) { for ( ds = dc->dc_ds; ds; ds = ds->ds_next ) {
Attribute *a = attr_find( rs->sr_entry->e_attrs, ds->ds_derefAttr ); Attribute *a = attr_find( ebase->e_attrs, ds->ds_derefAttr );
if ( a != NULL ) { if ( a != NULL ) {
DerefVal *dv; DerefVal *dv;
BerVarray *bva; BerVarray *bva;
if ( !access_allowed( op, rs->sr_entry, a->a_desc,
NULL, ACL_READ, &acl_state ) )
{
continue;
}
dr = op->o_tmpcalloc( 1, dr = op->o_tmpcalloc( 1,
sizeof( DerefRes ) + ( sizeof( DerefVal ) + sizeof( BerVarray * ) * ds->ds_nattrs ) * ( a->a_numvals + 1 ), sizeof( DerefRes ) + ( sizeof( DerefVal ) + sizeof( BerVarray * ) * ds->ds_nattrs ) * ( a->a_numvals + 1 ),
op->o_tmpmemctx ); op->o_tmpmemctx );
@ -374,6 +387,7 @@ deref_response( Operation *op, SlapReply *rs )
drp = &dr->dr_next; drp = &dr->dr_next;
} }
} }
overlay_entry_release_ov( op, ebase, 0, dc->dc_on );
op->o_bd->bd_info = bi; op->o_bd->bd_info = bi;
if ( drhead == NULL ) { if ( drhead == NULL ) {