mirror/openldap
2
0
Fork 0
mirror of https://git.openldap.org/openldap/openldap.git synced 2024-12-09 02:52:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

ITS#8731 NSSOV is not processable by coccinelle

Browse Source
This commit is contained in:
Ondřej Kuzník 2017-09-11 13:29:52 +00:00 committed by Ondřej Kuzník
parent abbabbb3d7
commit 251ce83d60
12 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/slapd-modules/nssov/alias.c
View File

@ -100,7 +100,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_alias_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_alias_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_ALIAS_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -110,7 +110,7 @@ NSSOV_HANDLE(
struct berval filter;
/* no parameters to read */
BER_BVZERO(&cbp.name);,
Debug(LDAP_DEBUG,"nssov_alias_all()\n",0,0,0);,
Debug(LDAP_DEBUG,"nssov_alias_all()\n");,
NSLCD_ACTION_ALIAS_ALL,
(filter=cbp.mi->mi_filter,0)
)

6
contrib/slapd-modules/nssov/ether.c
View File

@ -129,7 +129,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_ETHER_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -150,7 +150,7 @@ NSSOV_HANDLE(
addr.ether_addr_octet[4],
addr.ether_addr_octet[5]);
cbp.addr.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_byether(%s)\n",cbp.addr.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_byether(%s)\n",cbp.addr.bv_val);,
NSLCD_ACTION_ETHER_BYETHER,
nssov_filter_byid(cbp.mi,1,&cbp.addr,&filter)
)
@ -161,7 +161,7 @@ NSSOV_HANDLE(
/* no parameters to read */
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.addr);,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_ether_all()\n");,
NSLCD_ACTION_ETHER_ALL,
(filter=cbp.mi->mi_filter,0)
)

12
contrib/slapd-modules/nssov/group.c
View File

@ -281,14 +281,14 @@ NSSOV_HANDLE(
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;
if (!isvalidgroupname(&cbp.name)) {
Debug(LDAP_DEBUG_ANY,"nssov_group_byname(%s): invalid group name\n",cbp.name.bv_val,0,0);
Debug(LDAP_DEBUG_ANY,"nssov_group_byname(%s): invalid group name\n",cbp.name.bv_val);
return -1;
}
cbp.wantmembers = 1;
cbp.ni = ni;
BER_BVZERO(&cbp.gidnum);
BER_BVZERO(&cbp.user);,
Debug(LDAP_DEBUG_TRACE,"nslcd_group_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nslcd_group_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_GROUP_BYNAME,
nssov_filter_byname(cbp.mi,CN_KEY,&cbp.name,&filter)
)
@ -306,7 +306,7 @@ NSSOV_HANDLE(
cbp.ni = ni;
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.user);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_bygid(%s)\n",cbp.gidnum.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_bygid(%s)\n",cbp.gidnum.bv_val);,
NSLCD_ACTION_GROUP_BYGID,
nssov_filter_byid(cbp.mi,GID_KEY,&cbp.gidnum,&filter)
)
@ -320,14 +320,14 @@ NSSOV_HANDLE(
cbp.user.bv_len = tmpint32;
cbp.user.bv_val = cbp.buf;
if (!isvalidusername(&cbp.user)) {
Debug(LDAP_DEBUG_ANY,"nssov_group_bymember(%s): invalid user name\n",cbp.user.bv_val,0,0);
Debug(LDAP_DEBUG_ANY,"nssov_group_bymember(%s): invalid user name\n",cbp.user.bv_val);
return -1;
}
cbp.wantmembers = 0;
cbp.ni = ni;
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.gidnum);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_bymember(%s)\n",cbp.user.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_bymember(%s)\n",cbp.user.bv_val);,
NSLCD_ACTION_GROUP_BYMEMBER,
mkfilter_group_bymember(&cbp,&filter)
)
@ -340,7 +340,7 @@ NSSOV_HANDLE(
cbp.ni = ni;
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.gidnum);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_group_all()\n");,
NSLCD_ACTION_GROUP_ALL,
(filter=cbp.mi->mi_filter,0)
)

8
contrib/slapd-modules/nssov/host.c
View File

@ -121,7 +121,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_host_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_host_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_HOST_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -139,12 +139,12 @@ NSSOV_HANDLE(
/* translate the address to a string */
if (inet_ntop(af,addr,cbp.buf,sizeof(cbp.buf))==NULL)
{
Debug(LDAP_DEBUG_ANY,"nssov: unable to convert address to string\n",0,0,0);
Debug(LDAP_DEBUG_ANY,"nssov: unable to convert address to string\n");
return -1;
}
cbp.addr.bv_val = cbp.buf;
cbp.addr.bv_len = strlen(cbp.buf);,
Debug(LDAP_DEBUG_TRACE,"nssov_host_byaddr(%s)\n",cbp.addr.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_host_byaddr(%s)\n",cbp.addr.bv_val);,
NSLCD_ACTION_HOST_BYADDR,
nssov_filter_byid(cbp.mi,1,&cbp.addr,&filter)
)
@ -155,7 +155,7 @@ NSSOV_HANDLE(
/* no parameters to read */
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.addr);,
Debug(LDAP_DEBUG_TRACE,"nssov_host_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_host_all()\n");,
NSLCD_ACTION_HOST_ALL,
(filter=cbp.mi->mi_filter,0)
)

2
contrib/slapd-modules/nssov/netgroup.c
View File

@ -193,7 +193,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);,
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;
Debug(LDAP_DEBUG_TRACE,"nssov_netgroup_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_netgroup_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_NETGROUP_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)

8
contrib/slapd-modules/nssov/network.c
View File

@ -121,7 +121,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_network_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_network_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_NETWORK_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -139,12 +139,12 @@ NSSOV_HANDLE(
/* translate the address to a string */
if (inet_ntop(af,addr,cbp.buf,sizeof(cbp.buf))==NULL)
{
Debug(LDAP_DEBUG_ANY,"nssov: unable to convert address to string\n",0,0,0);
Debug(LDAP_DEBUG_ANY,"nssov: unable to convert address to string\n");
return -1;
}
cbp.addr.bv_val = cbp.buf;
cbp.addr.bv_len = strlen(cbp.buf);,
Debug(LDAP_DEBUG_TRACE,"nslcd_network_byaddr(%s)\n",cbp.addr.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nslcd_network_byaddr(%s)\n",cbp.addr.bv_val);,
NSLCD_ACTION_NETWORK_BYADDR,
nssov_filter_byid(cbp.mi,1,&cbp.addr,&filter)
)
@ -155,7 +155,7 @@ NSSOV_HANDLE(
/* no parameters to read */
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.addr);,
Debug(LDAP_DEBUG_TRACE,"nssov_network_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_network_all()\n");,
NSLCD_ACTION_NETWORK_ALL,
(filter=cbp.mi->mi_filter,0)
)

8
contrib/slapd-modules/nssov/nssov.h
View File

@ -116,15 +116,15 @@ void nssov_cfg_init(nssov_info *ni,const char *fname);
stream */
#define ERROR_OUT_WRITEERROR(fp) \
Debug(LDAP_DEBUG_ANY,"nssov: error writing to client\n",0,0,0); \
Debug(LDAP_DEBUG_ANY,"nssov: error writing to client\n"); \
return -1;
#define ERROR_OUT_READERROR(fp) \
Debug(LDAP_DEBUG_ANY,"nssov: error reading from client\n",0,0,0); \
Debug(LDAP_DEBUG_ANY,"nssov: error reading from client\n"); \
return -1;
#define ERROR_OUT_BUFERROR(fp) \
Debug(LDAP_DEBUG_ANY,"nssov: client supplied argument too large\n",0,0,0); \
Debug(LDAP_DEBUG_ANY,"nssov: client supplied argument too large\n"); \
return -1;
#define WRITE_BERVAL(fp, bv) \
@ -322,7 +322,7 @@ int pam_pwmod(nssov_info *ni,TFILE *fp,Operation *op,uid_t calleruid);
/* prepare the search filter */ \
if (mkfilter) \
{ \
Debug(LDAP_DEBUG_ANY,"nssov_" __STRING(db) "_" __STRING(fn) "(): filter buffer too small",0,0,0); \
Debug(LDAP_DEBUG_ANY,"nssov_" __STRING(db) "_" __STRING(fn) "(): filter buffer too small"); \
return -1; \
} \
cb.sc_private = &cbp; \

8
contrib/slapd-modules/nssov/passwd.c
View File

@ -399,11 +399,11 @@ NSSOV_HANDLE(
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;
if (!isvalidusername(&cbp.name)) {
Debug(LDAP_DEBUG_ANY,"nssov_passwd_byname(%s): invalid user name\n",cbp.name.bv_val,0,0);
Debug(LDAP_DEBUG_ANY,"nssov_passwd_byname(%s): invalid user name\n",cbp.name.bv_val);
return -1;
}
BER_BVZERO(&cbp.id); ,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_PASSWD_BYNAME,
nssov_filter_byname(cbp.mi,UID_KEY,&cbp.name,&filter)
)
@ -418,7 +418,7 @@ NSSOV_HANDLE(
cbp.id.bv_val = cbp.buf;
cbp.id.bv_len = snprintf(cbp.buf,sizeof(cbp.buf),"%d",uid);
BER_BVZERO(&cbp.name);,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_byuid(%s)\n",cbp.id.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_byuid(%s)\n",cbp.id.bv_val);,
NSLCD_ACTION_PASSWD_BYUID,
nssov_filter_byid(cbp.mi,UIDN_KEY,&cbp.id,&filter)
)
@ -429,7 +429,7 @@ NSSOV_HANDLE(
/* no parameters to read */
BER_BVZERO(&cbp.name);
BER_BVZERO(&cbp.id);,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_passwd_all()\n");,
NSLCD_ACTION_PASSWD_ALL,
(filter=cbp.mi->mi_filter,0)
)

6
contrib/slapd-modules/nssov/protocol.c
View File

@ -126,7 +126,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_PROTOCOL_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -141,7 +141,7 @@ NSSOV_HANDLE(
cbp.numb.bv_val = cbp.buf;
cbp.numb.bv_len = snprintf(cbp.buf,sizeof(cbp.buf),"%d",protocol);
BER_BVZERO(&cbp.name);,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_bynumber(%s)\n",cbp.numb.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_bynumber(%s)\n",cbp.numb.bv_val);,
NSLCD_ACTION_PROTOCOL_BYNUMBER,
nssov_filter_byid(cbp.mi,1,&cbp.numb,&filter)
)
@ -150,7 +150,7 @@ NSSOV_HANDLE(
protocol,all,
struct berval filter;
/* no parameters to read */,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_protocol_all()\n");,
NSLCD_ACTION_PROTOCOL_ALL,
(filter=cbp.mi->mi_filter,0)
)

6
contrib/slapd-modules/nssov/rpc.c
View File

@ -128,7 +128,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_RPC_BYNAME,
nssov_filter_byname(cbp.mi,0,&cbp.name,&filter)
)
@ -143,7 +143,7 @@ NSSOV_HANDLE(
cbp.numb.bv_val = cbp.buf;
cbp.numb.bv_len = snprintf(cbp.buf,sizeof(cbp.buf),"%d",number);
BER_BVZERO(&cbp.name);,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_bynumber(%s)\n",cbp.numb.bv_val,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_bynumber(%s)\n",cbp.numb.bv_val);,
NSLCD_ACTION_RPC_BYNUMBER,
nssov_filter_byid(cbp.mi,1,&cbp.numb,&filter)
)
@ -152,7 +152,7 @@ NSSOV_HANDLE(
rpc,all,
struct berval filter;
/* no parameters to read */,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_rpc_all()\n");,
NSLCD_ACTION_RPC_ALL,
(filter=cbp.mi->mi_filter,0)
)

6
contrib/slapd-modules/nssov/service.c
View File

@ -217,7 +217,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.pbuf);
cbp.prot.bv_len = tmpint32;
cbp.prot.bv_val = tmpint32 ? cbp.pbuf : NULL;,
Debug(LDAP_DEBUG_TRACE,"nssov_service_byname(%s,%s)\n",cbp.name.bv_val,cbp.prot.bv_val ? cbp.prot.bv_val : "",0);,
Debug(LDAP_DEBUG_TRACE,"nssov_service_byname(%s,%s)\n",cbp.name.bv_val,cbp.prot.bv_val ? cbp.prot.bv_val : "");,
NSLCD_ACTION_SERVICE_BYNAME,
mkfilter_service_byname(cbp.mi,&cbp.name,&cbp.prot,&filter)
)
@ -234,7 +234,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.pbuf);
cbp.prot.bv_len = tmpint32;
cbp.prot.bv_val = tmpint32 ? cbp.pbuf : NULL;,
Debug(LDAP_DEBUG_TRACE,"nssov_service_bynumber(%s,%s)\n",cbp.name.bv_val,cbp.prot.bv_val,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_service_bynumber(%s,%s)\n",cbp.name.bv_val,cbp.prot.bv_val);,
NSLCD_ACTION_SERVICE_BYNUMBER,
mkfilter_service_bynumber(cbp.mi,&cbp.name,&cbp.prot,&filter)
)
@ -244,7 +244,7 @@ NSSOV_HANDLE(
struct berval filter;
/* no parameters to read */
BER_BVZERO(&cbp.prot);,
Debug(LDAP_DEBUG_TRACE,"nssov_service_all()\n",0,0,0);,
Debug(LDAP_DEBUG_TRACE,"nssov_service_all()\n");,
NSLCD_ACTION_SERVICE_ALL,
(filter=cbp.mi->mi_filter,0)
)

10
contrib/slapd-modules/nssov/shadow.c
View File

@ -124,13 +124,13 @@ static long to_date(struct berval *date,AttributeDescription *attr)
if (a->a_numvals > 1) \
{ \
Debug(LDAP_DEBUG_ANY,"shadow entry %s contains multiple %s values\n", \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val,0); \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val); \
} \
var=strtol(a->a_vals[0].bv_val,&tmp,0); \
if ((a->a_vals[0].bv_val[0]=='\0')||(*tmp!='\0')) \
{ \
Debug(LDAP_DEBUG_ANY,"shadow entry %s contains non-numeric %s value\n", \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val,0); \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val); \
return 0; \
} \
}
@ -144,7 +144,7 @@ static long to_date(struct berval *date,AttributeDescription *attr)
if (a->a_numvals > 1) \
{ \
Debug(LDAP_DEBUG_ANY,"shadow entry %s contains multiple %s values\n", \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val,0); \
entry->e_name.bv_val, cbp->mi->mi_attrs[key].an_desc->ad_cname.bv_val); \
} \
var=to_date(&a->a_vals[0],cbp->mi->mi_attrs[key].an_desc); \
}
@ -241,7 +241,7 @@ NSSOV_HANDLE(
READ_STRING(fp,cbp.buf);,
cbp.name.bv_len = tmpint32;
cbp.name.bv_val = cbp.buf;
Debug(LDAP_DEBUG_ANY,"nssov_shadow_byname(%s)\n",cbp.name.bv_val,0,0);,
Debug(LDAP_DEBUG_ANY,"nssov_shadow_byname(%s)\n",cbp.name.bv_val);,
NSLCD_ACTION_SHADOW_BYNAME,
nssov_filter_byname(cbp.mi,UID_KEY,&cbp.name,&filter)
)
@ -251,7 +251,7 @@ NSSOV_HANDLE(
struct berval filter;
/* no parameters to read */
BER_BVZERO(&cbp.name);,
Debug(LDAP_DEBUG_ANY,"nssov_shadow_all()\n",0,0,0);,
Debug(LDAP_DEBUG_ANY,"nssov_shadow_all()\n");,
NSLCD_ACTION_SHADOW_ALL,
(filter=cbp.mi->mi_filter,0)
)