Be less forgiving (don't ignore so many configuration errors)

This commit is contained in:
Kurt Zeilenga 2002-06-08 18:38:52 +00:00
parent a784e4d054
commit 116e165a5c

View File

@ -850,12 +850,14 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, "%s: line %d: " LDAP_LOG(( "config", LDAP_LEVEL_INFO, "%s: line %d: "
"subordinate keyword must appear inside a database " "subordinate keyword must appear inside a database "
"definition (ignored).\n", fname, lineno )); "definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, "%s: line %d: suffix line " Debug( LDAP_DEBUG_ANY, "%s: line %d: suffix line "
"must appear inside a database definition (ignored)\n", "must appear inside a database definition.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
be->be_flags |= SLAP_BFLAG_GLUE_SUBORDINATE; be->be_flags |= SLAP_BFLAG_GLUE_SUBORDINATE;
num_subordinates++; num_subordinates++;
@ -1016,8 +1018,8 @@ read_config( const char *fname )
"\"suffixAlias <alias> <aliased_dn>\" line\n", "\"suffixAlias <alias> <aliased_dn>\" line\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return( 1 ); return( 1 );
} else if ( cargc > 3 ) { } else if ( cargc > 3 ) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_CRIT, LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
@ -1028,20 +1030,20 @@ read_config( const char *fname )
"%s: line %d: extra cruft in suffixAlias line (ignored)\n", "%s: line %d: extra cruft in suffixAlias line (ignored)\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
} }
if ( be == NULL ) { if ( be == NULL ) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: suffixAlias line must appear inside a " "%s: line %d: suffixAlias line must appear inside a "
"database definition (ignored).\n", fname, lineno )); "database definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: suffixAlias line" "%s: line %d: suffixAlias line"
" must appear inside a database definition (ignored)\n", " must appear inside a database definition.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} }
if ( load_ucdata( NULL ) < 0 ) return 1; if ( load_ucdata( NULL ) < 0 ) return 1;
@ -1141,23 +1143,25 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: depth line must appear inside a database " "%s: line %d: depth line must appear inside a database "
"definition (ignored)\n", fname, lineno )); "definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: depth line must appear inside a database definition (ignored)\n", "%s: line %d: depth line must appear inside a database definition.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else if ((i = atoi(cargv[1])) < 0) { } else if ((i = atoi(cargv[1])) < 0) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: depth must be positive (ignored).\n", "%s: line %d: depth must be positive.\n",
fname, lineno )); fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: depth must be positive (ignored)\n", "%s: line %d: depth must be positive.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
@ -1180,16 +1184,18 @@ read_config( const char *fname )
return( 1 ); return( 1 );
} }
if ( be == NULL ) { if ( be == NULL ) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: rootdn line must appear inside a database " "%s: line %d: rootdn line must appear inside a database "
"definition (ignored).\n", fname, lineno )); "definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: rootdn line must appear inside a database definition (ignored)\n", "%s: line %d: rootdn line must appear inside a database definition.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
struct berval dn; struct berval dn;
@ -1237,13 +1243,14 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, "%s: line %d: " LDAP_LOG(( "config", LDAP_LEVEL_INFO, "%s: line %d: "
"rootpw line must appear inside a database " "rootpw line must appear inside a database "
"definition (ignored)\n", fname, lineno )); "definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, "%s: line %d: " Debug( LDAP_DEBUG_ANY, "%s: line %d: "
"rootpw line must appear inside a database " "rootpw line must appear inside a database "
"definition (ignored)\n", "definition.\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
Backend *tmp_be = select_backend( &be->be_rootndn, 0, 0 ); Backend *tmp_be = select_backend( &be->be_rootndn, 0, 0 );
@ -1252,20 +1259,18 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: " "%s: line %d: "
"rootpw cannot be set when rootdn not under suffix " "rootpw can only be set when rootdn is under suffix\n"
"(ignored)\n",
fname, lineno )); fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, "%s: line %d: " Debug( LDAP_DEBUG_ANY, "%s: line %d: "
"rootpw cannot be set when rootdn not under suffix" "rootpw can only be set when rootdn is under suffix\n",
"(ignored)\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else {
be->be_rootpw.bv_val = ch_strdup( cargv[1] );
be->be_rootpw.bv_len = strlen( be->be_rootpw.bv_val );
} }
be->be_rootpw.bv_val = ch_strdup( cargv[1] );
be->be_rootpw.bv_len = strlen( be->be_rootpw.bv_val );
} }
/* make this database read-only */ /* make this database read-only */
@ -1774,12 +1779,13 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: replica line must appear inside " "%s: line %d: replica line must appear inside "
"a database definition (ignored).\n", fname, lineno )); "a database definition.\n", fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: replica line must appear inside a database definition (ignored)\n", "%s: line %d: replica line must appear inside a database definition\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
int nr = -1; int nr = -1;
@ -1795,27 +1801,28 @@ read_config( const char *fname )
if ( i == cargc ) { if ( i == cargc ) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: missing host in \"replica\" " "%s: line %d: missing host in \"replica\" line\n",
"line (ignored)\n", fname, lineno )); fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: missing host in \"replica\" line (ignored)\n", "%s: line %d: missing host in \"replica\" line\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else if ( nr == -1 ) { } else if ( nr == -1 ) {
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: unable to add" "%s: line %d: unable to add"
" replica \"%s\"" " replica \"%s\"\n",
" (ignored)\n",
fname, lineno, fname, lineno,
cargv[i] + 5 )); cargv[i] + 5 ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: unable to add replica \"%s\" (ignored)\n", "%s: line %d: unable to add replica \"%s\"\n",
fname, lineno, cargv[i] + 5 ); fname, lineno, cargv[i] + 5 );
#endif #endif
return 1;
} else { } else {
for ( i = 1; i < cargc; i++ ) { for ( i = 1; i < cargc; i++ ) {
if ( strncasecmp( cargv[i], "suffix=", 7 ) == 0 ) { if ( strncasecmp( cargv[i], "suffix=", 7 ) == 0 ) {
@ -1895,13 +1902,14 @@ read_config( const char *fname )
#ifdef NEW_LOGGING #ifdef NEW_LOGGING
LDAP_LOG(( "config", LDAP_LEVEL_INFO, LDAP_LOG(( "config", LDAP_LEVEL_INFO,
"%s: line %d: updatedn line must appear inside " "%s: line %d: updatedn line must appear inside "
"a database definition (ignored)\n", "a database definition\n",
fname, lineno )); fname, lineno ));
#else #else
Debug( LDAP_DEBUG_ANY, Debug( LDAP_DEBUG_ANY,
"%s: line %d: updatedn line must appear inside a database definition (ignored)\n", "%s: line %d: updatedn line must appear inside a database definition\n",
fname, lineno, 0 ); fname, lineno, 0 );
#endif #endif
return 1;
} else { } else {
struct berval dn; struct berval dn;