diff --git a/cmake/compiler-flags.cmake b/cmake/compiler-flags.cmake index d98844fe..5372a5cd 100644 --- a/cmake/compiler-flags.cmake +++ b/cmake/compiler-flags.cmake @@ -298,7 +298,6 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") add_compiler_flags(10 "-Wno-global-constructors") add_compiler_flags(10 "-Wno-gnu-zero-variadic-macro-arguments") add_compiler_flags(10 "-Wno-implicit-int-conversion") - add_compiler_flags(10 "-Wno-inconsistent-missing-destructor-override") add_compiler_flags(10 "-Wno-non-virtual-dtor") add_compiler_flags(10 "-Wno-padded") add_compiler_flags(10 "-Wno-pessimizing-move") diff --git a/src/oatpp/core/async/worker/IOEventWorker.hpp b/src/oatpp/core/async/worker/IOEventWorker.hpp index 90ad9514..81e2b2fd 100644 --- a/src/oatpp/core/async/worker/IOEventWorker.hpp +++ b/src/oatpp/core/async/worker/IOEventWorker.hpp @@ -104,7 +104,7 @@ public: /** * Virtual destructor. */ - ~IOEventWorker(); + ~IOEventWorker() override; /** * Push list of tasks to worker. @@ -158,7 +158,7 @@ public: /** * Virtual destructor. */ - ~IOEventWorkerForeman(); + ~IOEventWorkerForeman() override; /** * Push list of tasks to worker. diff --git a/src/oatpp/core/data/stream/BufferStream.hpp b/src/oatpp/core/data/stream/BufferStream.hpp index 42fe6726..bf240481 100644 --- a/src/oatpp/core/data/stream/BufferStream.hpp +++ b/src/oatpp/core/data/stream/BufferStream.hpp @@ -55,7 +55,7 @@ public: /** * Virtual destructor. */ - ~BufferOutputStream(); + ~BufferOutputStream() override; /** * Write `count` of bytes to stream. diff --git a/src/oatpp/core/data/stream/FileStream.hpp b/src/oatpp/core/data/stream/FileStream.hpp index b825420e..1ebff572 100644 --- a/src/oatpp/core/data/stream/FileStream.hpp +++ b/src/oatpp/core/data/stream/FileStream.hpp @@ -72,7 +72,7 @@ public: /** * Virtual destructor. */ - ~FileInputStream(); + ~FileInputStream() override; /** * Get file. @@ -160,7 +160,7 @@ public: /** * Virtual destructor. */ - ~FileOutputStream(); + ~FileOutputStream() override; /** * Get file. diff --git a/src/oatpp/core/provider/Pool.hpp b/src/oatpp/core/provider/Pool.hpp index 1a120fc6..b9bee415 100644 --- a/src/oatpp/core/provider/Pool.hpp +++ b/src/oatpp/core/provider/Pool.hpp @@ -365,7 +365,7 @@ public: return ptr; } - virtual ~PoolTemplate() { + virtual ~PoolTemplate() override { stop(); } diff --git a/src/oatpp/network/tcp/Connection.hpp b/src/oatpp/network/tcp/Connection.hpp index 3a7cb0ea..9aa336df 100644 --- a/src/oatpp/network/tcp/Connection.hpp +++ b/src/oatpp/network/tcp/Connection.hpp @@ -52,7 +52,7 @@ public: * Virtual Destructor (See &id:oatpp::base::Countable;). * Close socket handle. */ - ~Connection(); + ~Connection() override; /** * Implementation of &id:oatpp::data::stream::IOStream::write;. diff --git a/src/oatpp/network/tcp/client/ConnectionProvider.cpp b/src/oatpp/network/tcp/client/ConnectionProvider.cpp index ce070dd5..d84ba7d3 100644 --- a/src/oatpp/network/tcp/client/ConnectionProvider.cpp +++ b/src/oatpp/network/tcp/client/ConnectionProvider.cpp @@ -184,7 +184,7 @@ oatpp::async::CoroutineStarterForResult diff --git a/test/oatpp/core/data/buffer/ProcessorTest.cpp b/test/oatpp/core/data/buffer/ProcessorTest.cpp index 0b3c7bc1..ef62f670 100644 --- a/test/oatpp/core/data/buffer/ProcessorTest.cpp +++ b/test/oatpp/core/data/buffer/ProcessorTest.cpp @@ -161,7 +161,7 @@ public: COUNTER ++; } - ~TestCoroutine() { + ~TestCoroutine() override { COUNTER --; }