Commit Graph

2088 Commits

Author SHA1 Message Date
Thomas Kluyver
d68658e3a1 Don't show subprocess output if there isn't any 2013-10-21 17:48:13 -07:00
Thomas Kluyver
4bcd7bd44d Don't try to wait for StreamCapturer that was never started 2013-10-21 17:37:34 -07:00
Paul Ivanov
8b26933af5 Merge pull request #4378 from minrk/split-below
split adds new cell above, rather than below
2013-10-21 13:52:35 -07:00
Paul Ivanov
a2d731ff39 fix 'close and halt' in notebook File menu 2013-10-20 20:57:10 -07:00
MinRK
bf58dddf26 single warning message for bad startup notebook 2013-10-20 14:13:38 -07:00
MinRK
24174f31d9 use itertools.count for incrementing notebook filename 2013-10-20 14:09:01 -07:00
MinRK
cc08837111 fix created timestamp in notebook model 2013-10-20 14:08:47 -07:00
MinRK
f894dbe664 test upload of v2 notebooks 2013-10-18 19:30:52 -07:00
MinRK
50665831bd update copy API in js 2013-10-18 17:26:14 -07:00
MinRK
cf0218e2d1 don't use jsonapi in test_notebook_api 2013-10-18 16:35:52 -07:00
MinRK
66ccce69c6 copy_from in json, not in url param 2013-10-18 16:35:03 -07:00
MinRK
ef0d065712 test nbmanager.copy_notebook 2013-10-18 16:13:54 -07:00
MinRK
c8ce1e7c7a url_escape redirects 2013-10-18 16:13:54 -07:00
MinRK
aea1bbde6a s/session_id/id 2013-10-18 16:13:53 -07:00
MinRK
0558ec4ce0 Cells shouldn't know about Sessions 2013-10-18 16:13:53 -07:00
MinRK
7ea311ad64 escape URLs in Location headers 2013-10-18 16:13:53 -07:00
MinRK
99282f9e6b urllib.quote/unquote must be str on Python 2 2013-10-18 16:13:53 -07:00
MinRK
06d9b99141 update notebook api tests
with creation URL changes

also use unicode as the default name in tests,
to increase likelihood of catching unicode bugs.
2013-10-18 16:13:53 -07:00
MinRK
f11caf25e7 update notebook creation handlers
- only POST to directories (notebook picks name)
- only PUT to full paths
- PUT and POST should be equivalent aside from
  who picks the notebook name.
2013-10-18 16:13:53 -07:00
MinRK
60d12e4209 allow specifying destination in copy_notebook 2013-10-17 19:39:06 -07:00
MinRK
d1a36fe4c0 use 'id' for checkpoint ID key
rather than redundant checkpoint.checkpoint_id
2013-10-17 14:55:00 -07:00
MinRK
5a60141bed use splitext in notebook_list
fixes case where notebooks with '.' in name were misrendered
2013-10-17 14:31:20 -07:00
MinRK
11013e648d add utils.splitext to js
mimic Python os.path.splitext
2013-10-17 14:30:15 -07:00
MinRK
5ca1ad666d add missing cell.session in tooltip.js 2013-10-17 14:09:20 -07:00
MinRK
714afa7b0f fix initial-file opening in the notebook 2013-10-17 14:09:20 -07:00
MinRK
d739a72638 strip '/' from paths in template-render handlers 2013-10-17 14:09:20 -07:00
Brian E. Granger
36aa39e3b7 Improving tests and setting of Location header. 2013-10-17 14:09:20 -07:00
Brian E. Granger
9c42ca8a72 Fully removing .py file upload.
In the future all uploads should just use the contents web service
and we should support any type of file.
2013-10-17 14:09:20 -07:00
Brian E. Granger
51fc769edd Handle notebook downloads through the /files URL. 2013-10-17 14:09:20 -07:00
Brian E. Granger
59901ce88c Adding docstring to NotebookHandler.get. 2013-10-17 14:09:19 -07:00
Thomas Kluyver
6017f5d0ef Specify encoding for loading and saving notebooks. 2013-10-17 14:09:19 -07:00
Thomas Kluyver
05e85588cf Add some unicode testing for saving notebooks 2013-10-17 14:09:19 -07:00
Thomas Kluyver
cbc141c95c Fixes for notebook checkpoint APIs 2013-10-17 14:09:19 -07:00
Thomas Kluyver
3f46a05a14 Test notebook checkpoint APIs 2013-10-17 14:09:19 -07:00
MinRK
4a12890d65 disable download-as-pt
since it doesn't work. Adds a note about nbconvert needed to bring it back.
2013-10-17 14:09:19 -07:00
Thomas Kluyver
d089f7749f Use assertEqual, not deprecated assertEquals 2013-10-17 14:09:19 -07:00
Thomas Kluyver
836ad5f388 Add tests for interrupting & restarting kernel
These are in an existing test method, as starting and stopping kernels
for individual tests is expensive.
2013-10-17 14:09:19 -07:00
Thomas Kluyver
06fa301908 Refactor tests for kernels REST API 2013-10-17 14:09:18 -07:00
MinRK
821514bd72 cleanup weird 404 2013-10-17 14:09:18 -07:00
MinRK
fc4fb92580 review pass on multidir js 2013-10-17 14:09:18 -07:00
MinRK
e16a5807c7 fixup bad rebase 2013-10-17 14:09:18 -07:00
MinRK
8b9bb04d12 review pass on Sessions API 2013-10-17 14:09:18 -07:00
Thomas Kluyver
b1a0f2e8cc 404 on attempt to list notebooks in nonexistant directory 2013-10-17 14:09:18 -07:00
Thomas Kluyver
18f88d020f Add failing test for listing nonexistant directory 2013-10-17 14:09:18 -07:00
Thomas Kluyver
99969474e0 Fix notebook manager test 2013-10-17 14:09:17 -07:00
Thomas Kluyver
c18aaefbde Fix sessionmanager test 2013-10-17 14:09:17 -07:00
Thomas Kluyver
e240f21ea1 Clean up sessions code from static analysis 2013-10-17 14:09:17 -07:00
Thomas Kluyver
693cc97905 Fix some HTTP status codes in sessions API 2013-10-17 14:09:17 -07:00
Thomas Kluyver
b3d2698c11 Fix session API tests 2013-10-17 14:09:17 -07:00
Thomas Kluyver
a02bd3d5e4 Improve Session REST API tests 2013-10-17 14:09:17 -07:00
Thomas Kluyver
a6a7255454 Fix some notebook model tests 2013-10-17 14:09:17 -07:00
MinRK
acb4245035 unicode normalization in test_notebooks_api 2013-10-17 14:09:17 -07:00
Thomas Kluyver
9f4a4ab3f8 Check Location header from renaming notebook 2013-10-17 14:09:16 -07:00
Thomas Kluyver
9144e8e57b Fix check of notebook path 2013-10-17 14:09:16 -07:00
Thomas Kluyver
eb9a55ed6b Add test for and fix REST save with rename 2013-10-17 14:09:16 -07:00
Thomas Kluyver
b9310d0e05 Add test for copying notebook through REST API 2013-10-17 14:09:16 -07:00
Thomas Kluyver
7725025d52 Add test for saving notebook via REST API 2013-10-17 14:09:16 -07:00
Thomas Kluyver
85d3c39b5a Add test for REST API uploading notebook 2013-10-17 14:09:16 -07:00
Thomas Kluyver
9d9adb1186 Improve tests for notebook REST API 2013-10-17 14:09:15 -07:00
MinRK
6c88abe1d6 always set location on PATCH
don't redirect
2013-10-17 14:09:15 -07:00
MinRK
ac5434efba properly hook up tornado loggers 2013-10-17 14:09:15 -07:00
MinRK
5593526108 don't let empty strings introduce extra slashes in url_path_join 2013-10-17 14:09:15 -07:00
MinRK
dc65b33d14 simplify handler patterns
PATH pattern will now sometimes include leading slash,
but that's okay because nbmanager will strip them.

fewer redirect patterns needed
2013-10-17 14:09:15 -07:00
MinRK
a31cfdc8a8 ensure 'path' never has leading or trailing slash in nbmanager
Don't trust API callers to always get this right.
2013-10-17 14:09:15 -07:00
MinRK
83114a11d8 add TrailingSlashHandler
redirects all GET requests with a trailing slash
2013-10-17 14:09:15 -07:00
MinRK
a7f297f8f3 save before download-as
uses `async : false`

closes #852

download-as-py still unavailable.
2013-10-17 14:09:15 -07:00
MinRK
8b94ee2b47 use async : false to avoid pop-up blocker on New / Copy notebook 2013-10-17 14:09:14 -07:00
MinRK
b33ffa7068 update upload and copy
adds 'notebook.ipynb/copy' url handler

because we were putting too many things in a single POST handler.
2013-10-17 14:09:14 -07:00
MinRK
75e14424c6 cleanup old, unused /notebooks/foo API methods
these have moved to `/api/notebooks`
2013-10-17 14:09:14 -07:00
MinRK
4e12521082 fix dashboard upload 2013-10-17 14:09:14 -07:00
MinRK
c21ea96476 log exceptions parsing JSON 2013-10-17 14:09:14 -07:00
MinRK
5b1a648fc8 move os_path to FileNBMan
doesn't belong in base NotebookManager
2013-10-17 14:09:14 -07:00
MinRK
d1e0aded7d mixup notebook_list 2013-10-17 14:09:14 -07:00
MinRK
fe59217989 move url_[un]escape to utils from nbm 2013-10-17 14:09:13 -07:00
MinRK
16e8d0ff43 adjust definition of 'path' in notebooks
never includes leading or trailing '/'
2013-10-17 14:09:13 -07:00
MinRK
e46412e30f fix --notebook-dir configurable when there is no trailing slash 2013-10-17 14:09:13 -07:00
MinRK
cded90efe3 update json_errors decorator
separate handling of HTTPError and unhanded exceptions
2013-10-17 14:09:13 -07:00
MinRK
141d088a51 logo link to current tree level
rather than top level
2013-10-17 14:09:13 -07:00
MinRK
40f577b538 add utils.url_path_join
javascript equivalent of Python-side function.
2013-10-17 14:09:13 -07:00
MinRK
dd93a2211a add utils.js to tree template 2013-10-17 14:09:13 -07:00
MinRK
c79dcc8e73 quote data attributes
prevents errors when these are empty strings
2013-10-17 14:09:13 -07:00
Zachary Sailer
da58c8c470 Fixed session js ajax request.
Session was not creating a kernel object on the client side,
after the server created successfully created a session.
2013-10-17 14:09:12 -07:00
Zachary Sailer
d3e456d9a1 add tests to notebooks api
- check for correct status codes
- check headers location
- fix COPY api
2013-10-17 14:09:12 -07:00
Zachary Sailer
9e0beba86f adding to test_kernels_api.py
- Check all HTTP status code responses for requests
- Test invalid kernel IDs
- Check 'location' key in POST request to kernels
2013-10-17 14:09:12 -07:00
Zachary Sailer
c26700cd3a changes after session manager code review 2013-10-17 14:09:12 -07:00
Zachary Sailer
7aaaab0668 fixed notebook rename after nbmanager refactor 2013-10-17 14:09:12 -07:00
MinRK
14fd50f80b Simplify Tree handlers
- 404 on missing path
- only need one handler for each of redirect and dashboard,
  don't need duplicates.
- project property on Handlers is unclear
2013-10-17 14:09:12 -07:00
MinRK
ed66b8b8fe add path2url and url2path to html.utils 2013-10-17 14:09:12 -07:00
Zachary Sailer
2a946c62ab added tests to nbmanager for url encode/decode 2013-10-17 14:09:11 -07:00
Zachary Sailer
97bc426bb7 add error catching to kernel manager
also, adding further tests to kernel manager
2013-10-17 14:09:11 -07:00
Brian E. Granger
c0bc0410ce Review and refactoring of notebooks web service. 2013-10-17 14:09:11 -07:00
MinRK
5568cd5db0 ensure test_no_kernels runs first
since it expects a clean notebook server.
2013-10-17 14:09:11 -07:00
MinRK
b0468580f7 don't start new notebook server for each test *method*
it takes much too long.

This change starts a new notebook server for each test class.

Even that is probably too much, but the module organization makes it troublesome
to start a single notebook server for all services tests.
2013-10-17 14:09:11 -07:00
Zachary Sailer
27680dacb2 Code review changes.
Fixed handler issues and api tests from code review
from @minrk and @carreau.
2013-10-17 14:09:11 -07:00
Brian E. Granger
2d6f4628c4 Adding JSON error handling and fixing location headers. 2013-10-17 14:09:10 -07:00
Zachary Sailer
04c6a3cfac refactoring of nbmanager and filenbmanager
major clean up of the two managers. We make sure to follow
the standard models described in IPEP 16
2013-10-17 14:09:10 -07:00
Zachary Sailer
050a3098a8 review fixes on tests, add extra kernel api test 2013-10-17 14:09:10 -07:00
Zachary Sailer
e9ac1c2d37 add tests for session api 2013-10-17 14:09:10 -07:00
Zachary Sailer
8ce586a241 move notebooks api tests into notebooks/tests 2013-10-17 14:09:10 -07:00
Paul Ivanov
f517d44d4b removing contents changes from this PR 2013-10-17 14:09:10 -07:00