Kyle Kelley
b12f002b35
Performing check only on open.
2014-01-22 18:16:06 -06:00
Jonathan Frederic
2d13d05e9c
Replace O(N^2) algorithm with a faster one.
2014-01-22 16:14:20 -08:00
Jonathan Frederic
9e643f5692
Support multiple types in selection widget.
2014-01-22 15:53:58 -08:00
Jonathan Frederic
c9973a7114
Float widget views now inherit from int counterparts
2014-01-22 15:00:36 -08:00
Paul Ivanov
9b7c8b0473
make the JS test fail
2014-01-22 14:45:20 -08:00
Jonathan Frederic
2bb9ba9a9c
Adjusted throttling
2014-01-22 12:53:59 -08:00
Jonathan Frederic
9560b29beb
Removed float widget bound tests,
...
once the int widget inherits from the float, or vise-versa, the tests
will be covered by the int
2014-01-22 12:12:08 -08:00
Jonathan Frederic
1b8b6b3a88
Fixed bug where views child to other views would not have cell information
2014-01-22 12:04:53 -08:00
Jonathan Frederic
f06a0a7d5e
Fixed a couple more context typos
2014-01-22 11:31:01 -08:00
Jonathan Frederic
629d65da89
Fixed context errors and a couple of typos to get the tests working again
2014-01-22 11:16:50 -08:00
Matthias BUSSONNIER
98101f9c6c
add js kernel_info request
2014-01-22 09:01:13 +01:00
Matthias BUSSONNIER
cbe162297f
XSS casper test
2014-01-22 08:34:47 +01:00
Kyle Kelley
345de4e674
Use *args, **kwargs, log.warn
2014-01-21 21:08:24 -06:00
Jonathan Frederic
99f3f5155e
Fixed some typos related to _.each loops
2014-01-21 17:23:12 -08:00
Jonathan Frederic
d7b86104b8
Fixed typo - else -> elif
2014-01-21 17:14:34 -08:00
Jonathan Frederic
046280b51a
s/ModalView/PopupView
2014-01-21 17:09:49 -08:00
Jonathan Frederic
7ce9f37b17
Made tests reflect changes to widget naming scheme.
2014-01-21 16:52:37 -08:00
Jonathan Frederic
10bd54bd30
Move js *RangeWidget code into *Widget
2014-01-21 16:49:35 -08:00
Jonathan Frederic
e323f64e6d
Create base widget classes
2014-01-21 16:44:57 -08:00
Jonathan Frederic
b432b4840f
Use CUnicode for width and height in ImageWidget
2014-01-21 16:33:49 -08:00
Jonathan Frederic
c5e48c0b75
Added some small comments to widget code
2014-01-21 16:32:18 -08:00
Jonathan Frederic
80c3339791
- remove second line in create_child_view
...
- add undefined check in delete_child_view
2014-01-21 16:29:59 -08:00
Jonathan Frederic
58f56a5dd7
Explicitly return null if there aren't any results
2014-01-21 16:28:26 -08:00
Jonathan Frederic
08e40697de
Removed for () loops where necessary. Replaced with _.each
2014-01-21 16:26:03 -08:00
Jonathan Frederic
35a02a0436
Replace .html with .text everywhere possible
2014-01-21 15:38:37 -08:00
Jonathan Frederic
af4809bec4
Prefer JQuery to Underscore
2014-01-21 15:24:47 -08:00
Jonathan Frederic
d9a703d305
'create' should be handled in sync
2014-01-21 15:22:26 -08:00
Jonathan Frederic
2b27b4101b
Remove todo in apply update
2014-01-21 15:21:44 -08:00
Jonathan Frederic
e823d386ab
Fixed name conflict with _property_lock
2014-01-21 15:18:49 -08:00
Jonathan Frederic
077bd5c6ca
Added new CallbackDispatcher class
2014-01-21 15:14:27 -08:00
Jonathan Frederic
611614b6eb
Document in widget packing that vaues must be JSON-able.
2014-01-21 14:25:08 -08:00
Jonathan Frederic
cf05ef015a
ict comprehension and list comprehension in pack/unpack widgets
2014-01-21 14:23:44 -08:00
Jonathan Frederic
cb6094281c
s/custom_content/content
2014-01-21 14:17:57 -08:00
Jonathan Frederic
5fe860ed26
Added doc strings to properties in widget.py
2014-01-21 14:16:24 -08:00
Jonathan Frederic
1689eed2f6
Reorganized attrs in widget.py
2014-01-21 14:13:33 -08:00
Kyle Kelley
104275ab73
Indicate Py3 vs. Py2 codepath.
2014-01-21 14:47:58 -06:00
Jonathan Frederic
097951a6b8
Remove residual tabs
2014-01-21 12:35:39 -08:00
Kyle Kelley
5800b1c625
Get rid of exc_info as there isn't an exception.
2014-01-21 13:23:09 -06:00
Kyle Kelley
7b552d862d
Add Origin Checking.
2014-01-21 12:55:52 -06:00
MinRK
c2cb64c9a0
adjustments to notebook app logging
...
Mainly add a log_request function (from nbviewer) for formatting tornado access logs.
Relevant effects:
- demote successful access logs to DEBUG
- demote kernel connect messages to DEBUG
which reduces the noise at INFO-level (default)
2014-01-21 10:48:24 -08:00
Jonathan Frederic
b7cd129c37
Added a line that was accidently deleted during merge of 4e813c5
2014-01-21 11:05:32 +00:00
Jonathan Frederic
691cd56038
Change the callback logic so the order makes more sense:
...
*Now*
View calls Model which calls Widget Manager
*instead of *
View calls Widget Manager, which then the Model modifies right
before sync
2014-01-21 11:00:45 +00:00
Jason Grout
fe6edb26a6
Rewrite widget syncing
...
Conflicts:
IPython/html/static/notebook/js/widgetmanager.js
IPython/html/static/notebook/js/widgets/widget.js
2014-01-21 10:13:42 -08:00
Matthias BUSSONNIER
149867e74c
some $.html( -> $.text(
...
Thoses that are obvious and easy to fix.
we shoudl have I think a travis test that grep for .html( and return
less than 20 lines :-)
2014-01-17 22:25:33 -08:00
Jonathan Frederic
e17200a533
Widget require.js fix
...
The WidgetManager namespace is passed around instead of a
widget_manager instance...
2014-01-17 17:03:29 +00:00
Jonathan Frederic
c39050e642
Fixed widget_manager instance test.
2014-01-17 16:32:58 +00:00
Jonathan Frederic
469c865603
Added support for multiple kernels.
2014-01-17 16:22:57 +00:00
Jonathan Frederic
6871c8f9e0
Cherry pick of @jasongrout 's 2bc2f96.
...
Only merged changes to notebook and kernel... (see original comment below).
Separate the widget registry from the widget managers;
attach widget managers to kernels.
Yet to do: take care of clean-up when a kernel is deleted
Conflicts:
IPython/html/static/notebook/js/widgetmanager.js
IPython/html/static/notebook/js/widgets/widget.js
2014-01-17 15:36:49 +00:00
Jason Grout
140d1872f7
Delete unnecessary save
2014-01-17 15:21:30 +00:00
Jason Grout
ce19a34d93
Pass the whole message into the widget manager display_view call
...
We do this so implementations can see metadata and any other things in the message, if they want.
Conflicts:
IPython/html/static/notebook/js/widgetmanager.js
2014-01-17 15:21:06 +00:00
Jason Grout
092e40df32
make the saving to python a method of the model, called with callbacks
...
Conflicts:
IPython/html/static/notebook/js/widgets/widget.js
2014-01-17 15:10:17 +00:00
Jason Grout
24ec0da125
Fix the cell reference in views
...
This solution is kludgy, but it does fix what broke when we tried to take the cell references out of views.
Conflicts:
IPython/html/static/notebook/js/widgets/widget.js
2014-01-17 15:04:27 +00:00
Jonathan Frederic
7cc6692fc4
Make dropdown view DOM swap elements on update.
2014-01-17 10:37:08 +00:00
Matthias Bussonnier
0ec0534ce9
Merge pull request #4796 from minrk/update-components
...
update components
closes #4765
2014-01-16 09:53:07 -08:00
Jonathan Frederic
82bf9c6826
Fix bug in all children containing views
2014-01-16 17:19:35 +00:00
Jonathan Frederic
d317532a38
Halign dict colons
2014-01-16 17:17:00 +00:00
Jonathan Frederic
bd3ba3328c
Added PEP8 style comments to all of the JS code.
2014-01-16 16:48:14 +00:00
Jonathan Frederic
7387f886c6
containers and selectioncontainers now only allow one of any single child
2014-01-16 14:48:56 +00:00
Jonathan Frederic
bfdebf9632
More PEP8 changes
2014-01-16 14:20:04 +00:00
Jonathan Frederic
bad85fb879
Remove O(N) cell by msg-id lookup
2014-01-16 11:53:22 +00:00
Jonathan Frederic
ff39989b8b
s/Int/CInt s/Float/CFloat
2014-01-16 11:42:38 +00:00
Jonathan Frederic
2aeac3a424
Make widget views work with new keyboard manager.
2014-01-16 10:57:19 +00:00
Jonathan Frederic
f86fe40c97
Fix rebase issues
2014-01-16 10:57:19 +00:00
Jonathan Frederic
6286f8b1ea
Fab CSS
2014-01-16 10:57:19 +00:00
Jonathan Frederic
74185a68e7
Got containers and mutlicontainers working! Yay
2014-01-16 10:57:19 +00:00
Jonathan Frederic
16d9fa92e8
Fix test for selection widgets
2014-01-16 10:57:19 +00:00
Jonathan Frederic
4017c7b27a
Fixed *almost* all of the test-detected bugs
2014-01-16 10:57:19 +00:00
Jonathan Frederic
c085593e2a
More fixes
2014-01-16 10:57:18 +00:00
Jonathan Frederic
d694666e66
A lot of bug fixes...
...
Related to 1-to-1 changes
2014-01-16 10:57:18 +00:00
Jonathan Frederic
047a90538f
1-to-1 widget / view mapping
2014-01-16 10:57:18 +00:00
Jonathan Frederic
c1c7bb7563
Everyone uses one model
2014-01-16 10:57:18 +00:00
Jonathan Frederic
b16171ac76
Added sync=True to all view name attrs
2014-01-16 10:57:18 +00:00
Jonathan Frederic
cfe8a07337
Added sync= attr to DOMWidget
2014-01-16 10:57:18 +00:00
Jonathan Frederic
b4a83b6044
sync=True isntead of a keys list
2014-01-16 10:57:18 +00:00
Jonathan Frederic
00650fd64a
Dev meeting Jan 2014, widget review day 2
2014-01-16 10:57:18 +00:00
Jonathan Frederic
d3ffd25107
Dev meeting widget review day 1
2014-01-16 10:57:18 +00:00
Paul Ivanov
897d51a567
fix typos
2014-01-16 10:57:17 +00:00
Paul Ivanov
95e99c0c61
remove unused imports
2014-01-16 10:57:17 +00:00
Jonathan Frederic
d103c682c5
Many checks off the todo list, test fixes
2014-01-16 10:57:17 +00:00
Jonathan Frederic
f6de685d9f
Use .apply for calling base with not proto-type.
...
See codecell for example.
2014-01-16 10:57:17 +00:00
Jonathan Frederic
0f715170b3
Add a comment that explains the notion of the default element
...
to be styled in set_css's' doc string.
2014-01-16 10:57:17 +00:00
Jonathan Frederic
1e37a46a55
Add a helper method that acts on the changes made to a list.
2014-01-16 10:57:17 +00:00
Jonathan Frederic
be268dcf98
Implement a context manager as a property locking mechanism in Widget.
2014-01-16 10:57:17 +00:00
Jonathan Frederic
70c6a295d0
Finished renaming Multicontainer to SelectionContainer
2014-01-16 10:57:17 +00:00
Jonathan Frederic
a528610e07
renamed: ../static/notebook/js/widgets/widget_multicontainer.js -> ../static/notebook/js/widgets/widget_selectioncontainer.js
...
renamed: widget_multicontainer.py -> widget_selectioncontainer.py
2014-01-16 10:57:17 +00:00
Jonathan Frederic
643516f6f9
remove .html('');
2014-01-16 10:57:17 +00:00
Jonathan Frederic
c62b496b0e
s/image_format/format
2014-01-16 10:57:17 +00:00
Jonathan Frederic
b5f97c1227
add comment views are in *_range
2014-01-16 10:57:16 +00:00
Jonathan Frederic
5e9a090423
toggle button, set $el to button (removing extra div)
2014-01-16 10:57:16 +00:00
Jonathan Frederic
5b5325507f
add locks to update everywhere by using options to pass this
...
(and check for this)
2014-01-16 10:57:16 +00:00
Jonathan Frederic
c4edfdc828
comment model.set, so we know that it triggers update on other views
2014-01-16 10:57:16 +00:00
Jonathan Frederic
ccbfcbc159
make JS update comment more descriptive (english)
2014-01-16 10:57:16 +00:00
Jonathan Frederic
0740980d5c
remove length test add_class and remove_class
2014-01-16 10:57:16 +00:00
Jonathan Frederic
ec68f38ed7
Removed get_kernel method.
2014-01-16 10:57:16 +00:00
Jonathan Frederic
8dc5535638
un-nest options.options
2014-01-16 10:57:16 +00:00
Jonathan Frederic
a6fac70e03
s/BaseWidgetView/WidgetView and s/WidgetView/DOMWidgetView
2014-01-16 10:57:16 +00:00
Jonathan Frederic
44cf406ac0
this.updating should be a key specific lock
2014-01-16 10:57:16 +00:00
Jason Grout
d658f362ac
Update option-passing for creating child views.
2014-01-16 10:57:16 +00:00
Jonathan Frederic
3a271585d7
Add constructor comment for widget model.
2014-01-16 10:57:16 +00:00
Jonathan Frederic
d7835eb14e
Added missing comma
2014-01-16 10:57:16 +00:00
Jonathan Frederic
d3b33828c5
handle_msg a display_model method.
2014-01-16 10:57:15 +00:00
Jonathan Frederic
261e92de74
re-order handle custom msg and handle recieve state
2014-01-16 10:57:15 +00:00
Jonathan Frederic
3254f338bb
Added note in widget manager why Backbone.sync is there rather
...
than the base.js (widget.js)
2014-01-16 10:57:15 +00:00
Jonathan Frederic
3f3a7edd6a
remove on_create_widget and handle_create_widget callback
2014-01-16 10:57:15 +00:00
Jonathan Frederic
17da002a6a
remove msg.content.data.view_name and corrosponding create_view param
2014-01-16 10:57:15 +00:00
Jonathan Frederic
99d83a2ad1
move backbone sync outside the widget manager class
2014-01-16 10:57:15 +00:00
Jonathan Frederic
5dbffa5287
_model_types, _view_types, _models - and document what keys and values are
2014-01-16 10:57:15 +00:00
Jonathan Frederic
15dabce113
send_state only once for dict signature of set_css
2014-01-16 10:57:15 +00:00
Jonathan Frederic
6c11760a89
Fixed comments for optional kwargs so they are redundant.
2014-01-16 10:57:15 +00:00
Jonathan Frederic
670f4881ec
remove 3rd callback type from on_displayed
2014-01-16 10:57:15 +00:00
Jonathan Frederic
7e6c8e4f1d
Remove view_name from display
2014-01-16 10:57:15 +00:00
Jonathan Frederic
463bcf85ee
Fixed _send so it can open a comm if needed.
...
It no longer returns anything.
2014-01-16 10:57:14 +00:00
Jonathan Frederic
85b5adff58
Remove first three lines of repr widgets
2014-01-16 10:57:14 +00:00
Jonathan Frederic
e383594d04
renamed: basic_widgets.js -> init.js
...
renamed: init.js -> widget.js
2014-01-16 10:57:14 +00:00
Jonathan Frederic
5a3665d9ed
s/widget.js/init.js
2014-01-16 10:57:14 +00:00
Jonathan Frederic
5b388df615
Added callbacks method to view
2014-01-16 10:57:14 +00:00
Jonathan Frederic
5ced2816e7
Removed sync_method parameter from backbone msg spec
2014-01-16 10:57:14 +00:00
Jonathan Frederic
4e19dd7933
s/_handle_widget_constructed/_call_widget_constructed
2014-01-16 10:57:14 +00:00
Jonathan Frederic
39aaf7bf88
s/default_view_name/view_name
2014-01-16 10:57:14 +00:00
Jonathan Frederic
21a14e11a4
s/Widget/DOMWidget s/BaseWidget/Widget
2014-01-16 10:57:14 +00:00
Jonathan Frederic
696a6e4c28
add/remove_class now can accept a list of classes
2014-01-16 10:57:14 +00:00
Jonathan Frederic
2600913067
Removed ViewWidget
2014-01-16 10:57:14 +00:00
Jonathan Frederic
441a3e3ca6
Updated require.js references
2014-01-16 10:57:14 +00:00
Jonathan Frederic
ee522adc18
Renamed widget js files
2014-01-16 10:57:14 +00:00
Jonathan Frederic
691db01e5e
Missing view argument when recursively calling widgetmanager.callbacks(view)
2014-01-16 10:57:14 +00:00
Jonathan Frederic
babd5c44ba
Completely remove cell from model and view.
2014-01-16 10:57:13 +00:00
Jonathan Frederic
9e43807579
Updated comm id comments in view to model id
2014-01-16 10:57:13 +00:00
Jonathan Frederic
3329f875f3
s/comm_id/model_id (left over from before)
2014-01-16 10:57:13 +00:00
Jason Grout
a0b2cc40b8
Make widget keys have more explicit inheritance
2014-01-16 10:57:13 +00:00
Jason Grout
ce98452180
Get rid of keys magic; make the keys very explicit
2014-01-16 10:57:13 +00:00
Jason Grout
f0a4b9ea30
Make the widget keys property traverse the superclasses and accumulate the _keys attributes.
...
This caches the result, overwriting the property.
2014-01-16 10:57:13 +00:00
Jason Grout
7cbda99b0d
Add widget view options in creating child views
2014-01-16 10:57:13 +00:00
Jonathan Frederic
7c3b21d239
Fixed typo in model_id property
2014-01-16 10:57:13 +00:00
Jonathan Frederic
0c8b6029a6
Remove debug print statements in container tests
2014-01-16 10:57:13 +00:00
Jonathan Frederic
d2afb9895b
Output one more for debugging
2014-01-16 10:57:13 +00:00
Jonathan Frederic
7f430db3c8
Print cell output
2014-01-16 10:57:13 +00:00
Jonathan Frederic
12760ddbe5
deleted: wigets_container.js
2014-01-16 10:57:13 +00:00
Jonathan Frederic
74fccf47b3
Revert "Added line to dump page html casperjs"
...
This reverts commit 7091ce87f7a280dde7724d92fd542b834f764e61.
2014-01-16 10:57:13 +00:00
Jonathan Frederic
8891750535
Fixed static_url call which is no longer optionally 1 param
2014-01-16 10:57:12 +00:00
Jonathan Frederic
c7362cb524
Added line to dump page html casperjs
2014-01-16 10:57:12 +00:00
Jonathan Frederic
926c93eb84
Fixed indentation in widgetmanager.js
2014-01-16 10:57:12 +00:00
Jonathan Frederic
57f3057ca5
Moved view widget into widget.py
2014-01-16 10:57:12 +00:00
Jonathan Frederic
46e88dc205
Fixed indent of line 450
...
... caused Travis to get mad
2014-01-16 10:57:12 +00:00
Jonathan Frederic
a2235efbea
Further indentation cleanup
2014-01-16 10:57:12 +00:00
Jonathan Frederic
2e4abaa13d
Removed console.log, unused
2014-01-16 10:57:12 +00:00
Jonathan Frederic
35a536f3b8
Re-decoupled comm_id from widget models
2014-01-16 10:57:12 +00:00
Jonathan Frederic
1b4e2ad6fe
Added ViewWidget
2014-01-16 10:57:12 +00:00
Jonathan Frederic
399f11e2b2
renamed: wigets_container.js -> widgets_container.js
2014-01-16 10:57:12 +00:00
Jonathan Frederic
c3189c1c93
Fixed JS tests to reflect Jason's changes
2014-01-16 10:57:12 +00:00
Jonathan Frederic
8732761524
Added update_children
pattern to remaining parent widgets
2014-01-16 10:57:12 +00:00