Commit Graph

3634 Commits

Author SHA1 Message Date
Jonathan Frederic
992976844d Merge pull request #7302 from Carreau/1pix
a few 1 pixel fixes.
2014-12-29 11:58:53 -08:00
Jonathan Frederic
8d3f5b2865 invoke css 2014-12-29 09:14:39 -08:00
Jonathan Frederic
1a1c93b9d2 Remove modal less 2014-12-29 09:14:28 -08:00
Jonathan Frederic
2f982bd1e0 invoke css 2014-12-29 09:02:08 -08:00
Jonathan Frederic
239b4ab3dc Fix widget radii 2014-12-29 09:01:37 -08:00
Jonathan Frederic
3f2dc88154 Remove the popup widget 2014-12-29 08:08:20 -08:00
Scott Sanderson
631a68d83e TEST: Test separate roots for Contents and Checkpoints. 2014-12-29 07:01:39 -05:00
Scott Sanderson
f71f216880 DEV: More checkpoint API refactoring.
Changed the public checkpoint API to:
- `create_checkpoint(self, nb, path)`
- `get_checkpoint_content(self, checkpoint_id, path)`
- `rename_checkpoint(self, checkpoint_id, old_path, new_path)`
- `delete_checkpoint(self, checkpoint_id, path)`
- `list_checkpoints(self, path)`

All paths in the above are API-style paths, and the `nb` argument to
`create_checkpoint` is a dictionary suitable for passing to
`nbformat.write`.

The new `get_checkpoint_content` method returns an unvalidated notebook
content dictionary.  It is used by `ContentManager.restore_checkpoint`
to load content to be written via `save`.
2014-12-29 07:00:30 -05:00
Min RK
2587cf710c load kernel js, css, logo on spec_changed event
Ensures kernel.js is always loaded.
It wasn't being loaded when creating a new notebook with a particular kernel because `change_kernel` wasn't being called. Only the `spec_changed` event is triggered by all the various ways a kernel can be loaded,
so load kernel stuff on that event.
2014-12-28 23:59:12 -08:00
Min RK
026ec844f9 update new notebook button with kernelspec changes
display_name is in the spec, not top-level.
2014-12-28 23:26:05 -08:00
Matthias Bussonnier
c1d9f4d436 Merge pull request #7283 from minrk/kernel-spec-model
add resource URLs to kernelspec model
2014-12-28 16:38:50 +01:00
Min RK
c6b610f04f make FilesRedirectHandler redirect logic accessible
from a static method

instead of calling FRH.get(self), which doesn't work on Python 2
due to unbound method class checking.
2014-12-27 15:11:42 -08:00
Min RK
86dca85890 handle deprecated files redirect on /notebooks 2014-12-27 14:23:49 -08:00
Matthias Bussonnier
4e2dfe2527 Some code cleanup in javascript and python
change patern that are prone to error, like function redifinition
and other.
2014-12-27 21:39:07 +01:00
Min RK
96a5661648 fix scroll actions
div#notebook no longer scrolls at all.
Instead, only the body scrolls.
This may be a problem, but at least scroll actions work now.
2014-12-27 01:51:23 -08:00
Min RK
83f51e877c move Python-specific help links to kernel_info
help_links in kernel_info were already in the msg spec,
but not implemented.

Python-specific docs are now linked to the Python version.
2014-12-27 01:11:10 -08:00
Min RK
cb0c95575e friendlier error messages when invoke/lessc are missing
and not needed.
2014-12-27 00:16:28 -08:00
Scott Sanderson
dc295f67bd MAINT: Add missing config=Trues. 2014-12-27 00:48:57 -05:00
Scott Sanderson
4da8a30f20 DEV: Refactor checkpoint logic from FileContentsManager.
- Add a `CheckpointManager` base class and infrastructure for creating a
  `checkpoint_manager` instance attribute on `ContentsManager`.

- Provide default implementations of `delete` and `rename` in the base
  `ContentsManager` class.  `ContentsManager` subclasses are now
  required to implement `delete_file` and `rename_file`.  These methods
  no longer need to manage checkpoints.

- Move checkpoint-related functionality from `FileContentsManager` to a
  dedicated `FileCheckpointManager` subclass.

- Move shared filesystem interaction logic into `FileManagerMixin`
  used by both `FileContentsManager` and `FileCheckpointManager`.

- Minor tweaks to ContentsManager tests to get methods from the right
  object.

The purpose of this change is to provide an API for users to replace
just the checkpoint logic associated with a particular
`ContentsManager`.  In particular, this change makes it possible to
easily support remote storage of checkpoints while otherwise retaining
normal filesystem interactions.
2014-12-27 00:23:14 -05:00
Brian E. Granger
df578b8835 Merge pull request #7307 from Carreau/remove-white
remove whitespace below menubar when toolbar hidden.
2014-12-26 17:06:13 -08:00
Brian E. Granger
87ab53bcfe Merge pull request #7311 from Carreau/reform-css-2
Reform css 2
2014-12-26 16:59:45 -08:00
Brian E. Granger
dd2c077939 Merge pull request #7318 from Carreau/dialog-border-radius
fix border radius on element.
2014-12-26 16:49:23 -08:00
Matthias Bussonnier
031e829daf stack vertically keyboard shortcut on narrow viewport. 2014-12-26 19:07:59 +01:00
Matthias Bussonnier
0165e97c7c unify submenu style with menu style
closes #7303.

Also change the arrow that indicate submenu for a fontawesoem icon,
instead of the ugly hack that show only the left border of a rectangle element
which with is twice the one of its border to get a triangle.
2014-12-26 18:03:40 +01:00
Matthias Bussonnier
39444a7190 fix border radius on element.
set a value to border-radius large, and actually make border radius
small smaller than border radius large.

Make dialog border radius coherent with the rest of the UI.
2014-12-26 17:56:19 +01:00
Min RK
52d37ca17a Merge pull request #7312 from quantopian/refactor-contents-update
MAINT: Move `update` from FileContentsManager to ContentsManager.
2014-12-25 12:55:14 -08:00
Min RK
729c233f7d Merge pull request #7308 from Carreau/reform-css
reformat css
2014-12-25 12:49:09 -08:00
Scott Sanderson
9aad3c631f MAINT: Move update from FileContentsManager to ContentsManager.
The implementation in FileContentsManager is written entirely in terms
of the required API, and is sensible for other ContentsManager
implementations.
2014-12-25 13:17:10 -05:00
Matthias Bussonnier
160690f50a reformat css
cause I want to inject some variable in it after (like border radius)
and a few other thigs.

This is just a reformating that does not change the generated css.
2014-12-25 11:42:36 +01:00
Min RK
d94479ad29 Merge pull request #7251 from Carreau/unregister-preset
add ability to unregister a preset
2014-12-24 13:21:55 -08:00
Matthias Bussonnier
54a3f47905 remove whitespace below menubar when toolbar hidden.
closes #7292
2014-12-24 18:54:20 +01:00
Min RK
47b41d980b Merge pull request #7287 from Carreau/mistake
binary or is rare in JS
2014-12-23 20:19:54 -08:00
Jonathan Frederic
09b289d932 Merge pull request #7274 from Carreau/global-command
make global css change on command/edit mode
2014-12-23 18:20:19 -08:00
Matthias Bussonnier
27f3c224c2 a few 1 pixel fixes.
this uses the same html/css structure acroos the tabs, and reduce the overlay
click zone that expended the size of the header to 25px instead of 24px
2014-12-23 23:20:03 +01:00
Matthias Bussonnier
b003b62de4 Actually test that the j-nth cell. 2014-12-23 22:29:51 +01:00
Brian E. Granger
7b21e13705 Merge pull request #7242 from jdfreder/terminal-fixes
Some UI design changes for the Notebook and associates
2014-12-23 13:20:20 -08:00
Jonathan Frederic
34c08c035f New file open editor 2014-12-23 12:31:54 -08:00
Jonathan Frederic
6e86c7645b Fix JS test new button selector 2014-12-23 12:15:06 -08:00
Jonathan Frederic
9e3b18605a Reverse order of file/folder and notebooks in new menu 2014-12-23 12:15:06 -08:00
Jonathan Frederic
e593e6a123 Dont prompt for name. 2014-12-23 12:15:06 -08:00
Jonathan Frederic
2c43bc60ae invoke css 2014-12-23 12:15:06 -08:00
Jonathan Frederic
e0adde46f3 New new button 2014-12-23 12:15:06 -08:00
Jonathan Frederic
849c96ae61 Merge pull request #7268 from Carreau/ungroup-button
ungroup button on dashboard
2014-12-23 11:24:30 -08:00
Jonathan Frederic
c6548ebe0e Merge pull request #7288 from Carreau/that/this
remove that.
2014-12-23 11:17:37 -08:00
Matthias Bussonnier
7a295d1924 Merge pull request #7273 from Carreau/content-no-namespace
Do not inject self in IPython namespace
2014-12-23 19:35:16 +01:00
Matthias Bussonnier
123c0f3b28 remove that. 2014-12-23 13:00:57 +01:00
Matthias Bussonnier
6b57f44bf6 ungroup button on dashboard
fix a few instanced of button toolbar that were not with the right class or not in btn groups.
2014-12-23 11:32:15 +01:00
Matthias Bussonnier
1dfdda6e97 binary or is rare in JS 2014-12-23 11:07:43 +01:00
Min RK
43da311f5e add Notebook.ensure_extension
allows override of file-extension logic in notebook extensions
2014-12-22 13:21:14 -08:00
Matthias Bussonnier
06d4d1505a Merge pull request #7266 from Carreau/shutdown-orange
make shutdown yellow/orange
2014-12-22 18:12:29 +01:00
Min RK
e7b6d5dec3 update kernelspec model tests 2014-12-21 14:59:55 -08:00
Min RK
a417785c5e add resource URLs to kernelspec model
- move kernelspec itself to model.spec
- add resources top-level key with resource URLs
- no more 404s or HEAD requests under normal circumstances
2014-12-21 14:41:12 -08:00
Min RK
ad995dfdb8 Merge pull request #7244 from minrk/rm-signature
don't store signatures in notebooks
2014-12-20 16:47:05 -08:00
Thomas Kluyver
217e758e3d Merge pull request #7264 from dongweiming/custom_js_3.0
Update custom.js for 3.0
2014-12-19 17:14:10 -08:00
dongweiming
85a2a88396 Update custom.js for 3.0 2014-12-20 08:34:23 +08:00
Thomas Kluyver
fa7423383e Merge pull request #7191 from minrk/contents-test-reuse
abstract some methods in contents service tests
2014-12-19 13:37:53 -08:00
Min RK
4404c7ea2b checkpoint 2014-12-19 13:10:47 -08:00
Min RK
979eb2d281 don't enforce .ipynb extension in URLs
let ContentsManager decide what's a notebook
2014-12-19 12:42:28 -08:00
Min RK
db5147998d docstring on test_dir 2014-12-19 12:26:16 -08:00
Thomas Kluyver
eb93afeaf8 Merge pull request #7254 from quantopian/type-not-dotted-object
MAINT: Use `Type` instead of `DottedObjectName` for managers.
2014-12-19 11:28:53 -08:00
Bussonnier Matthias
9c959ce6b1 correct variable name 2014-12-19 15:50:48 +01:00
Bussonnier Matthias
15ab64e884 make global css change on command/edit mode 2014-12-19 15:20:16 +01:00
Bussonnier Matthias
eaf8fdc4f9 Do not inject self in IPython namespace
And do not require nemaespace either

    - this is bad practice, and this prevent from
    writing a blended content manager that works both
    with drive and localhost as they shoudl both export
    themselves to IPython.Contents module.
2014-12-19 14:55:30 +01:00
Scott Sanderson
acf011bd9c DEV: Tweaks to Login/LogoutHandler setup.
- Require handlers to be tornado.web.RequestHandlers.  Rename the
- NotebookApp attributes from log{in,out}_handler to log{in,out}_handler_class.
2014-12-19 00:52:21 -05:00
Jonathan Frederic
7926c36b0d Remove right margin from the terminal 2014-12-18 16:28:59 -08:00
Jonathan Frederic
8d2e57e3ef invoke css 2014-12-18 15:37:41 -08:00
Jonathan Frederic
028b79b385 Move kernel logo to right margin. 2014-12-18 15:37:22 -08:00
Jonathan Frederic
fd5659427d invoke css 2014-12-18 15:19:36 -08:00
Jonathan Frederic
2c714357c4 Review comments 2014-12-18 15:19:36 -08:00
Jonathan Frederic
359bc2e1bc invoke css 2014-12-18 15:19:36 -08:00
Jonathan Frederic
096b1638bf Remove padding on editor 2014-12-18 15:19:36 -08:00
Jonathan Frederic
7daba81475 invoke css 2014-12-18 15:19:36 -08:00
Jonathan Frederic
cda53215ba Improve edit app 2014-12-18 15:19:36 -08:00
Jonathan Frederic
b81a9f6bc6 invoke css 2014-12-18 15:19:36 -08:00
Jonathan Frederic
972065ad22 Additional aesthetic clean-up 2014-12-18 15:19:36 -08:00
Jonathan Frederic
461b2e74b6 invoke css 2014-12-18 15:19:36 -08:00
Jonathan Frederic
94a893d975 Prevent terminal from scrolling 2014-12-18 15:19:36 -08:00
Jonathan Frederic
fbc2adf2d5 Make things consistent 2014-12-18 15:19:36 -08:00
Jonathan Frederic
4e7832cf64 invoke css 2014-12-18 15:19:35 -08:00
Jonathan Frederic
726c95cbff Address review comments 2014-12-18 15:19:35 -08:00
Bussonnier Matthias
2b0147c21a no shadow on print media
Also hide celltoolbars
2014-12-18 15:19:35 -08:00
Matthias Bussonnier
6e9ef7abeb Style notebook as a document 2014-12-18 15:19:35 -08:00
Jonathan Frederic
4d62ad0df6 invoke css 2014-12-18 15:19:35 -08:00
Jonathan Frederic
79fe99d124 Make terminal pretty 2014-12-18 15:19:35 -08:00
Jonathan Frederic
3969f0ec84 Move terminal less into better location 2014-12-18 15:19:35 -08:00
Jonathan Frederic
f8968df7e2 Merge pull request #7148 from minrk/kernel-selector
remove kernel selector from header
2014-12-18 15:16:23 -08:00
Bussonnier Matthias
bb61df5c35 make shutdown yellow/orange 2014-12-18 20:07:01 +01:00
Jonathan Frederic
196478b765 Merge pull request #7260 from takluyver/widgetvaluedefaults
Widget values as positional arguments
2014-12-18 08:05:11 -08:00
Matthias Bussonnier
27c90f1da3 Merge pull request #7087 from nheijermans/master
Enable the IPython Notebook to display messages from other clients.
2014-12-18 09:19:44 +01:00
Scott Sanderson
8e2286911d DEV: Set klass=object for Log{in,out}Handler.
It seems plausible that people will implement custom handlers that
aren't subclasses of a known type.

Another possible option would be `IPythonHandler`, but even that feels
too restrictive.
2014-12-18 01:59:19 -05:00
Scott Sanderson
0953de3432 MAINT: Remove unused imports.
I was in the neighborhood...
2014-12-18 01:59:19 -05:00
Scott Sanderson
8ab449cd9a MAINT: Use Type instead of DottedObjectName Log{in,out}Handler. 2014-12-18 01:59:19 -05:00
Scott Sanderson
23b3a332f9 MAINT: Use Type instead of DottedObjectName for managers.
`Type` is strictly more powerful than `DottedObjectName` and is easier
for users to override.
2014-12-18 01:59:19 -05:00
Min RK
00e4ad59c0 add counter to new notebooks in test_manager
ensures brand new notebooks are untrusted

previously, all new notebooks were identical,
so once one was trusted, they would all start trusted.
2014-12-17 14:27:38 -08:00
Thomas Kluyver
9c0fb7bf68 Use more conventional *args naming over *parg 2014-12-17 12:47:56 -08:00
Thomas Kluyver
cbb685b314 Fix copy-pasted super() call 2014-12-17 12:47:04 -08:00
Jason Goad
cda015340c added value positional argument to applicable widgets 2014-12-17 12:45:58 -08:00
Jason Goad
7bcced9da0 widget fix? 2014-12-17 12:43:17 -08:00
Scott Sanderson
a1ad9abe51 MAINT: Unicode literal in assertDictContainsSubset 2014-12-17 11:38:46 -08:00
Scott Sanderson
4a2149d1c3 TEST: Add a non-notebook file to directory test. 2014-12-17 11:38:46 -08:00
Scott Sanderson
af7d1cdb50 STY: Define dirs as a single expression. 2014-12-17 11:38:46 -08:00
Scott Sanderson
f7cf204b25 BUG: Convert to bytes before comparing binary blobs. 2014-12-17 11:38:46 -08:00
Scott Sanderson
e9b81b6c7a TEST: Verify base64 return values after decoding. 2014-12-17 11:38:45 -08:00
Scott Sanderson
fcc1bbecb3 MAINT: Remove unused blob and b64_blob attributes. 2014-12-17 11:38:45 -08:00
Scott Sanderson
f20a7b41cb TEST: Abstract out directory/file deletion methods. 2014-12-17 11:38:45 -08:00
Scott Sanderson
46f299ccf2 TEST: Refactor symlink tests. 2014-12-17 11:38:45 -08:00
Min RK
a4b47e7e8a move symlink tests to TestFileManager 2014-12-17 11:38:45 -08:00
Scott Sanderson
61c2e0442f TEST: Add checks for subdirectory name splitting.
Previously the tests failed to catch a bug where a ContentsManager
didn't split name from path in a nested subdirectory.
2014-12-17 11:38:45 -08:00
Scott Sanderson
c7ca3066ec TEST: More fine-grained test for directory contents.
Verify that each entry in a directory listing matches the result of a
content-less direct get.
2014-12-17 11:38:45 -08:00
Scott Sanderson
23e5e6da4f TEST: Expect a 404 on delete of non-existent file. 2014-12-17 11:38:45 -08:00
Scott Sanderson
6bfab2de08 BUG: Allow for the possibility that to_path is empty string.
This is a legal input for representing the root directory.
2014-12-17 11:38:45 -08:00
Scott Sanderson
44805b94db BUG: Sanitize to_path in ContentsManager.copy.
Without this, one of the test cases in `test_copy` attempts a copy to a
directory that starts with a leading double-slash.
2014-12-17 11:38:45 -08:00
Scott Sanderson
7ab1bf7487 BUG: Set default mimetype when base64 is requested 2014-12-17 11:38:44 -08:00
Min RK
c166a05f5d abstract some methods in contents service tests
should allow re-use for ContentsManager subclasses
2014-12-17 11:38:44 -08:00
Min RK
53d1f1b1a1 Merge pull request #7259 from takluyver/kernelspec-head-error
Fix HEAD requests for kernelspec resources
2014-12-17 11:06:44 -08:00
Thomas Kluyver
c7f2a8689e Merge pull request #7253 from minrk/async-contents-handlers
allow ContentsManager methods to return Futures
2014-12-17 11:03:08 -08:00
Thomas Kluyver
49fbae9751 Fix HEAD requests for kernelspec resources
Closes gh-7237
Closes gh-7258

StaticFileHandler.get() is a coroutine. When Tornado calls a handler
method, it uses the return value to determine whether or not it's a
coroutine. So when head() calls get(), it needs to pass the return value
on for Tornado to handle it properly.
2014-12-17 10:40:55 -08:00
Min RK
41b548bacc use gen.Return for Python 2 2014-12-16 21:20:09 -08:00
Min RK
da95c496d9 transparent gif placeholder src
avoids invalid empty src
2014-12-16 21:14:52 -08:00
Min RK
9f9714e11f remove kernel logo text placeholder 2014-12-16 21:14:51 -08:00
Min RK
da88bff678 add text placeholder for kernels with no logo
capital first initial on gray field
2014-12-16 21:14:23 -08:00
Min RK
d5f6aaa1f6 remove kernel selector from header
- add kernel name to indicator
- float kernel logo where indicator used to be
2014-12-16 21:13:36 -08:00
Min RK
dc70ae6b07 allow ContentsManager methods to return Futures
mainly adding `@gen.coroutine` and `yield gen.maybe_future` all over the place.

No FileContentsManager methods are actually async at this point.
2014-12-16 15:01:59 -08:00
Brian E. Granger
6c55690994 Merge pull request #7227 from jdfreder/undead
Add visual cue for widgets with dead comms
2014-12-16 14:56:58 -08:00
Jonathan Frederic
e7370be7cc invoke css 2014-12-16 11:32:54 -08:00
Jonathan Frederic
79fd5c3fed Address comments 2014-12-16 11:32:43 -08:00
Thomas Kluyver
5a5f621591 Merge pull request #7247 from Carreau/fix-restore-checkpoint
fix restore checkpoint add an empty cell
2014-12-16 11:07:20 -08:00
Thomas Kluyver
2dbc8f5304 Merge pull request #7248 from Carreau/config-ctm
pass config to contentsManager
2014-12-16 10:07:09 -08:00
Bussonnier Matthias
f0c5de7c7e make method private 2014-12-16 18:13:14 +01:00
Min RK
0c39228307 Merge pull request #7250 from Carreau/kspecbase
fix logo on base_url prefix
2014-12-16 08:39:30 -08:00
Bussonnier Matthias
ddbd7aa4fa add ability to unregister a preset
fix #7218
2014-12-16 17:26:17 +01:00
Jonathan Frederic
6b2333fc51 Merge pull request #7229 from jdfreder/tab-rename
Tab rename - s/Notebooks/Files
2014-12-16 07:58:41 -08:00
Bussonnier Matthias
3bce53e32e fix logo on base_url prefix 2014-12-16 16:37:47 +01:00
Bussonnier Matthias
51f1cad6e4 pass config to contentsManager 2014-12-16 16:11:39 +01:00
Bussonnier Matthias
df418c6a62 fix restore checkpoint add an empty cell 2014-12-16 14:04:20 +01:00
Matthias Bussonnier
449384e85f Merge pull request #7224 from jasongrout/fix-toolbarjs
Fix javascript iteration through array
2014-12-16 11:51:26 +01:00
Matthias Bussonnier
7eb4d1b84d Merge pull request #7225 from Carreau/fix-actions
fix leading underscore
2014-12-16 11:37:57 +01:00
Matthias Bussonnier
efbe695523 Merge pull request #7226 from takluyver/win-sleep-session-tests
Add a brief sleep after shutting down sessions in test teardown
2014-12-16 10:33:53 +01:00
Matthias Bussonnier
420f2337de Merge pull request #7195 from Carreau/manager
generalise manager
2014-12-16 09:37:07 +01:00
Jonathan Frederic
ab1fca9fdb Prevent the page from jumping on tree tab change 2014-12-15 16:30:23 -08:00
Jonathan Frederic
a485fe42ea s/Notebooks/Files 2014-12-15 16:07:45 -08:00
Jonathan Frederic
d9346c002d invoke css 2014-12-15 13:39:28 -08:00
Jonathan Frederic
9e67a34891 Bubble event and implement logic in CodeCell 2014-12-15 13:30:59 -08:00
Matthias Bussonnier
5829ceacb9 s/Json/JSON/g **/*.py 2014-12-15 21:54:54 +01:00
Thomas Kluyver
0178e2add0 Add a brief sleep after shutting down sessions in test teardown
This fixes a test failure for me on my Windows VM. See the comment for
details.
2014-12-15 12:45:45 -08:00
Matthias Bussonnier
420fee5e4c Merge pull request #7163 from jdfreder/refresh-persist
Persist widgets across page refresh
2014-12-15 21:01:14 +01:00
Thomas Kluyver
b408a9bf74 Merge pull request #7167 from minrk/less-2
pin less to 2.x
2014-12-15 11:40:46 -08:00
Jonathan Frederic
2d40eb30d4 Make sure comm-dead is applied to the top widget view class
in all cases where the kernel disconnects.
2014-12-15 11:25:31 -08:00
Min RK
26136f44d2 Merge pull request #7088 from Carreau/kernel.js
Load the per kernel kernel.js and kernel.css
2014-12-15 10:33:35 -08:00
Min RK
420b98dfee Merge pull request #7177 from Carreau/valid-html
Valid html
2014-12-15 10:32:20 -08:00