Commit Graph

125 Commits

Author SHA1 Message Date
MinRK
d37780c6a6 use config instead of App.instance to propagate notebook_dir
Should behave more logically (I hope).
2014-02-21 13:22:57 -08:00
MinRK
cb25736a24 reorganize who knows what about paths
- add NotebookApp.notebook_dir
- add KernelManager.root_dir
- remove NotebookManager.notebook_dir, move to FileNBM.notebook_dir

Default value for KM.root_dir and fNBM.notebook_dir is NotebookApp.notebook_dir, but they can be configured separately.

SessionManager passes the API path to KernelManager,
which is responsible for turning it into the kernel's cwd.
2014-02-21 13:22:56 -08:00
Konrad Hinsen
fdb8ab37ae Rearrange the NotebookManager methods for clarity
Methods are organized into three categories:
 - Methods that must be implemented in subclasses
 - Methods that have default implementations, but can
   be overridden if required.
 - Support methods meant to be called by methods in subclasses
2014-02-11 12:30:19 +01:00
Konrad Hinsen
b1c6ba2c97 Move method increment_filename from FileNotebookManager to NotebookManager
The implementation requires only a minor change (call notebook_exists
rather than checking for file existence) to be universally usable
in other notebook managers.
2014-02-11 12:26:57 +01:00
Konrad Hinsen
0a430f5840 Add method notebook_exists to NotebookManager.
It is called by IPython.html.notebook.NotebookHandler.get,
so it must be implemented by every notebook handler.
2014-02-11 12:26:06 +01:00
Konrad Hinsen
26e3e31ad8 NotebookManager API: rename *notebook_model methods to *notebook 2014-02-11 12:25:57 +01:00
MinRK
e1e0b19a6a s/base_project_url/base_url/
deprecate NotebookApp.base_project_url
2014-02-08 23:09:24 -08:00
Brian E. Granger
eb9e0be218 Small refactoring of is_hidden to take root as default kwarg. 2014-02-05 16:43:11 -08:00
Brian E. Granger
243392d810 Creating and testing IPython.html.utils.is_hidden. 2014-02-05 13:09:55 -08:00
Brian E. Granger
7e1a179a7c Addressing review comments.
* list_dirs and get_dir_model added to base NBM class.
* Calling of list_dirs moved to handler.
* type=notebook added to notebook model.
2014-02-05 12:01:11 -08:00
Brian E. Granger
717f031e01 Adding dashboard navigation tests for dir browsing. 2014-02-04 15:53:28 -08:00
Brian E. Granger
c1a8f5af6a Get the existing tests working. 2014-02-04 15:53:28 -08:00
Brian E. Granger
45a8d046c8 Add support for index.ipynb 2014-02-04 15:52:49 -08:00
Brian E. Granger
a3ef3109db Server side logic for directories. 2014-02-04 15:52:49 -08:00
MinRK
eb208b2d77 move signature checking to base NotebookManager
so that subclasses have less to duplicate
2014-01-29 14:37:00 -08:00
MinRK
6dd44de19f Notaries sign notebooks now 2014-01-28 18:44:49 -08:00
MinRK
ffb3523d05 use configured scheme, not stored scheme when checking signatures
protects against notebook author choosing bad hash scheme.
2014-01-28 18:44:49 -08:00
MinRK
6a1e7fe685 add nbformat.sign.NotebookNotary 2014-01-28 18:44:49 -08:00
MinRK
f14f856edb sign notebooks 2014-01-28 18:44:48 -08:00
Thomas Kluyver
57642b3847 Move notebook URL fragment regexen into IPython.html.base.handlers 2013-12-19 13:01:00 -08:00
Thomas Kluyver
7655ce579e Add HTTP handlers for nbconvert 2013-12-13 14:46:50 -08:00
MinRK
b82b4997e7 test that rename fails with 409 if it would clobber
(test already passes, but it should still be tested)

closes #4600
2013-11-25 23:20:23 -08:00
Thomas Kluyver
79c27df217 Specify encoding in remainining instances of io.open 2013-11-20 10:50:04 -08:00
Thomas Kluyver
3fb55970be Miscellaneous docs fixes 2013-11-14 11:21:32 -08:00
Thomas Kluyver
b829043a60 Add test for saving notebook with .py script 2013-11-05 17:43:36 -08:00
Thomas Kluyver
8ed3a725f3 Pass nbformat object to write call to save .py script
Closes gh-4495
2013-11-05 17:35:36 -08:00
Thomas Kluyver
557fb3f4ae Python 3 compatibility for os.getcwdu() 2013-10-31 12:37:45 -07:00
Thomas Kluyver
d4532983f4 Convert print statements to print function calls
libmodernize.fixes.fix_print
2013-10-29 09:14:15 -07:00
MinRK
6bc2c65c83 notebooks should always have one checkpoint
closes #4396
2013-10-23 10:37:49 -07:00
MinRK
3a4d719033 fix checkpoint filename 2013-10-23 10:37:08 -07:00
MinRK
40cce4d7e3 s/os.path.sep/os.sep/ 2013-10-22 17:36:34 -07:00
MinRK
dfb538d881 Windows testing fixes 2013-10-22 17:16:31 -07:00
MinRK
1f90f4d7bb test /files/ gives 403 on hidden files 2013-10-22 15:23:46 -07:00
MinRK
24174f31d9 use itertools.count for incrementing notebook filename 2013-10-20 14:09:01 -07:00
MinRK
cc08837111 fix created timestamp in notebook model 2013-10-20 14:08:47 -07:00
MinRK
f894dbe664 test upload of v2 notebooks 2013-10-18 19:30:52 -07:00
MinRK
cf0218e2d1 don't use jsonapi in test_notebook_api 2013-10-18 16:35:52 -07:00
MinRK
66ccce69c6 copy_from in json, not in url param 2013-10-18 16:35:03 -07:00
MinRK
ef0d065712 test nbmanager.copy_notebook 2013-10-18 16:13:54 -07:00
MinRK
7ea311ad64 escape URLs in Location headers 2013-10-18 16:13:53 -07:00
MinRK
06d9b99141 update notebook api tests
with creation URL changes

also use unicode as the default name in tests,
to increase likelihood of catching unicode bugs.
2013-10-18 16:13:53 -07:00
MinRK
f11caf25e7 update notebook creation handlers
- only POST to directories (notebook picks name)
- only PUT to full paths
- PUT and POST should be equivalent aside from
  who picks the notebook name.
2013-10-18 16:13:53 -07:00
MinRK
60d12e4209 allow specifying destination in copy_notebook 2013-10-17 19:39:06 -07:00
MinRK
d1a36fe4c0 use 'id' for checkpoint ID key
rather than redundant checkpoint.checkpoint_id
2013-10-17 14:55:00 -07:00
Brian E. Granger
51fc769edd Handle notebook downloads through the /files URL. 2013-10-17 14:09:20 -07:00
Brian E. Granger
59901ce88c Adding docstring to NotebookHandler.get. 2013-10-17 14:09:19 -07:00
Thomas Kluyver
6017f5d0ef Specify encoding for loading and saving notebooks. 2013-10-17 14:09:19 -07:00
Thomas Kluyver
05e85588cf Add some unicode testing for saving notebooks 2013-10-17 14:09:19 -07:00
Thomas Kluyver
cbc141c95c Fixes for notebook checkpoint APIs 2013-10-17 14:09:19 -07:00
Thomas Kluyver
3f46a05a14 Test notebook checkpoint APIs 2013-10-17 14:09:19 -07:00