Commit Graph

1983 Commits

Author SHA1 Message Date
Pankaj Pandey
195ca091c5 FileNotebookManager: Use shutil.move() instead of os.rename()
`os.rename()` fails in case the new path is on a different
filesystem. For example if a file in `/tmp` is tried to save
to home, it causes following error:

[Errno 18] Invalid cross-device link using os.rename
2014-04-07 21:07:55 +05:30
Renaud Richardet
13c6303010 do not shutdown notebook if 'n' is part of answer
this prevents commands like 'yesn' to shut down the notebook server
2014-04-07 11:17:11 +02:00
MinRK
6d2774f0af cleanup some pre css inheritance
We had various overrides of the bootstrap defaults for font-size and line-height every time we made a pre tag,
and then some overrides of our overrides when we wanted something slightly different.

This moves the most basic overrides to apply to all pre tags,
reducing the number of downstream changes we need.
2014-04-05 13:27:29 -07:00
Jonathan Frederic
1cac0e3fca Make SVGs resizable in the NB 2014-04-04 12:00:55 -07:00
Jonathan Frederic
46602a00a0 Merge pull request #5493 from jdavidheiser/master
made a minor fix to one of the widget examples
2014-04-04 09:11:23 -07:00
jdavidheiser
e0a40d54cb Update widget_selection.py 2014-04-03 18:45:25 -07:00
jdavidheiser
52e58dce6d Update widget_selection.py 2014-04-03 18:31:30 -07:00
jon
2c1f9790db Don't send \r characters in zmqshell clear_ourput 2014-04-03 16:38:00 -07:00
jdavidheiser
9810033988 widget_selection update
Fix for the fact that dictionary randomization sometimes switches the order of the arguments passed to the class on initialization.  This means that, potentially, 'value' can be updated BEFORE 'values', and since the method to update 'value' checks to see whether it exists in 'values', this breaks things.
2014-04-03 16:26:43 -07:00
Jonathan Frederic
d4d4b2ac73 Cleanup 2014-04-03 12:19:17 -07:00
Jonathan Frederic
ccdb1b2d25 Make sure to not call old load events 2014-04-03 12:19:16 -07:00
Jonathan Frederic
7cc8211c6d A couple of fixes,
- Fix missing `type` from png/jpeg check
- Don't resize on weird chr(13) stand alone stream msgs
2014-04-03 12:19:16 -07:00
jon
955c419f24 Try removing the callbacks 2014-04-03 12:19:15 -07:00
jon
eebae30bd1 Use .load() to resize 2014-04-03 12:19:15 -07:00
jon
45d69b5f25 Move append_output animation height lock release into timeout. 2014-04-03 12:19:15 -07:00
Thomas Kluyver
a90ee73a80 Update tooltips to refer to shift-tab
Closes gh-5510
2014-04-03 09:39:20 -07:00
MinRK
17bbc2b360 back to dev 2014-04-01 23:03:38 -07:00
MinRK
d482fb15b6 release 2.0.0 2014-04-01 22:19:46 -07:00
MinRK
c02562e40f remove weird unicode space in the new copyright header
The bytes were actually:

    #\xe2\x80\x82Copyright...
2014-04-01 21:26:27 -07:00
Brian E. Granger
655098b3c2 Pointing to the 2.x branch in the Help menu. 2014-04-01 15:42:09 -07:00
Brian E. Granger
d5c913c4c2 Removing Editor Shortcuts - these are now in the Shortcut Modal. 2014-03-31 17:06:08 -07:00
Brian E. Granger
b91394cb7d Fixing Help menu links. 2014-03-31 17:06:08 -07:00
Min RK
3f3f3c136e Merge pull request #5436 from ivanov/cm-shorcuts-quickhelp
CodeMirror shortcuts in QuickHelp
2014-03-31 14:36:50 -07:00
Min RK
19ff0c03e1 Merge pull request #5444 from jdfreder/numparse
Fix numeric verification for Int and Float text widgets.
2014-03-31 14:35:00 -07:00
Min RK
e37bf2257d Merge pull request #5449 from minrk/quickhelp-stretch
Stretch keyboard shortcut dialog
2014-03-31 14:34:18 -07:00
Dale Jung
27a77dedbd API: Allow NotebookManagers to control kernel startup dir. #5468 2014-03-29 17:39:15 -04:00
Paul Ivanov
7880ad88b1 ok, removed last few unnecessary shortcuts 2014-03-28 17:20:22 -07:00
Paul Ivanov
7d4aed19e8 remove cm_keyboard.rst and OS-level shortcuts 2014-03-28 17:01:32 -07:00
MinRK
78bc36ec38 update link
The page is in the sphinx docs, not on the main website.
2014-03-28 14:41:10 -07:00
Paul Ivanov
c37e10feb2 move hyphen to cmd_ctrl 2014-03-28 12:58:25 -07:00
Thomas Kluyver
b878696a95 Fix starting notebook server with file/directory at command line.
The base class implementation of parse_command_line uses update_config,
which ensures that the change event fires for the config traitlet. This
copies that.

Closes gh-5460
2014-03-28 11:51:21 -07:00
Paul Ivanov
c24ca22955 lower-cased single letter keys in shortcuts 2014-03-27 17:20:06 -07:00
Paul Ivanov
354ff54aa5 remove no-op placeholder edit mode "shortcuts" 2014-03-27 17:05:09 -07:00
Paul Ivanov
40ca1218c7 completed both sets of platform-specific shortcuts 2014-03-27 16:48:01 -07:00
Paul Ivanov
1102095830 Hi, I'm a Mac. And I'm a PC. 2014-03-27 15:24:43 -07:00
Thomas Kluyver
982aab67ba Merge pull request #5290 from jdfreder/dual_tests
Add dual mode JS tests
2014-03-27 15:03:14 -07:00
MinRK
bfb3d8ec30 check that a handler is actually registered in ShortcutManager.handles
there are a few shortcuts that do not specify handlers
(just for quick help contents),
and this was preventing the actual events from ever firing.
2014-03-27 14:31:07 -07:00
MinRK
8a44e91c0c use modal_stretch on keyboard shortcut dialog 2014-03-27 13:32:42 -07:00
MinRK
b3b200abcb add modal_stretch class
for stretching a dialog to fill the screen
2014-03-27 13:32:18 -07:00
MinRK
4d955e9641 remove unneeded width: 100% firefox workaround
this is no longer needed with `display: flex`
2014-03-27 13:31:02 -07:00
jon
79f6ea9b1f Allow '.', '+.', '+', '-.', and '-' even though without numbers, they cannot be parsed. 2014-03-27 10:29:02 -07:00
Aaron Meurer
75d4947e81 Point to the stable SymPy docs, not the dev docs 2014-03-26 18:07:17 -05:00
MinRK
9552688a71 back to dev 2014-03-25 22:46:06 -07:00
MinRK
2adfb5254c 2.0.0-rc1 2014-03-25 20:16:54 -07:00
Paul Ivanov
f1573bd266 CodeMirror shortcuts in QuickHelp
Our users shouldn't need an internet connection to look at the code
mirror shortcuts. This PR places the CM keyboard shortcuts that are
currently documented on our website's rendered docs, and places them
inside the keyboard shortcuts quickhelp.
2014-03-25 18:19:06 -07:00
MinRK
2daf2fe293 update links in notebook help menu 2014-03-25 17:03:37 -07:00
Paul Ivanov
0240b20127 Merge pull request #5419 from minrk/responsive-prompts
move prompts from margin to main column on small screens
2014-03-25 16:47:26 -07:00
Min RK
a594a691c6 Merge pull request #5430 from jdfreder/elementappend
Make sure `element` is correct in the context of displayed JS
2014-03-25 16:44:34 -07:00
Min RK
34571232bb Merge pull request #5396 from ivanov/fix-5363
prevent saving of partially loaded notebooks
2014-03-25 16:40:24 -07:00
Paul Ivanov
f41750ca6b address PR feedback 2014-03-25 16:31:29 -07:00
Jonathan Frederic
1235c2f638 Make sure element is correct in the context of displayed JS
closes #5293
2014-03-25 15:54:20 -07:00
Jonathan Frederic
b4099518f8 Fix tooltip pager feature
Updates to tooltip.js for msg spec changes.
2014-03-25 15:12:38 -07:00
Min RK
b294bf7059 Merge pull request #5404 from jdfreder/accordion
Fix broken accordion widget
2014-03-24 18:08:17 -07:00
Jonathan Frederic
db2e16f2e1 Added a test 2014-03-24 17:00:43 -07:00
Jonathan Frederic
e1daedf95b Fixed keyboard.js indent break 2014-03-24 15:43:10 -07:00
Jonathan Frederic
e235b47472 Make test name match actually file name 2014-03-24 15:32:38 -07:00
Paul Ivanov
997a9735f0 Merge pull request #5320 from jdfreder/focusbug_tt
Fix for Tooltip & completer click focus bug.
2014-03-24 15:18:45 -07:00
Paul Ivanov
c5054883e9 small fixes for #5320 2014-03-24 15:02:04 -07:00
MinRK
f5ad1cc398 move prompts from margin to main column on small screens
This is mainly for nbviewer, but the relevant CSS lives in IPython.
2014-03-24 11:30:12 -07:00
Jonathan Frederic
aed8b7ba3c Remove commented out lines (for tab evt) 2014-03-21 14:39:43 -07:00
Jonathan Frederic
cbab393e44 Shrink cleanup lines 2014-03-21 13:20:46 -07:00
Jonathan Frederic
b90358888b Fab CSS 2014-03-21 13:20:10 -07:00
Jonathan Frederic
ee7f5b8235 Move width auto into less 2014-03-21 13:19:45 -07:00
Jonathan Frederic
ca422672d6 Re-added new lines at eof 2014-03-21 13:22:46 -07:00
Jonathan Frederic
5c8c8f218c Revert accidental checkin of files from SlimerJS branch 2014-03-21 13:21:07 -07:00
Jonathan Frederic
bca3fdc4b0 Remove commented line 2014-03-21 13:17:00 -07:00
Jonathan Frederic
bf65d5837f Finish implementing codemirror events 2014-03-21 13:15:30 -07:00
Jonathan Frederic
1f002cd456 Add displayed property.
and remove logs, commments, etc...
2014-03-21 12:05:02 -07:00
Jonathan Frederic
607b96b19a Actually remove the trigger keydown method 2014-03-20 18:45:06 -07:00
Jonathan Frederic
a2071db309 More progress... 2014-03-20 18:41:15 -07:00
Jonathan Frederic
b2ec594c76 Getting a lot closer... 2014-03-20 18:01:58 -07:00
Jonathan Frederic
23494f4ddd Set tabindex -1, use codemirror's events 2014-03-20 17:37:53 -07:00
Jonathan Frederic
f2c8de99ae Fix broken accordion widget,
Also clean-up the code some while visiting this file.
2014-03-20 16:52:56 -07:00
Jonathan Frederic
744f057cab get_text() before returning results 2014-03-20 16:22:54 -07:00
Jonathan Frederic
af03114ef6 s/set_cell_text/set_cells_text 2014-03-20 16:15:24 -07:00
Jonathan Frederic
42fa583172 Fix split shortcut 2014-03-20 16:12:42 -07:00
Jonathan Frederic
b80e11d3ce Plus to minus shortcuts rebase fixes 2014-03-20 16:11:02 -07:00
Jonathan Frederic
9c6d904f71 Set cursor pos in edit mode before attempting to jump cells. 2014-03-20 16:11:02 -07:00
Jonathan Frederic
ca71afc5ea Note to self 2014-03-20 16:11:02 -07:00
Jonathan Frederic
1754e3291a Call trigger_keydown in merge_cells_api test 2014-03-20 16:11:01 -07:00
Jonathan Frederic
7c6c0b22b8 Pythonize me captin'
Made the method comments more pythonic by moving them
within the method definitions.
2014-03-20 16:11:01 -07:00
Jonathan Frederic
baa28a0b81 Final fixes? 2014-03-20 16:11:01 -07:00
Jonathan Frederic
ae2b0800cf Partial fix of problems b/c keydown move 2014-03-20 16:11:01 -07:00
Jonathan Frederic
147f35d899 demsemicolons 2014-03-20 16:11:01 -07:00
Jonathan Frederic
a8783c45cb Add comments 2014-03-20 16:11:01 -07:00
Jonathan Frederic
1b46a777fb Removed trigger keydown from keyboard.js,
also added a bunch of missing semicolons (jshint)
2014-03-20 16:11:01 -07:00
Jonathan Frederic
1f4db77aec Cleaned up test names and locations. 2014-03-20 16:11:01 -07:00
Jonathan Frederic
0262b724fc Move validate notebook state into utils 2014-03-20 16:11:01 -07:00
Jonathan Frederic
b9872db82b HUGE speed improvements to dual mode tests 2014-03-20 16:11:01 -07:00
Jonathan Frederic
a7dcdddd54 Fixed problem with split tests,
added new function that sets the codemirror instance cursor coords
2014-03-20 16:11:01 -07:00
Jonathan Frederic
daf40e9ec5 Moved util functions into util.js 2014-03-20 16:11:01 -07:00
Jonathan Frederic
c73bef017d Added split merge tests 2014-03-20 16:11:00 -07:00
Jonathan Frederic
23ca387dd7 cutcopyandpaste 2014-03-20 16:11:00 -07:00
Jonathan Frederic
6efa0a4dae Added get_cell_text 2014-03-20 16:11:00 -07:00
Jonathan Frederic
ddc2161817 Added ctrl+(j&k), a, and b tests 2014-03-20 16:11:00 -07:00
Jonathan Frederic
26e3d14f81 Fixed state type for new markdown cell 2014-03-20 16:11:00 -07:00
Jonathan Frederic
1094299934 Added up/down and markdown tests 2014-03-20 16:11:00 -07:00
Jonathan Frederic
13908b60a4 Fixed typo in dd test 2014-03-20 16:11:00 -07:00
Jonathan Frederic
e647e13162 Add dd tests 2014-03-20 16:11:00 -07:00
Jonathan Frederic
4f6884f985 Add test for cell type modifier keyboard shortcuts 2014-03-20 16:11:00 -07:00
Jonathan Frederic
55773dd95a Made *+enter tests more complicated. 2014-03-20 16:11:00 -07:00
Jonathan Frederic
9bd0ac19bf sep. fucntions to move to util.js 2014-03-20 16:11:00 -07:00
Jonathan Frederic
2b800d3360 Add '_only' to only cell methods 2014-03-20 16:11:00 -07:00
Jonathan Frederic
241b62a37a Move code into is_cell_editor_focused 2014-03-20 16:11:00 -07:00
Jonathan Frederic
86fef90a8c Make a few more methods public,
in preparation to move them into the base utils.js
2014-03-20 16:11:00 -07:00
Jonathan Frederic
c43044d514 s/_is_cell_on/is_cell_on 2014-03-20 16:10:59 -07:00
Jonathan Frederic
6a834223da s/_is_cell_editor_focused/is_cell_editor_focused 2014-03-20 16:10:59 -07:00
Jonathan Frederic
45bbcc949e s/key_press/trigger_keydown 2014-03-20 16:10:59 -07:00
Jonathan Frederic
0f5f3a27f5 Add dual mode JS tests 2014-03-20 16:10:59 -07:00
Jonathan Frederic
dc6355ffb7 Prevent tab key from bubbling when the completer is open 2014-03-20 15:57:26 -07:00
Min RK
0493027d7e Merge pull request #5403 from minrk/alt-shortcut-bad
remove alt-- shortcut
2014-03-20 15:00:41 -07:00
Brian E. Granger
202966ba58 Merge pull request #5389 from minrk/log-files-redirect
better log message in deprecated files/ redirect
2014-03-20 14:52:02 -07:00
Brian E. Granger
c857f9f6fa Merge pull request #5390 from minrk/finish-5333
finish PR #5333
2014-03-20 14:51:27 -07:00
MinRK
3e67d961c9 only check listdir on dirs
is_hidden is called with files, not just dirs
2014-03-20 14:40:39 -07:00
MinRK
c051e870e1 better log message in deprecated files/ redirect 2014-03-20 14:38:44 -07:00
Brian E. Granger
e51030ea5f Merge pull request #5368 from jdfreder/specifity
Flexbox classes specificity fixes
2014-03-20 14:34:17 -07:00
MinRK
2041dc6563 widen modal dialogs on wide displays
needed for quick help layout with multiple meta keys
2014-03-20 14:12:09 -07:00
MinRK
840364ff71 use box-flex to layout quickhelp 2014-03-20 14:11:05 -07:00
MinRK
19c64f4b59 remove alt-- shortcut
replace with ctrl-shift--

alt is not safe for defaults
2014-03-20 14:10:44 -07:00
Brian E. Granger
9f1b26d860 Merge pull request #5331 from minrk/raw-input-css
fix raw_input CSS
2014-03-20 13:47:14 -07:00
Min RK
0ae0216b12 Merge pull request #5049 from ivanov/quickhelp-update
update quickhelp on adding and removing shortcuts
2014-03-20 12:39:42 -07:00
Paul Ivanov
35c861f583 fix MacOS specific shortcuts, thanks @minrk 2014-03-20 12:38:25 -07:00
Brian E. Granger
bfdbdd456c Merge pull request #5391 from jdfreder/netscape-keyboard
Fix Gecko (Netscape) keyboard handling
2014-03-20 12:35:52 -07:00
Paul Ivanov
c28096f0c5 prevent saving of partially loaded notebooks
closes #5363
2014-03-20 02:21:38 -07:00
Paul Ivanov
54d9eb4358 really fix the '-' key shortcuts now 2014-03-19 22:29:31 -07:00
Paul Ivanov
77bf4a72dd better handling of minus 2014-03-19 19:24:05 -07:00
Jonathan Frederic
a08fbff5d9 Fix Gecko (Netscape) keyboard handling 2014-03-19 16:36:11 -07:00
Paul Ivanov
21ebaf2e32 handle keyboard shortcuts ending with '-' 2014-03-19 16:24:53 -07:00
Paul Ivanov
4cf1717980 use - for shortcut separators 2014-03-19 15:58:59 -07:00
Thomas Kluyver
8e1146c6d1 Merge pull request #5357 from minrk/smb-fails
catch exception in copystat
2014-03-19 15:13:14 -07:00
Paul Ivanov
083f631cde wider style for keyboard shortcuts 2014-03-19 12:44:12 -07:00
MinRK
62061f0294 only catch errors in copystat 2014-03-19 12:22:33 -07:00
Min RK
d88b2ccc4a Merge pull request #5310 from ivanov/fix-5238
remove raw cell placeholder on focus, closes #5238
2014-03-19 12:21:03 -07:00
Min RK
5c5139b65d Merge pull request #5332 from ivanov/semantic-icons
semantic names for indicator icons
2014-03-19 12:20:07 -07:00
Paul Ivanov
c54ced12e5 Merge pull request #5360 from minrk/monospace
remove some redundant font-family: monospace
2014-03-19 11:25:12 -07:00
Paul Ivanov
2e4036fd4f raw cell placeholder text as one line 2014-03-19 10:42:11 -07:00
Paul Ivanov
37852baa6d render on focus out, always pad raw cells 2014-03-19 10:37:59 -07:00
Paul Ivanov
8a623dbcc4 fab css 2014-03-18 12:06:06 -07:00
Paul Ivanov
955d239d07 rename css class names to be consistent with current style 2014-03-18 12:03:43 -07:00
Paul Ivanov
a0a17fa04a capitalize keyboard shortcuts in the tour 2014-03-18 11:19:44 -07:00
Paul Ivanov
00603a11f6 remove stale modal dialog from the DOM 2014-03-18 11:16:56 -07:00
Fernando Perez
5f086fded2 Merge pull request #5372 from minrk/no-close-strings
Don't autoclose strings, because CodeMirror's behavior makes it confusing and awkward to type triple-quoted strings (and these are very common in Python).

An issue about this was filed in CodeMirror itself: https://github.com/marijnh/CodeMirror/issues/2385
2014-03-18 11:14:24 -07:00
MinRK
3c1fe84f52 Don't autoclose strings
CodeMirror doesn't do the right thing with triple-quoted strings,
so don't let it try.
2014-03-18 11:11:28 -07:00
Paul Ivanov
597a5cb741 don't color code in crimson
do alliterate, aforementioned color alternative alias is amaranth
2014-03-18 11:03:09 -07:00
Paul Ivanov
b9ef37ac26 semicolon fixes buttress half of my js commits 2014-03-18 10:31:51 -07:00
Min RK
e64c2cb5d8 Merge pull request #5296 from ivanov/more-shortcuts
unify keyboard shortcut and codemirror interaction
2014-03-18 09:46:07 -07:00
Paul Ivanov
0c366861c5 brief key event desription 2014-03-17 21:09:51 -07:00
Paul Ivanov
6d6e0fb007 fix up and down arrows in the top and bottom cells 2014-03-17 20:11:33 -07:00
Paul Ivanov
09866e0ee1 go to the beginning of the line when entering cell 2014-03-17 17:41:44 -07:00
Paul Ivanov
96848748de restore master behavior
up arrow at the top line first goes to char 0, and only goes to the cell
above if already on char 0. Same with down arrow on the bottom line:
transition cursor to the end of the line, and only go down a cell if
already at the end of the last line.

this makes for an unhappy experience in code-mirror's vim mode  for j
and k keys, but we'll fix that in the next commit
2014-03-17 16:21:23 -07:00
Paul Ivanov
8f17444c27 go to appropriate line when coming from another cell
Sets the cursor on the last line of the cell when moved up from the top
of the cell below, and sets the cursors to the first line when moving
down from the bottom of a last line.

Here, we retain the character that the cursor was on, so that users
wishing to have up-down functionality like one document can still use
this shortcut handler and simple adjust the at_top and at_bottom methods
2014-03-17 15:48:36 -07:00
Jonathan Frederic
2dd8757da7 Fab CSS 2014-03-17 10:44:29 -07:00
Jonathan Frederic
77904a044c Re-added already existing base for less backwards compatability. 2014-03-17 10:43:53 -07:00
Jonathan Frederic
0020b9f896 Fix specifity of flex modifier classes 2014-03-17 10:40:28 -07:00
MinRK
8e5937e993 remove some redundant font-family: monospace
`pre`, `code` tags already set the font-family in these contexts.
Setting it again in the surrounding context is redundant,
and causes inconsistency when embedding notebooks in HTML
(e.g. nbviewer).
2014-03-14 11:43:11 -07:00
Jonathan Frederic
d37ffe91b7 Fix status ind. icon bug 2014-03-14 11:40:54 -07:00
MinRK
caee63f413 fallback on copy, copyfile if copy2 fails
in notebook manager
2014-03-14 10:06:02 -07:00
MinRK
89faa5f340 simplify raw_input css
for once, vertical-align: baseline is the right choice
2014-03-13 20:47:34 -07:00
MinRK
065a6eaa34 fix ambiguous raw_input classes 2014-03-13 20:45:54 -07:00
Paul Ivanov
61b47695e4 renamed 'use_shortcut' method to 'handles' 2014-03-13 16:44:19 -07:00
Paul Ivanov
d8287466d0 another doc fix 2014-03-13 16:40:37 -07:00
Paul Ivanov
f68dcc3e57 it's only half true that I'm anal about semicolons 2014-03-13 16:30:58 -07:00
Paul Ivanov
67fd905421 minor fixes to docs to address PR feedback 2014-03-13 16:29:28 -07:00
Paul Ivanov
469c70fd10 more semicolons 2014-03-13 16:23:27 -07:00
Jonathan Frederic
443083c1fd Added some comments 2014-03-13 14:34:17 -07:00
Paul Ivanov
1dc113a9cb closes #5336 2014-03-13 14:30:32 -07:00
cgohlke
74be15ec19 Fix filenbmanager.list_dirs fails for Windows user profile directory 2014-03-11 23:50:46 -07:00
Paul Ivanov
4142911ac7 better fix for starting with Command Mode icon 2014-03-11 18:58:46 -07:00
Paul Ivanov
12139b4d6e ensure ipython-command-mode icon displayed on load 2014-03-11 18:48:21 -07:00
Paul Ivanov
f0ae836f5f semantic names for kernel status indicator 2014-03-11 18:37:35 -07:00
Paul Ivanov
f5a02a02dd semantic names for indicator icons
For all of the discussion that we had about what kind of icons should
and should not be used to indicate what mode the notebook is in, we
never went through to make it possible to override it.

With this change, it is now possible to override what icons are
displayed for Command and Edit Modes.

For example, @minrk liked the fighter-jet icon for Command Mode, so he
can put this in his custom.css

.ipython-command-mode:before {
     content: "\f0fb";
}
2014-03-11 18:22:03 -07:00
MinRK
084aba793f fix raw_input CSS
I had to express padding in px, not em for consistent appearance.
I'm not sure why.
2014-03-11 14:45:37 -07:00
Paul Ivanov
4dd009f198 DRY: style in one place, removed code duplication 2014-03-11 00:53:15 -07:00
Jonathan Frederic
7762cb0ab3 Fixed a small bug/typo 2014-03-10 15:29:10 -07:00
Jonathan Frederic
e61b6aef47 Add logic to close tt when cell is unselected 2014-03-10 15:26:04 -07:00
MinRK
f9758dd453 add NotebookNotary to NotebookApp's class list
adds it to help output and config files
2014-03-10 15:21:11 -07:00
Brian E. Granger
3eb654bd86 Merge pull request #5295 from minrk/no-append-prototype
OutputArea.append_type functions are not prototype methods
2014-03-10 14:13:14 -07:00
Paul Ivanov
b08665563d fix capitalization of mode-switching keys 2014-03-10 11:48:13 -07:00
MinRK
a24595d16b call append_text from append_map 2014-03-10 11:44:00 -07:00
Paul Ivanov
01c9be84d0 prettify combo keyboard shortcuts 2014-03-10 11:30:50 -07:00
Paul Ivanov
1c213bc615 first pass at capitalizing keyboard shortcuts 2014-03-10 11:13:18 -07:00
Jonathan Frederic
95492b0f42 Add illusion that cell is in edit mode when complete is up,
even though it is not in focus so it is not in edit mode.
2014-03-10 10:10:06 -07:00
Jonathan Frederic
65732920eb Remove all should cancel blur logic. 2014-03-10 09:46:59 -07:00
Jonathan Frederic
989ae4e1b3 Workaround for Tooltip & completer click focus bug. 2014-03-10 09:28:19 -07:00
MinRK
abe2dce926 back to dev 2014-03-09 21:58:09 -07:00
Paul Ivanov
1c23dee141 remove recreation of QuickHelp 2014-03-09 14:21:14 -07:00
Paul Ivanov
8bf4ffa2ca rebuild.QuickHelp event sets the dirty bit
QuickHelp is rebuilt on show if the dirty bit was set.
2014-03-09 14:15:47 -07:00
Paul Ivanov
cdb7967cc2 removing keyboard shortcuts should also update help 2014-03-09 12:26:34 -07:00
Paul Ivanov
4a287569fc update notebook quickhelp on new shortcuts 2014-03-09 12:24:32 -07:00
Paul Ivanov
cd38181438 remove raw cell placeholder on focus, closes #5238 2014-03-09 11:41:25 -07:00
MinRK
4d1f9b21c4 append functions are not prototype methods 2014-03-07 17:57:37 -08:00
Paul Ivanov
54409a196d dem semicolons 2014-03-07 17:48:34 -08:00
Paul Ivanov
19c7189b15 no need to special-case Escape anymore 2014-03-07 17:48:34 -08:00
Paul Ivanov
6a2c4121f9 up and down keys no longer need special casing 2014-03-07 17:48:34 -08:00
Paul Ivanov
2c9ff376a2 added new use_shortcut method to shortcuts
this way, you can ask if a particular event will be handled by the
shortcuts system. This takes away the need to special-case many
different possible keys which should be ignored by codemirror by
ignoring them en masse.
2014-03-07 17:48:34 -08:00
Paul Ivanov
b9e448b160 DRY: refactor common keyboard handling to Cell
Our edit mode keyboard shortcuts don't distinguish between being in a
code cell or in a text cell, so it makes sense to handle both in one
place. This is a first step in that direction.
2014-03-07 17:48:34 -08:00
Paul Ivanov
15f4345ba3 typo, use keycodes object instead of magic numbers 2014-03-07 17:48:34 -08:00
Paul Ivanov
bf3ecdb35f DRY: factor out common handle_keyevent method
This method was identical in both CodeCell and TextCell
2014-03-07 17:48:34 -08:00
Paul Ivanov
71d4c427c9 refactor to improve cell switching in edit mode
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.

TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell

prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.

The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
2014-03-07 17:48:34 -08:00
Paul Ivanov
8889a7581c start better keyboard handling 2014-03-07 17:48:34 -08:00