mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-12-27 04:20:22 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,867 Commits 19 Branches 1,023 Tags 78 MiB
a7fb5e1e55
Commit Graph

3148 Commits

Author SHA1 Message Date
Min RK
003c5e8eda Merge pull request #4971 from ellisonbg/testjs-fd 
Fixing issues with js tests
 2014-01-31 20:38:32 -08:00
Brian E. Granger
82a4538759 Notebook.delete should take no args. 2014-01-31 18:13:01 -08:00
MinRK
1b74ee0c3e note v4.1 msg spec change in clear_output handler 2014-01-31 16:54:30 -08:00
Paul Ivanov
836fd887dc make paste focuses the pasted cell 
This is to make paste behave in the same manner that insert cell above
and below currently work (inserting a new item causes that item to
receive focus).

This solves a problem where, if a user pastes below a cell whose bottom
edge is below the current viewing area, they have no indication that any
action has occurred. The same applies for paste above a cell whose top
edge is occluded.
 2014-01-31 12:03:30 -08:00
Jonathan Frederic
a2044fd463 Remove sleep from the following, 
Button, float, int, multicontainer, selection widgets.
 2014-01-31 11:48:51 -08:00
Brian E. Granger
aa71651468 Fixing issues with js tests. 
* Closing old pages to prevent fd leaks.
* Making sure kernels are killed to prevent fd leaks.
* Moving towards deleting old notebooks (this is not done, but
  this should be merged as is).
 2014-01-31 10:42:23 -08:00
Min RK
747c9ca29c Merge pull request #4845 from rgbkrk/origin_host 
Add Origin checking for websockets.
 2014-01-31 10:34:32 -08:00
Min RK
7f9ee9cba7 Merge pull request #4916 from ellisonbg/modalbehavior 
Fine tuning the behavior of the modal UI

swap back shift- and ctrl-enter, to their rightful places.
 2014-01-31 10:32:27 -08:00
MinRK
2477ed0fed update css with font-awesome 3.2.1 2014-01-31 10:25:20 -08:00
MinRK
3535163f67 font-awesome 3.2 moved resources 2014-01-31 10:24:23 -08:00
Kieran O'Mahony
699bfcc709 Fix error message typo on web socket fail 2014-01-31 15:07:43 +11:00
Jonathan Frederic
d68112885b Use waitFor instead of sleeping. 2014-01-30 15:23:58 -08:00
Preston Holmes
547316fec3 Fixed typos in quick-help text 2014-01-30 14:31:30 -08:00
Brian E. Granger
e2c20e0675 Rename _handle_new_view->_handle_display_view. 2014-01-30 13:44:31 -08:00
Brian E. Granger
8445ab1899 Fixing tests from shift and ctrl enter swap. 2014-01-30 12:53:52 -08:00
Brian E. Granger
6298b16a44 Fixing help strings for shift|ctrl+enter. 2014-01-30 10:11:36 -08:00
Brian E. Granger
dbed35c5b1 shift+enter and ctrl+enter swapped. 2014-01-30 10:11:36 -08:00
Brian E. Granger
bcd4209375 alt+enter should always insert below 2014-01-30 10:11:36 -08:00
Brian E. Granger
4c7ce61011 Don't enter edit mode when changing cell type and preserve renderd. 2014-01-30 10:11:35 -08:00
Brian E. Granger
8c046fef99 Only call register_events on top level widget. 2014-01-30 10:11:12 -08:00
Brian E. Granger
36ca1b0baf Dont' force command mode in kbm.register_events. 2014-01-30 10:11:12 -08:00
Brian E. Granger
63ae9e2fd7 Fixing this->that. 2014-01-30 10:11:12 -08:00
Brian E. Granger
5f4d4017c1 Only call CM.focus() if CM is not already focused. 2014-01-30 10:11:11 -08:00
Thomas Kluyver
fa0d5b2f1a Merge pull request #4953 from minrk/wait-for-idle 
add utils.wait_for_idle in js tests
 2014-01-30 09:58:33 -08:00
Min RK
888698e12f Merge pull request #4662 from ellisonbg/menu-cleanup 
Menu cleanup
 2014-01-29 20:23:12 -08:00
MinRK
5142cc775d remove superfluous then 2014-01-29 18:06:50 -08:00
MinRK
a6ece94e32 add utils.wait_for_idle in js tests 
and use it in execute_cell_then, since there is not always output.
 2014-01-29 17:33:06 -08:00
Brian E. Granger
7c722d4b6c Merge pull request #4824 from minrk/sign-notebooks 
sign notebooks
 2014-01-29 16:38:08 -08:00
Min RK
f9744b690e Merge pull request #4943 from takluyver/docs-shotgun-4 
Docs shotgun 4
 2014-01-29 16:21:24 -08:00
Brian E. Granger
d21258bbcc Reset file upload form after an upload. 2014-01-29 15:53:20 -08:00
Brian E. Granger
9fbeaa1e37 Properly set uploaded notebook path. 2014-01-29 15:33:02 -08:00
Thomas Kluyver
c633256fc9 Fix some formatting in widget docstrings 2014-01-29 14:55:12 -08:00
MinRK
eb208b2d77 move signature checking to base NotebookManager 
so that subclasses have less to duplicate
 2014-01-29 14:37:00 -08:00
MinRK
ecfa10b3b3 update shutdown_notebook 
now that get_output_cell raises if there is no such output
 2014-01-29 14:37:00 -08:00
MinRK
5e60741e5c adjustments to nb_roundtrip.js 
A few waits, little changes to get it running with recent changes
 2014-01-29 14:37:00 -08:00
MinRK
d07e03b7c9 add wait_for_output(cell, index) 
so you can wait for at least n outputs
 2014-01-29 14:37:00 -08:00
Jonathan Frederic
6f3ef63ac9 s/Underscore/_ 2014-01-29 12:37:45 -08:00
Jonathan Frederic
865c7330a9 s/model_name/_model_name 2014-01-29 12:37:30 -08:00
Brian E. Granger
ffe92842fc Merge pull request #4853 from minrk/imgmd 
fix setting image height/width from metadata
 2014-01-29 10:56:50 -08:00
Matthias BUSSONNIER
9d54212f17 reorder class properties 2014-01-29 08:13:26 +01:00
Matthias BUSSONNIER
8c57e9e788 Fixme comment + whatsnew 2014-01-29 08:06:19 +01:00
Matthias BUSSONNIER
aa5477beb7 fix Brian and Min comment 2014-01-29 08:06:18 +01:00
Matthias BUSSONNIER
9f2203340a emit event when mimetype are append to output area. 2014-01-29 08:04:35 +01:00
Brian E. Granger
b638b8718c Adding DOM ids for each menu. 2014-01-28 20:30:18 -08:00
Brian E. Granger
ff6d6abb12 Formatting cleanup of renderedhtml.less. 2014-01-28 19:43:14 -08:00
Brian E. Granger
39d20f2a90 H5 and H6 are base font size + italic. 2014-01-28 19:36:03 -08:00
Brian E. Granger
7163a0b397 Using @code_padding variable. 2014-01-28 19:35:15 -08:00
Brian E. Granger
4363aa72f8 More changes to the heading spacing. Good first draft... 2014-01-28 19:35:15 -08:00
Brian E. Granger
483023ca41 More work on the styling of headings. 2014-01-28 19:34:57 -08:00
Brian E. Granger
37f4556eba Initial spacing modifications. 2014-01-28 19:34:39 -08:00
Brian E. Granger
7c65e96941 Simplified Cell menu items related to output. 2014-01-28 19:30:51 -08:00
Brian E. Granger
9538fb7d8f Converting loops in *_all_output to $.map(). 2014-01-28 19:11:31 -08:00
Brian E. Granger
f4bfcadf32 Adding back Kernel menu and Cell Type submenu. 2014-01-28 19:11:31 -08:00
Brian E. Granger
afb114e6d3 Removing unneeded select prev/next from Edit menu. 2014-01-28 19:11:31 -08:00
Brian E. Granger
54666e2e98 Cleaning up output management in code and menus. 2014-01-28 19:11:31 -08:00
Brian E. Granger
5786602300 Add kernel restart button to toolbar. 2014-01-28 19:11:31 -08:00
Brian E. Granger
953da90a98 Removing Kernel menu. 2014-01-28 19:11:31 -08:00
MinRK
3c2ff965ef get_output_cell fails with no such output 
rather than returning null
 2014-01-28 18:44:50 -08:00
MinRK
0e454c7fe0 move ipython notebook trust to ipython trust 
and move App definition to nbformat.sign (maybe it should get its own file).
 2014-01-28 18:44:50 -08:00
MinRK
6dd44de19f Notaries sign notebooks now 2014-01-28 18:44:49 -08:00
MinRK
ffb3523d05 use configured scheme, not stored scheme when checking signatures 
protects against notebook author choosing bad hash scheme.
 2014-01-28 18:44:49 -08:00
MinRK
6eec6fdf6e add ipython notebook trust subcommand 2014-01-28 18:44:49 -08:00
MinRK
6a1e7fe685 add nbformat.sign.NotebookNotary 2014-01-28 18:44:49 -08:00
MinRK
f14f856edb sign notebooks 2014-01-28 18:44:48 -08:00
Brian E. Granger
bc7b51d1b0 Merge pull request #4374 from jdfreder/widget-msg 
IPEP 23: Backbone.js Widgets
 2014-01-28 14:58:00 -08:00
Jonathan Frederic
8312534cac Fixed Accordion test broken by last commit 2014-01-28 12:53:23 -08:00
Jonathan Frederic
75b148d40b Renamed widgets... 
TextWidget, TextareaWidget, CheckboxWidget, and SelectWidget
 2014-01-28 12:51:24 -08:00
Jonathan Frederic
5ed3a0ebc5 Simplify get_msg_cell function of notebook.js 2014-01-28 11:43:53 -08:00
Jonathan Frederic
13694d04c3 Removed blame comment 2014-01-28 11:43:53 -08:00
Brian E. Granger
5137961bf2 Protect against navigator undefined in platform. 2014-01-28 10:19:44 -08:00
Brian E. Granger
fd07bb54b6 Fixing shortcut counts to work for n>2. 2014-01-28 10:17:34 -08:00
Brian E. Granger
0af185787a Added platform dep. logic. 2014-01-27 16:27:25 -08:00
MinRK
63eb905a02 try assertType instead of NotEquals, null 2014-01-27 15:06:36 -08:00
Brian E. Granger
1af4bfb3ce Misc work on shortcuts: 
* shift+v for paste above.
* ii for interrupt
* 00 for restart
* All shortcuts can have a count field for multiple press.
 2014-01-27 15:00:19 -08:00
MinRK
0d1536c390 use jQuery attr instead of setAttribute 
when appending images.

This was an optimization with no apparent performance benefit.
 2014-01-27 14:46:35 -08:00
MinRK
119052f75d first review pass on widget tests 2014-01-26 17:01:59 -08:00
Min RK
0b70f26f0e Merge pull request #4655 from minrk/marked-nbconvert 
prefer marked to pandoc for markdown2html
 2014-01-26 15:58:11 -08:00
MinRK
36db60eacb review pass on Python-side of widgets 
- remove variable signature complexity
- use a few more traitlets as appropriate
 2014-01-26 15:46:06 -08:00
MinRK
dd2f4a25aa quick review pass on javascript 2014-01-26 15:02:29 -08:00
MinRK
001e06103b review pass on widgetmanager.js 2014-01-26 14:38:02 -08:00
MinRK
e6f84111cd treat all falsy values the same in tooltip 
undefined, null, and empty string are all treated the same.
 2014-01-25 17:32:50 -08:00
MinRK
a7bd321648 don't show tooltip if object is not found 
closes #4875
 2014-01-25 17:24:14 -08:00
Jonathan Frederic
134413c89c Fixed bug that prevented popup widget from displaying 2014-01-24 16:36:23 -08:00
Jonathan Frederic
c807dd29e4 Prevent TextBox from blurring unless explicity by user. 2014-01-24 13:35:58 -08:00
Jonathan Frederic
3026ddb52b Fixed bug in throttling code. 2014-01-24 12:32:19 -08:00
Min RK
64421304c0 Merge pull request #4826 from Carreau/no-html 
some $.html( -> $.text(
 2014-01-24 12:25:34 -08:00
Min RK
b5a85af6e5 Merge pull request #4847 from Carreau/js-kernel-info 
add js kernel_info request
 2014-01-24 12:20:12 -08:00
Matthias BUSSONNIER
e99756c6d5 mv kerneljs_test to kernel_test 2014-01-24 20:52:06 +01:00
Jonathan Frederic
7c32616556 Moved keyboard_manager logic into a sep. function. 2014-01-24 10:39:06 -08:00
Kyle Kelley
ddc9340a6a Handle variations of name for origin 2014-01-24 00:19:59 -06:00
MinRK
2cbb633cb4 test displaying images with shape metadata 2014-01-23 15:38:19 -08:00
MinRK
f02b5bef21 fix setting image height/width from metadata 2014-01-23 15:38:13 -08:00
Jonathan Frederic
dc9f81e75d Fixed bug in selection widget tests. 2014-01-23 10:58:52 -08:00
Matthias BUSSONNIER
25e68b3a75 typo 2014-01-23 19:58:09 +01:00
Jonathan Frederic
e793d022b5 Callback dispatcher return callback value. 
Also import it with the widgets namespace so it can be used elsewhere.
 2014-01-23 10:52:33 -08:00
Matthias BUSSONNIER
03a2cb6535 fix js formatting 2014-01-23 19:31:35 +01:00
Matthias BUSSONNIER
4ecf5c8e5b add kernel test 2014-01-23 19:08:56 +01:00
MinRK
848010e911 fix tooltip token regex for single-character names 
closes #4808
 2014-01-23 09:51:46 -08:00
Jonathan Frederic
00b39af9cf Fixed type in container 
._children was not being set...  Instead the value was being returned (useless).
 2014-01-23 09:12:05 -08:00
Matthias BUSSONNIER
f5fa732bd3 avoid injection in input prompt 2014-01-23 14:17:14 +01:00
Kyle Kelley
e06f501cd6 s/==/is/ 2014-01-22 21:12:08 -06:00
Jonathan Frederic
91e82218a8 Changed selection widget API to use labels list 
for mapping custom str reprs to items in the selection list
 2014-01-22 17:15:10 -08:00
Jonathan Frederic
7f12f35fea Added code that removes the views when a model/widget is closed. 2014-01-22 16:28:17 -08:00
Kyle Kelley
7efc751d0e Name change to same_origin 2014-01-22 18:26:15 -06:00
Kyle Kelley
60ab030e52 Verify that headers are set, explicitly 2014-01-22 18:21:02 -06:00
Jonathan Frederic
288b8a0ced s/view_name/_view_name 2014-01-22 16:21:00 -08:00
Kyle Kelley
b12f002b35 Performing check only on open. 2014-01-22 18:16:06 -06:00
Jonathan Frederic
2d13d05e9c Replace O(N^2) algorithm with a faster one. 2014-01-22 16:14:20 -08:00
Jonathan Frederic
9e643f5692 Support multiple types in selection widget. 2014-01-22 15:53:58 -08:00
Jonathan Frederic
c9973a7114 Float widget views now inherit from int counterparts 2014-01-22 15:00:36 -08:00
Paul Ivanov
9b7c8b0473 make the JS test fail 2014-01-22 14:45:20 -08:00
Jonathan Frederic
2bb9ba9a9c Adjusted throttling 2014-01-22 12:53:59 -08:00
Jonathan Frederic
9560b29beb Removed float widget bound tests, 
once the int widget inherits from the float, or vise-versa, the tests
will be covered by the int
 2014-01-22 12:12:08 -08:00
Jonathan Frederic
1b8b6b3a88 Fixed bug where views child to other views would not have cell information 2014-01-22 12:04:53 -08:00
Jonathan Frederic
f06a0a7d5e Fixed a couple more context typos 2014-01-22 11:31:01 -08:00
Jonathan Frederic
629d65da89 Fixed context errors and a couple of typos to get the tests working again 2014-01-22 11:16:50 -08:00
Matthias BUSSONNIER
98101f9c6c add js kernel_info request 2014-01-22 09:01:13 +01:00
Matthias BUSSONNIER
cbe162297f XSS casper test 2014-01-22 08:34:47 +01:00
Kyle Kelley
345de4e674 Use *args, **kwargs, log.warn 2014-01-21 21:08:24 -06:00
Jonathan Frederic
99f3f5155e Fixed some typos related to _.each loops 2014-01-21 17:23:12 -08:00
Jonathan Frederic
d7b86104b8 Fixed typo - else -> elif 2014-01-21 17:14:34 -08:00
Jonathan Frederic
046280b51a s/ModalView/PopupView 2014-01-21 17:09:49 -08:00
Jonathan Frederic
7ce9f37b17 Made tests reflect changes to widget naming scheme. 2014-01-21 16:52:37 -08:00
Jonathan Frederic
10bd54bd30 Move js *RangeWidget code into *Widget 2014-01-21 16:49:35 -08:00
Jonathan Frederic
e323f64e6d Create base widget classes 2014-01-21 16:44:57 -08:00
Jonathan Frederic
b432b4840f Use CUnicode for width and height in ImageWidget 2014-01-21 16:33:49 -08:00
Jonathan Frederic
c5e48c0b75 Added some small comments to widget code 2014-01-21 16:32:18 -08:00
Jonathan Frederic
80c3339791 - remove second line in create_child_view 
- add undefined check in delete_child_view
 2014-01-21 16:29:59 -08:00
Jonathan Frederic
58f56a5dd7 Explicitly return null if there aren't any results 2014-01-21 16:28:26 -08:00
Jonathan Frederic
08e40697de Removed for () loops where necessary. Replaced with _.each 2014-01-21 16:26:03 -08:00
Jonathan Frederic
35a02a0436 Replace .html with .text everywhere possible 2014-01-21 15:38:37 -08:00
Jonathan Frederic
af4809bec4 Prefer JQuery to Underscore 2014-01-21 15:24:47 -08:00
Jonathan Frederic
d9a703d305 'create' should be handled in sync 2014-01-21 15:22:26 -08:00
Jonathan Frederic
2b27b4101b Remove todo in apply update 2014-01-21 15:21:44 -08:00
Jonathan Frederic
e823d386ab Fixed name conflict with _property_lock 2014-01-21 15:18:49 -08:00
Jonathan Frederic
077bd5c6ca Added new CallbackDispatcher class 2014-01-21 15:14:27 -08:00
Jonathan Frederic
611614b6eb Document in widget packing that vaues must be JSON-able. 2014-01-21 14:25:08 -08:00
Jonathan Frederic
cf05ef015a ict comprehension and list comprehension in pack/unpack widgets 2014-01-21 14:23:44 -08:00
Jonathan Frederic
cb6094281c s/custom_content/content 2014-01-21 14:17:57 -08:00
Jonathan Frederic
5fe860ed26 Added doc strings to properties in widget.py 2014-01-21 14:16:24 -08:00
Jonathan Frederic
1689eed2f6 Reorganized attrs in widget.py 2014-01-21 14:13:33 -08:00
Kyle Kelley
104275ab73 Indicate Py3 vs. Py2 codepath. 2014-01-21 14:47:58 -06:00
Jonathan Frederic
097951a6b8 Remove residual tabs 2014-01-21 12:35:39 -08:00
Kyle Kelley
5800b1c625 Get rid of exc_info as there isn't an exception. 2014-01-21 13:23:09 -06:00
Kyle Kelley
7b552d862d Add Origin Checking. 2014-01-21 12:55:52 -06:00
MinRK
c2cb64c9a0 adjustments to notebook app logging 
Mainly add a log_request function (from nbviewer) for formatting tornado access logs.

Relevant effects:

- demote successful access logs to DEBUG
- demote kernel connect messages to DEBUG

which reduces the noise at INFO-level (default)
 2014-01-21 10:48:24 -08:00
Jonathan Frederic
b7cd129c37 Added a line that was accidently deleted during merge of 4e813c5 2014-01-21 11:05:32 +00:00
Jonathan Frederic
691cd56038 Change the callback logic so the order makes more sense: 
*Now*
View calls Model which calls Widget Manager
*instead of *
View calls Widget Manager, which then the Model modifies right
before sync
 2014-01-21 11:00:45 +00:00
Jason Grout
fe6edb26a6 Rewrite widget syncing 
Conflicts:
	IPython/html/static/notebook/js/widgetmanager.js
	IPython/html/static/notebook/js/widgets/widget.js
 2014-01-21 10:13:42 -08:00
Matthias BUSSONNIER
149867e74c some $.html( -> $.text( 
Thoses that are obvious and easy to fix.

we shoudl have I think a travis test that grep for .html( and return
less than 20 lines :-)
 2014-01-17 22:25:33 -08:00
Jonathan Frederic
e17200a533 Widget require.js fix 
The WidgetManager namespace is passed around instead of a
widget_manager instance...
 2014-01-17 17:03:29 +00:00
Jonathan Frederic
c39050e642 Fixed widget_manager instance test. 2014-01-17 16:32:58 +00:00
Jonathan Frederic
469c865603 Added support for multiple kernels. 2014-01-17 16:22:57 +00:00
Jonathan Frederic
6871c8f9e0 Cherry pick of @jasongrout 's 2bc2f96. 
Only merged changes to notebook and kernel...  (see original comment below).

Separate the widget registry from the widget managers;
attach widget managers to kernels.

Yet to do: take care of clean-up when a kernel is deleted
Conflicts:
	IPython/html/static/notebook/js/widgetmanager.js
	IPython/html/static/notebook/js/widgets/widget.js
 2014-01-17 15:36:49 +00:00
Jason Grout
140d1872f7 Delete unnecessary save 2014-01-17 15:21:30 +00:00
Jason Grout
ce19a34d93 Pass the whole message into the widget manager display_view call 
We do this so implementations can see metadata and any other things in the message, if they want.
Conflicts:
	IPython/html/static/notebook/js/widgetmanager.js
 2014-01-17 15:21:06 +00:00
Jason Grout
092e40df32 make the saving to python a method of the model, called with callbacks 
Conflicts:
	IPython/html/static/notebook/js/widgets/widget.js
 2014-01-17 15:10:17 +00:00
Jason Grout
24ec0da125 Fix the cell reference in views 
This solution is kludgy, but it does fix what broke when we tried to take the cell references out of views.
Conflicts:
	IPython/html/static/notebook/js/widgets/widget.js
 2014-01-17 15:04:27 +00:00
Jonathan Frederic
7cc6692fc4 Make dropdown view DOM swap elements on update. 2014-01-17 10:37:08 +00:00
Matthias Bussonnier
0ec0534ce9 Merge pull request #4796 from minrk/update-components 
update components

closes #4765
 2014-01-16 09:53:07 -08:00
Jonathan Frederic
82bf9c6826 Fix bug in all children containing views 2014-01-16 17:19:35 +00:00
Jonathan Frederic
d317532a38 Halign dict colons 2014-01-16 17:17:00 +00:00
Jonathan Frederic
bd3ba3328c Added PEP8 style comments to all of the JS code. 2014-01-16 16:48:14 +00:00
Jonathan Frederic
7387f886c6 containers and selectioncontainers now only allow one of any single child 2014-01-16 14:48:56 +00:00
Jonathan Frederic
bfdebf9632 More PEP8 changes 2014-01-16 14:20:04 +00:00
Jonathan Frederic
bad85fb879 Remove O(N) cell by msg-id lookup 2014-01-16 11:53:22 +00:00
Jonathan Frederic
ff39989b8b s/Int/CInt s/Float/CFloat 2014-01-16 11:42:38 +00:00
Jonathan Frederic
2aeac3a424 Make widget views work with new keyboard manager. 2014-01-16 10:57:19 +00:00
Jonathan Frederic
f86fe40c97 Fix rebase issues 2014-01-16 10:57:19 +00:00
Jonathan Frederic
6286f8b1ea Fab CSS 2014-01-16 10:57:19 +00:00
Jonathan Frederic
74185a68e7 Got containers and mutlicontainers working! Yay 2014-01-16 10:57:19 +00:00
Jonathan Frederic
16d9fa92e8 Fix test for selection widgets 2014-01-16 10:57:19 +00:00
Jonathan Frederic
4017c7b27a Fixed *almost* all of the test-detected bugs 2014-01-16 10:57:19 +00:00
Jonathan Frederic
c085593e2a More fixes 2014-01-16 10:57:18 +00:00
Jonathan Frederic
d694666e66 A lot of bug fixes... 
Related to 1-to-1 changes
 2014-01-16 10:57:18 +00:00
Jonathan Frederic
047a90538f 1-to-1 widget / view mapping 2014-01-16 10:57:18 +00:00
Jonathan Frederic
c1c7bb7563 Everyone uses one model 2014-01-16 10:57:18 +00:00
Jonathan Frederic
b16171ac76 Added sync=True to all view name attrs 2014-01-16 10:57:18 +00:00
Jonathan Frederic
cfe8a07337 Added sync= attr to DOMWidget 2014-01-16 10:57:18 +00:00
Jonathan Frederic
b4a83b6044 sync=True isntead of a keys list 2014-01-16 10:57:18 +00:00
Jonathan Frederic
00650fd64a Dev meeting Jan 2014, widget review day 2 2014-01-16 10:57:18 +00:00
Jonathan Frederic
d3ffd25107 Dev meeting widget review day 1 2014-01-16 10:57:18 +00:00
Paul Ivanov
897d51a567 fix typos 2014-01-16 10:57:17 +00:00
Paul Ivanov
95e99c0c61 remove unused imports 2014-01-16 10:57:17 +00:00
Jonathan Frederic
d103c682c5 Many checks off the todo list, test fixes 2014-01-16 10:57:17 +00:00
Jonathan Frederic
f6de685d9f Use .apply for calling base with not proto-type. 
See codecell for example.
 2014-01-16 10:57:17 +00:00
Jonathan Frederic
0f715170b3 Add a comment that explains the notion of the default element 
to be styled in set_css's' doc string.
 2014-01-16 10:57:17 +00:00
Jonathan Frederic
1e37a46a55 Add a helper method that acts on the changes made to a list. 2014-01-16 10:57:17 +00:00
Jonathan Frederic
be268dcf98 Implement a context manager as a property locking mechanism in Widget. 2014-01-16 10:57:17 +00:00
Jonathan Frederic
70c6a295d0 Finished renaming Multicontainer to SelectionContainer 2014-01-16 10:57:17 +00:00
Jonathan Frederic
a528610e07 renamed: ../static/notebook/js/widgets/widget_multicontainer.js -> ../static/notebook/js/widgets/widget_selectioncontainer.js 
renamed:    widget_multicontainer.py -> widget_selectioncontainer.py
 2014-01-16 10:57:17 +00:00
Jonathan Frederic
643516f6f9 remove .html(''); 2014-01-16 10:57:17 +00:00
Jonathan Frederic
c62b496b0e s/image_format/format 2014-01-16 10:57:17 +00:00
Jonathan Frederic
b5f97c1227 add comment views are in *_range 2014-01-16 10:57:16 +00:00
Jonathan Frederic
5e9a090423 toggle button, set $el to button (removing extra div) 2014-01-16 10:57:16 +00:00
Jonathan Frederic
5b5325507f add locks to update everywhere by using options to pass this 
(and check for this)
 2014-01-16 10:57:16 +00:00
Jonathan Frederic
c4edfdc828 comment model.set, so we know that it triggers update on other views 2014-01-16 10:57:16 +00:00
Jonathan Frederic
ccbfcbc159 make JS update comment more descriptive (english) 2014-01-16 10:57:16 +00:00
Jonathan Frederic
0740980d5c remove length test add_class and remove_class 2014-01-16 10:57:16 +00:00
Jonathan Frederic
ec68f38ed7 Removed get_kernel method. 2014-01-16 10:57:16 +00:00
Jonathan Frederic
8dc5535638 un-nest options.options 2014-01-16 10:57:16 +00:00
Jonathan Frederic
a6fac70e03 s/BaseWidgetView/WidgetView and s/WidgetView/DOMWidgetView 2014-01-16 10:57:16 +00:00
Jonathan Frederic
44cf406ac0 this.updating should be a key specific lock 2014-01-16 10:57:16 +00:00
Jason Grout
d658f362ac Update option-passing for creating child views. 2014-01-16 10:57:16 +00:00
Jonathan Frederic
3a271585d7 Add constructor comment for widget model. 2014-01-16 10:57:16 +00:00
Jonathan Frederic
d7835eb14e Added missing comma 2014-01-16 10:57:16 +00:00
Jonathan Frederic
d3b33828c5 handle_msg a display_model method. 2014-01-16 10:57:15 +00:00
Jonathan Frederic
261e92de74 re-order handle custom msg and handle recieve state 2014-01-16 10:57:15 +00:00
Jonathan Frederic
3254f338bb Added note in widget manager why Backbone.sync is there rather 
than the base.js (widget.js)
 2014-01-16 10:57:15 +00:00
Jonathan Frederic
3f3a7edd6a remove on_create_widget and handle_create_widget callback 2014-01-16 10:57:15 +00:00
Jonathan Frederic
17da002a6a remove msg.content.data.view_name and corrosponding create_view param 2014-01-16 10:57:15 +00:00
Jonathan Frederic
99d83a2ad1 move backbone sync outside the widget manager class 2014-01-16 10:57:15 +00:00
Jonathan Frederic
5dbffa5287 _model_types, _view_types, _models - and document what keys and values are 2014-01-16 10:57:15 +00:00
Jonathan Frederic
15dabce113 send_state only once for dict signature of set_css 2014-01-16 10:57:15 +00:00
Jonathan Frederic
6c11760a89 Fixed comments for optional kwargs so they are redundant. 2014-01-16 10:57:15 +00:00
Jonathan Frederic
670f4881ec remove 3rd callback type from on_displayed 2014-01-16 10:57:15 +00:00
Jonathan Frederic
7e6c8e4f1d Remove view_name from display 2014-01-16 10:57:15 +00:00
Jonathan Frederic
463bcf85ee Fixed _send so it can open a comm if needed. 
It no longer returns anything.
 2014-01-16 10:57:14 +00:00
Jonathan Frederic
85b5adff58 Remove first three lines of repr widgets 2014-01-16 10:57:14 +00:00
Jonathan Frederic
e383594d04 renamed: basic_widgets.js -> init.js 
renamed:    init.js -> widget.js
 2014-01-16 10:57:14 +00:00
Jonathan Frederic
5a3665d9ed s/widget.js/init.js 2014-01-16 10:57:14 +00:00
Jonathan Frederic
5b388df615 Added callbacks method to view 2014-01-16 10:57:14 +00:00
Jonathan Frederic
5ced2816e7 Removed sync_method parameter from backbone msg spec 2014-01-16 10:57:14 +00:00
Jonathan Frederic
4e19dd7933 s/_handle_widget_constructed/_call_widget_constructed 2014-01-16 10:57:14 +00:00
Jonathan Frederic
39aaf7bf88 s/default_view_name/view_name 2014-01-16 10:57:14 +00:00
Jonathan Frederic
21a14e11a4 s/Widget/DOMWidget s/BaseWidget/Widget 2014-01-16 10:57:14 +00:00
Jonathan Frederic
696a6e4c28 add/remove_class now can accept a list of classes 2014-01-16 10:57:14 +00:00
Jonathan Frederic
2600913067 Removed ViewWidget 2014-01-16 10:57:14 +00:00
Jonathan Frederic
441a3e3ca6 Updated require.js references 2014-01-16 10:57:14 +00:00
Jonathan Frederic
ee522adc18 Renamed widget js files 2014-01-16 10:57:14 +00:00
Jonathan Frederic
691db01e5e Missing view argument when recursively calling widgetmanager.callbacks(view) 2014-01-16 10:57:14 +00:00
Jonathan Frederic
babd5c44ba Completely remove cell from model and view. 2014-01-16 10:57:13 +00:00
Jonathan Frederic
9e43807579 Updated comm id comments in view to model id 2014-01-16 10:57:13 +00:00
Jonathan Frederic
3329f875f3 s/comm_id/model_id (left over from before) 2014-01-16 10:57:13 +00:00
Jason Grout
a0b2cc40b8 Make widget keys have more explicit inheritance 2014-01-16 10:57:13 +00:00
Jason Grout
ce98452180 Get rid of keys magic; make the keys very explicit 2014-01-16 10:57:13 +00:00
Jason Grout
f0a4b9ea30 Make the widget keys property traverse the superclasses and accumulate the _keys attributes. 
This caches the result, overwriting the property.
 2014-01-16 10:57:13 +00:00
Jason Grout
7cbda99b0d Add widget view options in creating child views 2014-01-16 10:57:13 +00:00
Jonathan Frederic
7c3b21d239 Fixed typo in model_id property 2014-01-16 10:57:13 +00:00
Jonathan Frederic
0c8b6029a6 Remove debug print statements in container tests 2014-01-16 10:57:13 +00:00
Jonathan Frederic
d2afb9895b Output one more for debugging 2014-01-16 10:57:13 +00:00
Jonathan Frederic
7f430db3c8 Print cell output 2014-01-16 10:57:13 +00:00
Jonathan Frederic
12760ddbe5 deleted: wigets_container.js 2014-01-16 10:57:13 +00:00
Jonathan Frederic
07b3a7639d Revert "Enabled IPython Server output for Travis debugging" 
This reverts commit eb7ee3f61335a7147fcfc1b1907d41f163bb0b41.
 2014-01-16 10:57:13 +00:00
Jonathan Frederic
74fccf47b3 Revert "Added line to dump page html casperjs" 
This reverts commit 7091ce87f7a280dde7724d92fd542b834f764e61.
 2014-01-16 10:57:13 +00:00
Jonathan Frederic
8891750535 Fixed static_url call which is no longer optionally 1 param 2014-01-16 10:57:12 +00:00
Jonathan Frederic
3a05f7e145 Enabled IPython Server output for Travis debugging 2014-01-16 10:57:12 +00:00
Jonathan Frederic
c7362cb524 Added line to dump page html casperjs 2014-01-16 10:57:12 +00:00
Jonathan Frederic
926c93eb84 Fixed indentation in widgetmanager.js 2014-01-16 10:57:12 +00:00
Jonathan Frederic
57f3057ca5 Moved view widget into widget.py 2014-01-16 10:57:12 +00:00