Commit Graph

11981 Commits

Author SHA1 Message Date
Kevin Bates
8d0af52125
Adjust skip decorators to avoid remaining dependency on nose (#5932) 2021-01-10 22:34:11 -08:00
Kevin Bates
245ca66603
Increase minimum tornado version (#5933) 2021-01-10 22:33:10 -08:00
Kevin Bates
71e402fff0
Merge pull request #5924 from oyvsyo/gateway_connection_retry
Add reconnection to Gateway (form nb2kg)
2021-01-06 08:06:29 -08:00
Dvoiak Stepan
d95f251ac6
Update notebook/gateway/managers.py
Co-authored-by: Kevin Bates <kbates4@gmail.com>
2021-01-05 18:23:32 +02:00
sd
cd102428ca traitlets Int for gateway_retry_max parameter 2021-01-05 13:40:02 +02:00
sd
ba0f490c94 mirrored logic from https://github.com/jupyter/nb2kg/pull/45 to notebook/gateway 2021-01-05 13:19:22 +02:00
Kevin Bates
16727777f5
Merge pull request #5894 from stefanor/trashpermissionerror
Handle TrashPermissionError, now that it exists
2021-01-03 10:45:16 -08:00
Kevin Bates
083df1bf5e
Merge pull request #5917 from user202729/patch-2
Fix some typos
2020-12-30 10:31:35 -08:00
user202729
3cc628e3fe Fix typo 2020-12-29 16:57:38 +07:00
Zsailer
fb5deeed23 Back to dev version 2020-12-23 14:56:23 -08:00
Zsailer
e39ccb9188 Release 6.1.6 2020-12-23 14:52:50 -08:00
Zachary Sailer
63450082ea
Merge pull request #5875 from kevin-bates/kernel-list-race-condition
Fix race condition with async kernel management
2020-12-23 12:06:07 -08:00
Kevin Bates
24bf3a5a73
Merge pull request #5898 from minrk/allow_origin_wildcard
handle allow_origin='*' in check_referer
2020-12-19 10:07:18 -08:00
Min RK
5abcbd3e9f
Merge pull request #5908 from SylvainCorlay/nudge-kernel
ensure iopub subscriptions propagate prior to accepting websocket connections
2020-12-18 12:20:59 +01:00
Min RK
672f0a6e20 nudge: handle failure cases
- connect iopub first (tiny effect on the race!)
- docstrings, log details
- resolve immediately if kernel is busy, rather than setting up timeouts, futures
- use gen.with_timeout instead of separately managed timeout
- use gen.multi to wait for both futures instead of duplicated check in each handler, third Future
- add various cancel conditions (sockets closed, kernel stopped, etc.)
2020-12-18 11:21:48 +01:00
Sylvain Corlay
94678545db Use transient shell channel, and do not nudge busy kernels 2020-12-17 15:28:50 +01:00
Min RK
f716328d90 relax busy/idle ordering on reconnect
nudge can leak idle messages, so it could be busy->idle, or idle->busy->idle.

The important thing is that we get at least one idle message
2020-12-17 13:27:49 +01:00
Sylvain Corlay
b4f5f6b4d4 Log nudge attempt count at warning-level if it keeps going up
Co-authored-by: Min RK <benjaminrk@gmail.com>
2020-12-17 13:27:02 +01:00
Sylvain Corlay
708c8c7c51
Merge pull request #5911 from dtaniwaki/patch-1
Fix typo
2020-12-16 09:09:47 +01:00
Sylvain Corlay
2c87813ef4 Add counter for nudge attempts 2020-12-15 18:32:35 +01:00
Sylvain Corlay
9770ef7760 Review: open is not a coroutine 2020-12-15 17:33:38 +01:00
Daisuke Taniwaki
caab6baeca
Fix typo 2020-12-15 15:18:02 +09:00
Min RK
067c3993f2 handle allow_origin='*' in check_referrer
allow_origin can be the wildcard '*' to allow any host

check_referer should match check_origin
2020-12-14 14:27:42 +01:00
Min RK
3b974015c9
Merge pull request #5907 from bollwyvl/fix-asyncio-win-patch-version
do not apply asyncio patch for tornado >=6.1
2020-12-14 14:23:32 +01:00
Sylvain Corlay
7a3ae6e4a4 Nudge kernel with info request until we receive IOPub messages 2020-12-12 10:46:56 +01:00
Nicholas Bollweg
73c9ac1b2c do not apply asyncio patch for tornado >=6.1 2020-12-10 20:05:40 -05:00
Zachary Sailer
0c83c9d59f
Merge pull request #5889 from jmandreoli/patch-1
Added section for file editor configuration
2020-12-09 08:29:52 -08:00
Kevin Bates
c5a0f804f0
Merge pull request #5893 from mgeier/review-notebook-examples
example notebook: don't recommend using $$...$$ for display math
2020-12-09 08:14:09 -08:00
Kevin Bates
eb2b4c6a7f
Merge pull request #5896 from Zsailer/issue_template
Add an issue template and issue landing page.
2020-12-02 16:23:18 -08:00
Zsailer
13bc0d6a1c clearly distinguish this/that in issue template pointing at discourse 2020-12-02 11:45:20 -08:00
Zsailer
1a1bf7dfb2 add issue template 2020-12-02 11:37:10 -08:00
Stefano Rivera
7bcc824873 Handle send2trash failure in test_delete_non_empty_dir
If the test working directory isn't trashable, we expect to not be able
to delete the non-empty directory.
2020-12-01 14:11:52 -08:00
Stefano Rivera
6a46458f1f Check for TrashPermissionError rather than guess
_check_trash() was added (in #3304) because TrashPermissionError didn't
exist, yet.

Now that it does, we can use it, and stop guessing what will cause a
permission problem.

Closes: #3374
2020-12-01 13:17:36 -08:00
Matthias Geier
99adc0e5c4 example notebook: don't recommend using $$...$$ for display math 2020-12-01 17:34:21 +01:00
jmandreoli
9e62e2defe
Added section for file editor configuration
The doc shows how to update codemirror options for the notebook cell editor, but not for the whole file editor. I have added lines 51-62 to give that information. The information comes from Stack-Overflow (and has been tested), but it has been frustratingly long to find, so I think it is worth sharing ...
2020-11-29 16:51:28 +01:00
Kevin Bates
02024f0b9a
Merge pull request #5880 from mofanke/master
Update handlers.py Remove or correct this useless self-assignment
2020-11-23 06:45:11 -08:00
mofanke
af72fa1cc7
Update handlers.py
Remove or correct this useless self-assignment
2020-11-23 14:46:49 +08:00
Zachary Sailer
32bd47068b
Merge pull request #5874 from kevin-bates/port-sec-advisory
Apply security advisory fix to master
2020-11-18 11:08:32 -08:00
Min RK
e8459d97eb
Release 6.1.5 2020-11-18 10:14:34 -08:00
Min RK
ee64f5475d
changelog for 6.1.5 2020-11-18 10:13:09 -08:00
Min RK
1abd95130c
Validate redirect target in TrailingSlashHandler
Fixes open redirect vulnerability GHSA-c7vm-f5p4-8fqh
2020-11-18 10:13:08 -08:00
Kevin Bates
ed0c640898
Fix race condition with async kernel management 2020-11-18 08:10:53 -08:00
Zachary Sailer
5a73a8e402
Merge pull request #5870 from yuvipanda/authenticate-prometheus
Allow toggling auth for prometheus metrics
2020-11-17 13:21:31 -08:00
YuviPanda
c0ab18a534 Allow toggling auth for prometheus metrics
Equivalent to https://github.com/jupyterhub/jupyterhub/pull/2224

Prometheus metrics can potentially leak information about
the user, so they should be kept behind auth by default.
However, for many JupyterHub deployments, they would need
to be scraped by a centralized Prometheus instance that can not
really authenticate separately to each user notebook without
a lot of work. Admins can use this setting to allow unauthenticated
access to the /metrics endpoint.
2020-11-17 23:14:54 +05:30
Kevin Bates
cd7a06ce88
Merge pull request #5845 from bollwyvl/add-wasm-mime
Add wasm mimetype override
2020-11-04 08:04:12 -08:00
Zachary Sailer
57f8150ab9
Merge pull request #5847 from kevin-bates/restore-mac-ctrl-enter
Restore ctrl-enter shortcut behavior for macOS users
2020-11-04 07:32:23 -08:00
Nicholas Bollweg
c508af3cff add wasm mimetype 2020-11-03 22:34:30 -05:00
Kevin Bates
c893b59a9b
Restore ctrl-enter shortcut for mac users 2020-11-03 16:07:01 -08:00
Kevin Bates
72217183c8
Merge pull request #5826 from pgajdos/denose
do not require nose for testing
2020-10-29 07:17:14 -07:00
pgajdos
30a716fb85 remove redundant print statements 2020-10-29 08:53:35 +01:00