Commit Graph

158 Commits

Author SHA1 Message Date
Thomas Kluyver
cbc141c95c Fixes for notebook checkpoint APIs 2013-10-17 14:09:19 -07:00
Thomas Kluyver
3f46a05a14 Test notebook checkpoint APIs 2013-10-17 14:09:19 -07:00
MinRK
4a12890d65 disable download-as-pt
since it doesn't work. Adds a note about nbconvert needed to bring it back.
2013-10-17 14:09:19 -07:00
Thomas Kluyver
d089f7749f Use assertEqual, not deprecated assertEquals 2013-10-17 14:09:19 -07:00
Thomas Kluyver
836ad5f388 Add tests for interrupting & restarting kernel
These are in an existing test method, as starting and stopping kernels
for individual tests is expensive.
2013-10-17 14:09:19 -07:00
Thomas Kluyver
06fa301908 Refactor tests for kernels REST API 2013-10-17 14:09:18 -07:00
MinRK
8b9bb04d12 review pass on Sessions API 2013-10-17 14:09:18 -07:00
Thomas Kluyver
b1a0f2e8cc 404 on attempt to list notebooks in nonexistant directory 2013-10-17 14:09:18 -07:00
Thomas Kluyver
18f88d020f Add failing test for listing nonexistant directory 2013-10-17 14:09:18 -07:00
Thomas Kluyver
99969474e0 Fix notebook manager test 2013-10-17 14:09:17 -07:00
Thomas Kluyver
c18aaefbde Fix sessionmanager test 2013-10-17 14:09:17 -07:00
Thomas Kluyver
e240f21ea1 Clean up sessions code from static analysis 2013-10-17 14:09:17 -07:00
Thomas Kluyver
693cc97905 Fix some HTTP status codes in sessions API 2013-10-17 14:09:17 -07:00
Thomas Kluyver
b3d2698c11 Fix session API tests 2013-10-17 14:09:17 -07:00
Thomas Kluyver
a02bd3d5e4 Improve Session REST API tests 2013-10-17 14:09:17 -07:00
Thomas Kluyver
a6a7255454 Fix some notebook model tests 2013-10-17 14:09:17 -07:00
MinRK
acb4245035 unicode normalization in test_notebooks_api 2013-10-17 14:09:17 -07:00
Thomas Kluyver
9f4a4ab3f8 Check Location header from renaming notebook 2013-10-17 14:09:16 -07:00
Thomas Kluyver
9144e8e57b Fix check of notebook path 2013-10-17 14:09:16 -07:00
Thomas Kluyver
eb9a55ed6b Add test for and fix REST save with rename 2013-10-17 14:09:16 -07:00
Thomas Kluyver
b9310d0e05 Add test for copying notebook through REST API 2013-10-17 14:09:16 -07:00
Thomas Kluyver
7725025d52 Add test for saving notebook via REST API 2013-10-17 14:09:16 -07:00
Thomas Kluyver
85d3c39b5a Add test for REST API uploading notebook 2013-10-17 14:09:16 -07:00
Thomas Kluyver
9d9adb1186 Improve tests for notebook REST API 2013-10-17 14:09:15 -07:00
MinRK
6c88abe1d6 always set location on PATCH
don't redirect
2013-10-17 14:09:15 -07:00
MinRK
dc65b33d14 simplify handler patterns
PATH pattern will now sometimes include leading slash,
but that's okay because nbmanager will strip them.

fewer redirect patterns needed
2013-10-17 14:09:15 -07:00
MinRK
a31cfdc8a8 ensure 'path' never has leading or trailing slash in nbmanager
Don't trust API callers to always get this right.
2013-10-17 14:09:15 -07:00
MinRK
a7f297f8f3 save before download-as
uses `async : false`

closes #852

download-as-py still unavailable.
2013-10-17 14:09:15 -07:00
MinRK
8b94ee2b47 use async : false to avoid pop-up blocker on New / Copy notebook 2013-10-17 14:09:14 -07:00
MinRK
b33ffa7068 update upload and copy
adds 'notebook.ipynb/copy' url handler

because we were putting too many things in a single POST handler.
2013-10-17 14:09:14 -07:00
MinRK
4e12521082 fix dashboard upload 2013-10-17 14:09:14 -07:00
MinRK
5b1a648fc8 move os_path to FileNBMan
doesn't belong in base NotebookManager
2013-10-17 14:09:14 -07:00
MinRK
fe59217989 move url_[un]escape to utils from nbm 2013-10-17 14:09:13 -07:00
MinRK
16e8d0ff43 adjust definition of 'path' in notebooks
never includes leading or trailing '/'
2013-10-17 14:09:13 -07:00
MinRK
e46412e30f fix --notebook-dir configurable when there is no trailing slash 2013-10-17 14:09:13 -07:00
Zachary Sailer
d3e456d9a1 add tests to notebooks api
- check for correct status codes
- check headers location
- fix COPY api
2013-10-17 14:09:12 -07:00
Zachary Sailer
9e0beba86f adding to test_kernels_api.py
- Check all HTTP status code responses for requests
- Test invalid kernel IDs
- Check 'location' key in POST request to kernels
2013-10-17 14:09:12 -07:00
Zachary Sailer
c26700cd3a changes after session manager code review 2013-10-17 14:09:12 -07:00
Zachary Sailer
7aaaab0668 fixed notebook rename after nbmanager refactor 2013-10-17 14:09:12 -07:00
Zachary Sailer
2a946c62ab added tests to nbmanager for url encode/decode 2013-10-17 14:09:11 -07:00
Zachary Sailer
97bc426bb7 add error catching to kernel manager
also, adding further tests to kernel manager
2013-10-17 14:09:11 -07:00
Brian E. Granger
c0bc0410ce Review and refactoring of notebooks web service. 2013-10-17 14:09:11 -07:00
MinRK
5568cd5db0 ensure test_no_kernels runs first
since it expects a clean notebook server.
2013-10-17 14:09:11 -07:00
Zachary Sailer
27680dacb2 Code review changes.
Fixed handler issues and api tests from code review
from @minrk and @carreau.
2013-10-17 14:09:11 -07:00
Zachary Sailer
04c6a3cfac refactoring of nbmanager and filenbmanager
major clean up of the two managers. We make sure to follow
the standard models described in IPEP 16
2013-10-17 14:09:10 -07:00
Zachary Sailer
050a3098a8 review fixes on tests, add extra kernel api test 2013-10-17 14:09:10 -07:00
Zachary Sailer
e9ac1c2d37 add tests for session api 2013-10-17 14:09:10 -07:00
Zachary Sailer
8ce586a241 move notebooks api tests into notebooks/tests 2013-10-17 14:09:10 -07:00
Paul Ivanov
f517d44d4b removing contents changes from this PR 2013-10-17 14:09:10 -07:00
Zachary Sailer
95b505d602 Added notebooks API tests. 2013-10-17 14:09:10 -07:00
Zachary Sailer
5f1b7727d8 fix bug in test_contentmanager 2013-10-17 14:09:09 -07:00
Brian E. Granger
136a19e5eb Added base class for Notebook API tests. 2013-10-17 14:09:09 -07:00
Zachary Sailer
483d16c8ed clean kernel manager 2013-10-17 14:09:09 -07:00
Zachary Sailer
22e351ae3b cleaning nb handlers, adding doc-strings/comments 2013-10-17 14:09:09 -07:00
Zachary Sailer
8c2009874c session manager restructuring
Redid the sessionmanager, added tests for the session manager,
and added a sqlite database to hold kernel,session,nb mapping.
2013-10-17 14:09:09 -07:00
Paul Ivanov
b8318708eb clean up of get_os_path and its tests
work with @Zsailer
2013-10-17 14:09:09 -07:00
Zachary Sailer
34b9840786 fixing broken links from recent changes.
After fixing operating system path changes in previous commits,
many links needed to be adjusted to direct to the correct URL.
2013-10-17 14:09:09 -07:00
Zachary Sailer
470595f9e7 handle path separators with os.sep and add tests
Added more tests to the notebook manager to check for the correct
path separators on different operating system. Fixed the get_path
method.
2013-10-17 14:09:08 -07:00
Zachary Sailer
bdbe30dc3a url encode/decode tests added to nbmanager 2013-10-17 14:09:08 -07:00
Paul Ivanov
7ca8a21bf6 named_notebook_path: consistent usage convention 2013-10-17 14:09:08 -07:00
Paul Ivanov
a083ad1fd7 more named_notebook_path cleanup
named_notebook_path now returns path with leading and trailing slashes.
Work with @Zsailer
2013-10-17 14:09:08 -07:00
Paul Ivanov
fd7a64ff38 simplified named_notebook_path implementation
Also updated the tests
2013-10-17 14:09:08 -07:00
Paul Ivanov
9f08aa5a08 cleaning up named_notebook_path 2013-10-17 14:09:08 -07:00
Paul Ivanov
11e5bd7b24 adding tests for named_notebook_path
I want to do some refactoring, so I'll put in some tests that will define the
behavior that I want to preserve, so I can verify that my refactoring hasn't
broken anything.
2013-10-17 14:09:08 -07:00
Thomas Kluyver
18fdb26273 Fix to if test 2013-10-17 14:09:07 -07:00
Thomas Kluyver
6154c5f626 Remove some unnecessary imports 2013-10-17 14:09:07 -07:00
Thomas Kluyver
2a81c5f80c Update docstring 2013-10-17 14:09:07 -07:00
Thomas Kluyver
213b89c1cc Simplify encoding/decoding URL parts 2013-10-17 14:09:07 -07:00
Thomas Kluyver
adb2fc1fa4 Better use Python slicing 2013-10-17 14:09:07 -07:00
Zachary Sailer
1f04b48725 Renaming fixed 2013-10-17 14:09:07 -07:00
Zachary Sailer
f3af343f4f Change new/copy URLS to POST requests 2013-10-17 14:09:06 -07:00
Zachary Sailer
8261ac2cb9 change standard money keys 2013-10-17 14:09:06 -07:00
Zachary Sailer
c7375e170f rebase master- eliminate read-only 2013-10-17 14:09:06 -07:00
Zachary Sailer
eb1690255d allow spaces in notebook path 2013-10-17 14:09:06 -07:00
Zachary Sailer
a219abaeeb standard model changes 2013-10-17 14:09:06 -07:00
Zachary Sailer
5af83cd705 redirect url after notebook rename 2013-10-17 14:09:05 -07:00
Zachary Sailer
fd282698bc removing debug logs 2013-10-17 14:09:05 -07:00
Zachary Sailer
5462cb4d9b fixed delete_content in contentmanager 2013-10-17 14:09:05 -07:00
Zachary Sailer
91f25dc046 add contents web service api 2013-10-17 14:09:05 -07:00
Zachary Sailer
ad621913f1 added folder creation ability using '/-new' 2013-10-17 14:07:51 -07:00
Zachary Sailer
d06cf1fed7 added "last_modified" to notebook_model 2013-10-17 14:07:51 -07:00
Zachary Sailer
d4ee2da291 proper '.py' and '.ipynb' download files 2013-10-17 14:07:51 -07:00
Zachary Sailer
022b8324b2 Download '.py' fixed, deleted debugging output 2013-10-17 14:07:51 -07:00
Zachary Sailer
bfff3d817d Fixed bug when linking kernel to new code cells 2013-10-17 14:07:51 -07:00
Zachary Sailer
c4e06a3728 allow rename in subdirectory notebooks 2013-10-17 14:07:51 -07:00
Zachary Sailer
ece92127d3 Add 'patch' to session & notebook, rename working 2013-10-17 14:07:51 -07:00
Zachary Sailer
e4a7b724a6 fixed shutdown button refresh on dashboard 2013-10-17 14:07:51 -07:00
Zachary Sailer
62ec52e276 fix restart/interrupt kernel buttons 2013-10-17 14:07:50 -07:00
Zachary Sailer
20324bafd0 fixing path redirects, cleaning path logic 2013-10-17 14:07:50 -07:00
Zachary Sailer
11cef9ab45 fixing some bugs after rebase 2013-10-17 14:07:50 -07:00
Zachary Sailer
0559df1b8a manual rebase - add sessions web service 2013-10-17 14:07:49 -07:00
Zachary Sailer
98e67bfa22 manual rebase notebooks web services 2013-10-17 14:07:49 -07:00
Zachary Sailer
09c4ecbb10 manual rebase services/kernels/ 2013-10-17 14:07:49 -07:00
Matthias Bussonnier
e07ddebdf6 Merge pull request #3743 from minrk/noro
remove notebook read-only view

it is largely broken, and had problematic security issues.
2013-07-25 10:51:26 -07:00
MinRK
f9dd129e1c remove notebook read-only view
it is largely broken, and had problematic security issues.
2013-07-23 13:22:05 -07:00
MinRK
2a09958bb6 better message when notebook format is not supported
Different messages for bad version and bad JSON.

closes #1592
2013-07-23 12:36:22 -07:00
MinRK
39578beabc remove max_msg_size altogether
It was a security feature without an application.
2013-07-09 09:37:36 -07:00
MinRK
4408ab6ca1 warn about messages dropped due to oversize 2013-07-05 22:17:40 -07:00
MinRK
563d9372bf up default max_msg_size to 1MB 2013-07-05 22:17:39 -07:00
Brian E. Granger
7941da8fe2 Merge pull request #3498 from ellisonbg/nbname
When a notebook is written to file, name the metadata name u''.
2013-07-05 11:31:41 -07:00