Commit Graph

10520 Commits

Author SHA1 Message Date
Kyle Kelley
099f83e11e Merge pull request #2880 from jcb91/codemirror_ruler
fix codemirror.less to match CodeMirror's expected padding layout
2017-09-30 16:36:14 -07:00
Josh Barnes
df19a51f59 fix codemirror.less to match CodeMirror's expected padding layout
fixes #2869 (I hope!)
2017-09-30 02:47:39 +01:00
Sam Lau
1c2a256add Add x-xsrftoken to Access-Control-Allow-Headers
When starting a kernel using the Jupyter Notebook Kernel API, web
browsers will automatically check for the presence of `x-xsrftoken` in
the Access-Control-Allow-Headers during the preflight CORS check
([ref][ref]).

[ref]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers

Since we didn't allow this header before, web browsers would fail the
preflight check even when the x-xsrftoken header isn't being used by the
notebook server.

This meant that running a webpage on localhost:8080 that used Javascript
to start a kernel on a notebook server running on localhost:8888 would
fail.

How I tested this commit:

1. Start a notebook server using

		jupyter notebook --no-browser --NotebookApp.allow_origin="*" --NotebookApp.disable_check_xsrf=True --NotebookApp.token=''

2. Build the [web3](https://github.com/jupyter-widgets/ipywidgets/tree/master/examples/web3) example from ipywidgets.
3. In that directory, run `npm run host`.
4. Verify that visiting http://localhost:8080/ starts a kernel in the notebook server.
2017-09-28 15:42:41 -07:00
Kyle Kelley
b884ff9755 Merge pull request #2866 from rgbkrk/fix-dynamic-locale
load locale dynamically only when not en-us
2017-09-25 20:48:34 -07:00
Kyle Kelley
11e578f7fd load locale dynamically only when not en-us 2017-09-25 16:24:26 -07:00
Kyle Kelley
b2edf8963c Merge pull request #2853 from minrk/api-403
Update error handling on APIHandlers
2017-09-25 13:51:07 -07:00
Kyle Kelley
92354d5af2 Merge pull request #2861 from nl5887/patch-1
changed key strength to 2048 bits
2017-09-25 06:51:41 -07:00
Kyle Kelley
91addcf776 Merge pull request #2860 from minrk/jsversion
resync jsversion with Python version
2017-09-25 06:51:14 -07:00
Remco Verhoef
9b6975d137 changed key strength to 2048 bits
* using a key strength of 1024 bits is considered a bad practice
2017-09-25 13:39:20 +02:00
Kyle Kelley
63d4415edb Merge pull request #2854 from Madhu94/copy-dirty-readonly-notebook
Allow copy operation on modified, read-only notebook
2017-09-25 02:27:25 -07:00
Min RK
d59349ac15 resync jsversion with Python version
by running setup.py jsversion
2017-09-25 10:50:29 +02:00
Min RK
4467dc9f12 specify version for deprecation 2017-09-21 12:54:36 +02:00
Min RK
962c5ccd80 stop using @json_handlers 2017-09-21 12:53:51 +02:00
Min RK
ba353e20f7 use .write_error on APIHandler instead of @json_errors for JSON error messages
this is the standard tornado way to do it, and catches errors at the `prepare` stage, which method decorators do not
2017-09-21 12:03:21 +02:00
Min RK
92209228f6 raise 403 on APIHandler failed login
instead of redirecting to human login page, which can have side effects
2017-09-21 12:01:20 +02:00
Min RK
aa58dcbca4 Merge pull request #2852 from takluyver/travis-py36
Test Python 3.6 on Travis, drop 3.3
2017-09-20 19:49:48 +02:00
madhu
a5e64c3f77 fix(notebook): Allow copy operation on modified, read-only
notebooks
Should close #2541
2017-09-20 16:13:06 +05:30
Thomas Kluyver
11ba6be432 Merge pull request #2745 from gnestor/keymap-default
Make "extraKeys" consistent for notebook and editor
2017-09-20 11:22:19 +01:00
Thomas Kluyver
1ec12f7215 Test Python 3.6 on Travis, drop 3.3 2017-09-20 10:37:38 +01:00
Thomas Kluyver
39c27ac416 Merge pull request #2849 from cancan101/patch-1
Upgrade xterm.js to 2.9.2
2017-09-20 10:28:30 +01:00
Thomas Kluyver
447d79ffc0 Pass API path to get_os_path 2017-09-20 10:27:59 +01:00
Kyle Kelley
2d582e0e79 Merge pull request #2851 from minrk/fix-image-tests
avoid base64-literals in image tests
2017-09-19 11:09:51 -07:00
Min RK
ed139a1cea avoid base64-literals in image tests
use Python variables storing raw bytes
2017-09-19 18:31:56 +02:00
Alex Rothberg
132f042c88 Upgrade xterm.js to 2.9.2 2017-09-18 15:31:47 -04:00
Grant Nestor
f222978992 Remove comments 2017-09-16 07:50:29 -07:00
Thomas Kluyver
9dabaa2ccf Merge pull request #2774 from iamlemec/master
Factor out output_prompt_function, as is done with input prompt
2017-09-15 20:47:44 +01:00
Grant Nestor
fb4af909a1 5.2.0.dev 2017-09-15 11:24:34 -07:00
Grant Nestor
aa3c1a5481 Merge pull request #2357 from Ashamandi/master
Bidi support
2017-09-15 11:07:11 -07:00
Douglas Hanley
c946374aba output_prompt_function: construct node rather than use HTML string 2017-09-15 11:27:55 -04:00
Doug Hanley
53c39ff61f Factor out output_prompt_function, as is done with input prompt 2017-09-15 11:01:59 -04:00
Thomas Kluyver
2056b1ba6f Give OS path to nbconvert if possible 2017-09-15 12:19:46 +01:00
Thomas Kluyver
5a0ee98441 Merge pull request #2767 from minrk/filename
use RFC5987 encoding for filenames
2017-09-15 10:50:05 +01:00
Thomas Kluyver
f315f23fe9 Merge pull request #2823 from vidartf/nbval-ci
Add more doc tests
2017-09-15 10:47:30 +01:00
Grant Nestor
ff49a10a36 release 5.1.0 2017-09-14 14:34:35 -07:00
Thomas Kluyver
3543f79254 Merge pull request #2752 from minrk/schedule-stop-callback
schedule IOLoop.stop on the main thread
2017-09-14 10:46:35 +01:00
Min RK
b2bd0ff702 missing add_callback_from_signal 2017-09-14 10:38:06 +02:00
Thomas Kluyver
60f81e49b2 release 5.1.0rc3 2017-09-12 11:43:23 +01:00
Steven Silvester
834b75af70 Merge pull request #2830 from mpacer/file_var_rename
changed all python variables named file to file_name to not override built_in file
2017-09-06 09:02:12 -05:00
M Pacer
2fac7003e2 changed all python variables named file to file_name to not override built_in file 2017-09-05 16:59:41 -07:00
Vidar Tonaas Fauske
f6de61d34e Fix some broken links and permanent redirects 2017-09-01 13:09:51 +02:00
Vidar Tonaas Fauske
522fcf403c Add nbval to docs tests 2017-09-01 13:03:54 +02:00
Thomas Kluyver
d4c6fe46ce Merge pull request #2815 from sytays/patch-2
typos fix
2017-08-28 17:50:41 +01:00
Syed TS
b87fa6c734 typos fix-2 2017-08-28 15:18:10 +00:00
Syed TS
563f220a43 typos fix 2017-08-28 10:12:47 +00:00
Min RK
86092a1d10 use add_callback_from_signal 2017-08-26 10:33:16 -04:00
Min RK
f8a6e1c5b7 Merge pull request #2792 from takluyver/mathjax-callback-err
Attempt to fix mysterious mathjax callback error
2017-08-26 10:31:46 -04:00
J Forde
30f739cf69 Merge pull request #2808 from jiaqi216/docs-build
Travis Builds Doc
2017-08-25 19:22:56 -04:00
Jiaqi Liu
44471d97f4 docs only run in python3 2017-08-25 14:02:13 -07:00
Jiaqi Liu
3a23a69d97 rename doc group to docs 2017-08-25 13:22:25 -07:00
Jiaqi Liu
df76c6e2f5 forgot -r 2017-08-25 13:00:14 -07:00