Commit Graph

3110 Commits

Author SHA1 Message Date
MinRK
19e4b74678 revert output area changes 2014-01-12 14:34:03 -08:00
MinRK
d6deaaaf1f protect javascript from invalid mime-type data
everything is a string, if anything else is sent,
drop it so it doesn't show up in the notebook document.
2014-01-12 14:24:16 -08:00
Min RK
2d871ff682 Merge pull request #4533 from ivanov/display-isolated
propagate display metadata to all mimetypes

Additionally, this PR removes in-memory short keys in favor of using mimetype keys within the notebook javascript code, and tests toJSON/fromJSON codepaths for all of the supported mimetypes.

The change fixes the dropping of unrecognized mime-types from the notebook document.
2014-01-12 14:09:53 -08:00
Paul Ivanov
5209e82a96 fix mathjax typesetting 2014-01-12 13:54:47 -08:00
Paul Ivanov
5423613ef3 add test for custom mimetypes 2014-01-12 13:54:47 -08:00
Paul Ivanov
8ab7162c07 added svg to/fromJSON tests 2014-01-12 13:54:47 -08:00
Paul Ivanov
dfb21543c6 added jpeg mimetype tests 2014-01-12 13:54:47 -08:00
Paul Ivanov
6976eac897 adding png mimetype tests 2014-01-12 13:54:47 -08:00
Paul Ivanov
9c32f78efe tests for HTML mimetype 2014-01-12 13:54:47 -08:00
Paul Ivanov
369220042a add test for latex to/fromJSON 2014-01-12 13:54:47 -08:00
Paul Ivanov
9be3013d31 refactor clearing and executing first cell in test 2014-01-12 13:54:47 -08:00
Paul Ivanov
ea8a7745d8 love javascript.
it gives me many opportunities to be sarcastic in my commit messages
2014-01-12 13:54:47 -08:00
Paul Ivanov
f93b47ac37 more refactoring - test to/fromJSON for mimetypes 2014-01-12 13:54:46 -08:00
Paul Ivanov
744178de32 minor formatting 2014-01-12 13:54:46 -08:00
Paul Ivanov
11eabc2e40 refactor tests with more concise assertion checks 2014-01-12 13:54:46 -08:00
Paul Ivanov
ebe9c20ca2 fix small bug in dropping metadata 2014-01-12 13:54:46 -08:00
Paul Ivanov
0e72314379 minor cleanup 2014-01-12 13:54:46 -08:00
Paul Ivanov
a001003d67 remove dynamic keyword, handling it in fromJSON
After discussing this in person with @minrk, we decided instead of
passing this parameter around and special-casing javascript, it's easier
to just remove javascript from the display_order for the duration of
fromJSON, since that's the only place where dynamic was set to False,
and then put it back in at the end of the fromJSON call.
2014-01-12 13:54:46 -08:00
Paul Ivanov
f147e50545 hardcode type into the mimetype specific functions 2014-01-12 13:54:46 -08:00
Paul Ivanov
e094fca4ef dispatch on mime type for append methods 2014-01-12 13:54:46 -08:00
Paul Ivanov
a6be6e9821 love them semicolons 2014-01-12 13:54:46 -08:00
Paul Ivanov
b4c9df8ecc fix stream saving 2014-01-12 13:54:46 -08:00
Paul Ivanov
25a4bb0c26 plain text and json display_data and pyout tests 2014-01-12 13:54:46 -08:00
Paul Ivanov
07823deda3 minor formatting 2014-01-12 13:54:46 -08:00
Paul Ivanov
a7ca25a602 fix toJSON/fromJSON renaming 2014-01-12 13:54:46 -08:00
Paul Ivanov
7c262155f7 add (failling) roundtrip test case 2014-01-12 13:54:46 -08:00
Paul Ivanov
e0aab910da minimal notebook rountrip test 2014-01-12 13:54:46 -08:00
Paul Ivanov
d4ab0f4466 unify key renaming for to/from json short keys 2014-01-12 13:54:46 -08:00
Paul Ivanov
ee9ecc5548 convert back to short names when writing to JSON 2014-01-12 13:54:46 -08:00
Paul Ivanov
6089570dec stop using convert_to_mime_types
the in-memory representation and the messsage spec now all use mimetype
names for the JSON keys.
2014-01-12 13:54:46 -08:00
Paul Ivanov
d26ce5ffa2 fix png inlining 2014-01-12 13:54:46 -08:00
Paul Ivanov
7aaa3a9203 convert short names like 'png' to mimetype names 2014-01-12 13:54:46 -08:00
Paul Ivanov
b415af3dba align with current master 2014-01-12 13:54:46 -08:00
Paul Ivanov
ef60127e6e use mime type in memory 2014-01-12 13:54:46 -08:00
Paul Ivanov
509f88534c distinguish display_svg() and display() tests 2014-01-12 13:54:46 -08:00
Paul Ivanov
e8aa99b603 check mime-keyed metadata first, then top level 2014-01-12 13:54:46 -08:00
MinRK
d9e57a5b6a passthrough unrecognized output mime-types
preserves the bad mime-type -> short name conversion for supported types,
but allows passthrough for additional mime-types,
so at least data is not discarded.
2014-01-12 13:52:13 -08:00
Paul Ivanov
93831f0dfc clear output in-between test runs 2014-01-12 13:52:13 -08:00
Paul Ivanov
459b5ea7ad use non-mimetype-keyed metadata in the outputarea 2014-01-12 13:52:13 -08:00
Paul Ivanov
2e72ab3cd6 make output code not drop non-mimetype-keyed json 2014-01-12 13:52:13 -08:00
Paul Ivanov
5fefd65d72 added test for display() calls with metadata
this test is currently failing
2014-01-12 13:52:13 -08:00
MinRK
db4c814812 warn when notebook is started in pylab mode
because it is always a bad idea
2014-01-12 11:43:02 -08:00
Min RK
f7388dd2ea Merge pull request #4785 from SylvainCorlay/master
Replacing a for-in loop by an index loop on an array
2014-01-11 15:24:48 -08:00
Sylvain Corlay
a053ba2419 Replacing a for-in loop by an index loop on an array, to avoid enumerating inherited properties 2014-01-11 19:46:07 +00:00
Carlos Cordoba
91a7ee984a Fix "Source" text for the "Other Syntax" section of the notebook
Before it was shown as the "Display" one because of a missing end of
line.
2014-01-10 23:32:57 -05:00
Brian E. Granger
736172febe Merge pull request #4780 from ellisonbg/uiexample
Updating CSS for UI example.
2014-01-10 16:52:40 -08:00
Brian E. Granger
9eae59d8e4 Opps forgot some CSS. 2014-01-10 16:48:57 -08:00
Brian E. Granger
916951481b Updating CSS for UI example. 2014-01-10 16:43:30 -08:00
Brian E. Granger
d8db72564a Merge pull request #3605 from ellisonbg/newux
Modal UI - a whole new world of fun....its like vim, but not!
2014-01-10 16:10:25 -08:00
Brian E. Granger
06d40366aa Work on shortcuts and examples notebook. 2014-01-10 12:48:56 -08:00