Commit Graph

1150 Commits

Author SHA1 Message Date
MinRK
bfb3d8ec30 check that a handler is actually registered in ShortcutManager.handles
there are a few shortcuts that do not specify handlers
(just for quick help contents),
and this was preventing the actual events from ever firing.
2014-03-27 14:31:07 -07:00
MinRK
8a44e91c0c use modal_stretch on keyboard shortcut dialog 2014-03-27 13:32:42 -07:00
MinRK
b3b200abcb add modal_stretch class
for stretching a dialog to fill the screen
2014-03-27 13:32:18 -07:00
MinRK
4d955e9641 remove unneeded width: 100% firefox workaround
this is no longer needed with `display: flex`
2014-03-27 13:31:02 -07:00
jon
79f6ea9b1f Allow '.', '+.', '+', '-.', and '-' even though without numbers, they cannot be parsed. 2014-03-27 10:29:02 -07:00
MinRK
9552688a71 back to dev 2014-03-25 22:46:06 -07:00
MinRK
2adfb5254c 2.0.0-rc1 2014-03-25 20:16:54 -07:00
Paul Ivanov
f1573bd266 CodeMirror shortcuts in QuickHelp
Our users shouldn't need an internet connection to look at the code
mirror shortcuts. This PR places the CM keyboard shortcuts that are
currently documented on our website's rendered docs, and places them
inside the keyboard shortcuts quickhelp.
2014-03-25 18:19:06 -07:00
Paul Ivanov
0240b20127 Merge pull request #5419 from minrk/responsive-prompts
move prompts from margin to main column on small screens
2014-03-25 16:47:26 -07:00
Min RK
a594a691c6 Merge pull request #5430 from jdfreder/elementappend
Make sure `element` is correct in the context of displayed JS
2014-03-25 16:44:34 -07:00
Min RK
34571232bb Merge pull request #5396 from ivanov/fix-5363
prevent saving of partially loaded notebooks
2014-03-25 16:40:24 -07:00
Paul Ivanov
f41750ca6b address PR feedback 2014-03-25 16:31:29 -07:00
Jonathan Frederic
1235c2f638 Make sure element is correct in the context of displayed JS
closes #5293
2014-03-25 15:54:20 -07:00
Jonathan Frederic
b4099518f8 Fix tooltip pager feature
Updates to tooltip.js for msg spec changes.
2014-03-25 15:12:38 -07:00
Min RK
b294bf7059 Merge pull request #5404 from jdfreder/accordion
Fix broken accordion widget
2014-03-24 18:08:17 -07:00
Jonathan Frederic
e1daedf95b Fixed keyboard.js indent break 2014-03-24 15:43:10 -07:00
Paul Ivanov
997a9735f0 Merge pull request #5320 from jdfreder/focusbug_tt
Fix for Tooltip & completer click focus bug.
2014-03-24 15:18:45 -07:00
Paul Ivanov
c5054883e9 small fixes for #5320 2014-03-24 15:02:04 -07:00
MinRK
f5ad1cc398 move prompts from margin to main column on small screens
This is mainly for nbviewer, but the relevant CSS lives in IPython.
2014-03-24 11:30:12 -07:00
Jonathan Frederic
aed8b7ba3c Remove commented out lines (for tab evt) 2014-03-21 14:39:43 -07:00
Jonathan Frederic
cbab393e44 Shrink cleanup lines 2014-03-21 13:20:46 -07:00
Jonathan Frederic
b90358888b Fab CSS 2014-03-21 13:20:10 -07:00
Jonathan Frederic
ee7f5b8235 Move width auto into less 2014-03-21 13:19:45 -07:00
Jonathan Frederic
bca3fdc4b0 Remove commented line 2014-03-21 13:17:00 -07:00
Jonathan Frederic
bf65d5837f Finish implementing codemirror events 2014-03-21 13:15:30 -07:00
Jonathan Frederic
1f002cd456 Add displayed property.
and remove logs, commments, etc...
2014-03-21 12:05:02 -07:00
Jonathan Frederic
607b96b19a Actually remove the trigger keydown method 2014-03-20 18:45:06 -07:00
Jonathan Frederic
a2071db309 More progress... 2014-03-20 18:41:15 -07:00
Jonathan Frederic
b2ec594c76 Getting a lot closer... 2014-03-20 18:01:58 -07:00
Jonathan Frederic
23494f4ddd Set tabindex -1, use codemirror's events 2014-03-20 17:37:53 -07:00
Jonathan Frederic
f2c8de99ae Fix broken accordion widget,
Also clean-up the code some while visiting this file.
2014-03-20 16:52:56 -07:00
Jonathan Frederic
ae2b0800cf Partial fix of problems b/c keydown move 2014-03-20 16:11:01 -07:00
Jonathan Frederic
1b46a777fb Removed trigger keydown from keyboard.js,
also added a bunch of missing semicolons (jshint)
2014-03-20 16:11:01 -07:00
Jonathan Frederic
dc6355ffb7 Prevent tab key from bubbling when the completer is open 2014-03-20 15:57:26 -07:00
Min RK
0493027d7e Merge pull request #5403 from minrk/alt-shortcut-bad
remove alt-- shortcut
2014-03-20 15:00:41 -07:00
Brian E. Granger
e51030ea5f Merge pull request #5368 from jdfreder/specifity
Flexbox classes specificity fixes
2014-03-20 14:34:17 -07:00
MinRK
2041dc6563 widen modal dialogs on wide displays
needed for quick help layout with multiple meta keys
2014-03-20 14:12:09 -07:00
MinRK
840364ff71 use box-flex to layout quickhelp 2014-03-20 14:11:05 -07:00
MinRK
19c64f4b59 remove alt-- shortcut
replace with ctrl-shift--

alt is not safe for defaults
2014-03-20 14:10:44 -07:00
Brian E. Granger
9f1b26d860 Merge pull request #5331 from minrk/raw-input-css
fix raw_input CSS
2014-03-20 13:47:14 -07:00
Min RK
0ae0216b12 Merge pull request #5049 from ivanov/quickhelp-update
update quickhelp on adding and removing shortcuts
2014-03-20 12:39:42 -07:00
Paul Ivanov
35c861f583 fix MacOS specific shortcuts, thanks @minrk 2014-03-20 12:38:25 -07:00
Brian E. Granger
bfdbdd456c Merge pull request #5391 from jdfreder/netscape-keyboard
Fix Gecko (Netscape) keyboard handling
2014-03-20 12:35:52 -07:00
Paul Ivanov
c28096f0c5 prevent saving of partially loaded notebooks
closes #5363
2014-03-20 02:21:38 -07:00
Paul Ivanov
54d9eb4358 really fix the '-' key shortcuts now 2014-03-19 22:29:31 -07:00
Paul Ivanov
77bf4a72dd better handling of minus 2014-03-19 19:24:05 -07:00
Jonathan Frederic
a08fbff5d9 Fix Gecko (Netscape) keyboard handling 2014-03-19 16:36:11 -07:00
Paul Ivanov
21ebaf2e32 handle keyboard shortcuts ending with '-' 2014-03-19 16:24:53 -07:00
Paul Ivanov
4cf1717980 use - for shortcut separators 2014-03-19 15:58:59 -07:00
Paul Ivanov
083f631cde wider style for keyboard shortcuts 2014-03-19 12:44:12 -07:00
Min RK
d88b2ccc4a Merge pull request #5310 from ivanov/fix-5238
remove raw cell placeholder on focus, closes #5238
2014-03-19 12:21:03 -07:00
Min RK
5c5139b65d Merge pull request #5332 from ivanov/semantic-icons
semantic names for indicator icons
2014-03-19 12:20:07 -07:00
Paul Ivanov
c54ced12e5 Merge pull request #5360 from minrk/monospace
remove some redundant font-family: monospace
2014-03-19 11:25:12 -07:00
Paul Ivanov
2e4036fd4f raw cell placeholder text as one line 2014-03-19 10:42:11 -07:00
Paul Ivanov
37852baa6d render on focus out, always pad raw cells 2014-03-19 10:37:59 -07:00
Paul Ivanov
8a623dbcc4 fab css 2014-03-18 12:06:06 -07:00
Paul Ivanov
955d239d07 rename css class names to be consistent with current style 2014-03-18 12:03:43 -07:00
Paul Ivanov
a0a17fa04a capitalize keyboard shortcuts in the tour 2014-03-18 11:19:44 -07:00
Paul Ivanov
00603a11f6 remove stale modal dialog from the DOM 2014-03-18 11:16:56 -07:00
Fernando Perez
5f086fded2 Merge pull request #5372 from minrk/no-close-strings
Don't autoclose strings, because CodeMirror's behavior makes it confusing and awkward to type triple-quoted strings (and these are very common in Python).

An issue about this was filed in CodeMirror itself: https://github.com/marijnh/CodeMirror/issues/2385
2014-03-18 11:14:24 -07:00
MinRK
3c1fe84f52 Don't autoclose strings
CodeMirror doesn't do the right thing with triple-quoted strings,
so don't let it try.
2014-03-18 11:11:28 -07:00
Paul Ivanov
597a5cb741 don't color code in crimson
do alliterate, aforementioned color alternative alias is amaranth
2014-03-18 11:03:09 -07:00
Paul Ivanov
b9ef37ac26 semicolon fixes buttress half of my js commits 2014-03-18 10:31:51 -07:00
Min RK
e64c2cb5d8 Merge pull request #5296 from ivanov/more-shortcuts
unify keyboard shortcut and codemirror interaction
2014-03-18 09:46:07 -07:00
Paul Ivanov
0c366861c5 brief key event desription 2014-03-17 21:09:51 -07:00
Paul Ivanov
6d6e0fb007 fix up and down arrows in the top and bottom cells 2014-03-17 20:11:33 -07:00
Paul Ivanov
09866e0ee1 go to the beginning of the line when entering cell 2014-03-17 17:41:44 -07:00
Paul Ivanov
96848748de restore master behavior
up arrow at the top line first goes to char 0, and only goes to the cell
above if already on char 0. Same with down arrow on the bottom line:
transition cursor to the end of the line, and only go down a cell if
already at the end of the last line.

this makes for an unhappy experience in code-mirror's vim mode  for j
and k keys, but we'll fix that in the next commit
2014-03-17 16:21:23 -07:00
Paul Ivanov
8f17444c27 go to appropriate line when coming from another cell
Sets the cursor on the last line of the cell when moved up from the top
of the cell below, and sets the cursors to the first line when moving
down from the bottom of a last line.

Here, we retain the character that the cursor was on, so that users
wishing to have up-down functionality like one document can still use
this shortcut handler and simple adjust the at_top and at_bottom methods
2014-03-17 15:48:36 -07:00
Jonathan Frederic
2dd8757da7 Fab CSS 2014-03-17 10:44:29 -07:00
Jonathan Frederic
77904a044c Re-added already existing base for less backwards compatability. 2014-03-17 10:43:53 -07:00
Jonathan Frederic
0020b9f896 Fix specifity of flex modifier classes 2014-03-17 10:40:28 -07:00
MinRK
8e5937e993 remove some redundant font-family: monospace
`pre`, `code` tags already set the font-family in these contexts.
Setting it again in the surrounding context is redundant,
and causes inconsistency when embedding notebooks in HTML
(e.g. nbviewer).
2014-03-14 11:43:11 -07:00
Jonathan Frederic
d37ffe91b7 Fix status ind. icon bug 2014-03-14 11:40:54 -07:00
MinRK
89faa5f340 simplify raw_input css
for once, vertical-align: baseline is the right choice
2014-03-13 20:47:34 -07:00
MinRK
065a6eaa34 fix ambiguous raw_input classes 2014-03-13 20:45:54 -07:00
Paul Ivanov
61b47695e4 renamed 'use_shortcut' method to 'handles' 2014-03-13 16:44:19 -07:00
Paul Ivanov
d8287466d0 another doc fix 2014-03-13 16:40:37 -07:00
Paul Ivanov
f68dcc3e57 it's only half true that I'm anal about semicolons 2014-03-13 16:30:58 -07:00
Paul Ivanov
67fd905421 minor fixes to docs to address PR feedback 2014-03-13 16:29:28 -07:00
Paul Ivanov
469c70fd10 more semicolons 2014-03-13 16:23:27 -07:00
Jonathan Frederic
443083c1fd Added some comments 2014-03-13 14:34:17 -07:00
Paul Ivanov
1dc113a9cb closes #5336 2014-03-13 14:30:32 -07:00
Paul Ivanov
4142911ac7 better fix for starting with Command Mode icon 2014-03-11 18:58:46 -07:00
Paul Ivanov
12139b4d6e ensure ipython-command-mode icon displayed on load 2014-03-11 18:48:21 -07:00
Paul Ivanov
f0ae836f5f semantic names for kernel status indicator 2014-03-11 18:37:35 -07:00
Paul Ivanov
f5a02a02dd semantic names for indicator icons
For all of the discussion that we had about what kind of icons should
and should not be used to indicate what mode the notebook is in, we
never went through to make it possible to override it.

With this change, it is now possible to override what icons are
displayed for Command and Edit Modes.

For example, @minrk liked the fighter-jet icon for Command Mode, so he
can put this in his custom.css

.ipython-command-mode:before {
     content: "\f0fb";
}
2014-03-11 18:22:03 -07:00
MinRK
084aba793f fix raw_input CSS
I had to express padding in px, not em for consistent appearance.
I'm not sure why.
2014-03-11 14:45:37 -07:00
Paul Ivanov
4dd009f198 DRY: style in one place, removed code duplication 2014-03-11 00:53:15 -07:00
Jonathan Frederic
7762cb0ab3 Fixed a small bug/typo 2014-03-10 15:29:10 -07:00
Jonathan Frederic
e61b6aef47 Add logic to close tt when cell is unselected 2014-03-10 15:26:04 -07:00
Brian E. Granger
3eb654bd86 Merge pull request #5295 from minrk/no-append-prototype
OutputArea.append_type functions are not prototype methods
2014-03-10 14:13:14 -07:00
Paul Ivanov
b08665563d fix capitalization of mode-switching keys 2014-03-10 11:48:13 -07:00
MinRK
a24595d16b call append_text from append_map 2014-03-10 11:44:00 -07:00
Paul Ivanov
01c9be84d0 prettify combo keyboard shortcuts 2014-03-10 11:30:50 -07:00
Paul Ivanov
1c213bc615 first pass at capitalizing keyboard shortcuts 2014-03-10 11:13:18 -07:00
Jonathan Frederic
95492b0f42 Add illusion that cell is in edit mode when complete is up,
even though it is not in focus so it is not in edit mode.
2014-03-10 10:10:06 -07:00
Jonathan Frederic
65732920eb Remove all should cancel blur logic. 2014-03-10 09:46:59 -07:00
Jonathan Frederic
989ae4e1b3 Workaround for Tooltip & completer click focus bug. 2014-03-10 09:28:19 -07:00
MinRK
abe2dce926 back to dev 2014-03-09 21:58:09 -07:00