Commit Graph

11959 Commits

Author SHA1 Message Date
Min RK
672f0a6e20 nudge: handle failure cases
- connect iopub first (tiny effect on the race!)
- docstrings, log details
- resolve immediately if kernel is busy, rather than setting up timeouts, futures
- use gen.with_timeout instead of separately managed timeout
- use gen.multi to wait for both futures instead of duplicated check in each handler, third Future
- add various cancel conditions (sockets closed, kernel stopped, etc.)
2020-12-18 11:21:48 +01:00
Sylvain Corlay
94678545db Use transient shell channel, and do not nudge busy kernels 2020-12-17 15:28:50 +01:00
Min RK
f716328d90 relax busy/idle ordering on reconnect
nudge can leak idle messages, so it could be busy->idle, or idle->busy->idle.

The important thing is that we get at least one idle message
2020-12-17 13:27:49 +01:00
Sylvain Corlay
b4f5f6b4d4 Log nudge attempt count at warning-level if it keeps going up
Co-authored-by: Min RK <benjaminrk@gmail.com>
2020-12-17 13:27:02 +01:00
Sylvain Corlay
2c87813ef4 Add counter for nudge attempts 2020-12-15 18:32:35 +01:00
Sylvain Corlay
9770ef7760 Review: open is not a coroutine 2020-12-15 17:33:38 +01:00
Sylvain Corlay
7a3ae6e4a4 Nudge kernel with info request until we receive IOPub messages 2020-12-12 10:46:56 +01:00
Zachary Sailer
0c83c9d59f
Merge pull request #5889 from jmandreoli/patch-1
Added section for file editor configuration
2020-12-09 08:29:52 -08:00
Kevin Bates
c5a0f804f0
Merge pull request #5893 from mgeier/review-notebook-examples
example notebook: don't recommend using $$...$$ for display math
2020-12-09 08:14:09 -08:00
Kevin Bates
eb2b4c6a7f
Merge pull request #5896 from Zsailer/issue_template
Add an issue template and issue landing page.
2020-12-02 16:23:18 -08:00
Zsailer
13bc0d6a1c clearly distinguish this/that in issue template pointing at discourse 2020-12-02 11:45:20 -08:00
Zsailer
1a1bf7dfb2 add issue template 2020-12-02 11:37:10 -08:00
Matthias Geier
99adc0e5c4 example notebook: don't recommend using $$...$$ for display math 2020-12-01 17:34:21 +01:00
jmandreoli
9e62e2defe
Added section for file editor configuration
The doc shows how to update codemirror options for the notebook cell editor, but not for the whole file editor. I have added lines 51-62 to give that information. The information comes from Stack-Overflow (and has been tested), but it has been frustratingly long to find, so I think it is worth sharing ...
2020-11-29 16:51:28 +01:00
Kevin Bates
02024f0b9a
Merge pull request #5880 from mofanke/master
Update handlers.py Remove or correct this useless self-assignment
2020-11-23 06:45:11 -08:00
mofanke
af72fa1cc7
Update handlers.py
Remove or correct this useless self-assignment
2020-11-23 14:46:49 +08:00
Zachary Sailer
32bd47068b
Merge pull request #5874 from kevin-bates/port-sec-advisory
Apply security advisory fix to master
2020-11-18 11:08:32 -08:00
Min RK
e8459d97eb
Release 6.1.5 2020-11-18 10:14:34 -08:00
Min RK
ee64f5475d
changelog for 6.1.5 2020-11-18 10:13:09 -08:00
Min RK
1abd95130c
Validate redirect target in TrailingSlashHandler
Fixes open redirect vulnerability GHSA-c7vm-f5p4-8fqh
2020-11-18 10:13:08 -08:00
Zachary Sailer
5a73a8e402
Merge pull request #5870 from yuvipanda/authenticate-prometheus
Allow toggling auth for prometheus metrics
2020-11-17 13:21:31 -08:00
YuviPanda
c0ab18a534 Allow toggling auth for prometheus metrics
Equivalent to https://github.com/jupyterhub/jupyterhub/pull/2224

Prometheus metrics can potentially leak information about
the user, so they should be kept behind auth by default.
However, for many JupyterHub deployments, they would need
to be scraped by a centralized Prometheus instance that can not
really authenticate separately to each user notebook without
a lot of work. Admins can use this setting to allow unauthenticated
access to the /metrics endpoint.
2020-11-17 23:14:54 +05:30
Kevin Bates
cd7a06ce88
Merge pull request #5845 from bollwyvl/add-wasm-mime
Add wasm mimetype override
2020-11-04 08:04:12 -08:00
Zachary Sailer
57f8150ab9
Merge pull request #5847 from kevin-bates/restore-mac-ctrl-enter
Restore ctrl-enter shortcut behavior for macOS users
2020-11-04 07:32:23 -08:00
Nicholas Bollweg
c508af3cff add wasm mimetype 2020-11-03 22:34:30 -05:00
Kevin Bates
c893b59a9b
Restore ctrl-enter shortcut for mac users 2020-11-03 16:07:01 -08:00
Kevin Bates
72217183c8
Merge pull request #5826 from pgajdos/denose
do not require nose for testing
2020-10-29 07:17:14 -07:00
pgajdos
30a716fb85 remove redundant print statements 2020-10-29 08:53:35 +01:00
Kevin Bates
8a53994144
Merge pull request #5823 from rjn01/master
[docs] Update Chinese and Hindi readme.md
2020-10-27 11:58:00 -07:00
pgajdos
3e7f4b9518 ipython_genutils requires nose 2020-10-26 12:39:03 +01:00
pgajdos
2e8c3159e5 fix pytest argument 2020-10-23 12:59:15 +02:00
pgajdos
fdf14b4ab3 run tests with pytest 2020-10-23 11:45:28 +02:00
pgajdos
ec3c3dd89e fix one more function 2020-10-22 15:59:20 +02:00
pgajdos
1c3dbcc6bf do not use nose for testing 2020-10-22 15:34:17 +02:00
rjn01
11b317a1e9
update zh-CN/README.md 2020-10-21 04:43:45 +05:30
rjn01
81246861e8
update zh-CN/README.md and hi-IN/README.md 2020-10-21 04:34:55 +05:30
rjn01
30fb63bbf4
update zh-CN/README.md 2020-10-21 04:13:20 +05:30
rjn01
e894230bd0
Update hi-IN/Readme.md 2020-10-21 03:13:28 +05:30
Kyle Kelley
87aa278971
Merge pull request #5813 from kevin-bates/http-new-terminal
Add support for creating terminals via GET
2020-10-19 15:16:26 -07:00
Kevin Bates
c297a01758
Merge pull request #5787 from virejdasani/master
Made doc translations in Hindi and Chinese
2020-10-19 07:53:53 -07:00
virejdasani
3cfe512417 Update Chinese docs 2020-10-18 15:19:08 +05:30
virejdasani
b6699d8b7e Update Hindi translations 2020-10-17 12:50:18 +05:30
Kevin Bates
639da8d813
Add separate handler for /terminals/new 2020-10-15 15:42:55 -07:00
Kevin Bates
84ba421e86
Create auto-named terminals via /terminals/new 2020-10-15 14:58:19 -07:00
Kevin Bates
7778dc3202
Allow for redundant accesses of same endpoint 2020-10-14 14:57:57 -07:00
Kevin Bates
ac50d2e530
Add support for creating terminals via GET 2020-10-14 10:07:23 -07:00
Kevin Bates
1550410229
Merge pull request #5799 from mriedem/5798-json-logging
Add support for JSON formatted logs
2020-10-13 18:26:25 -07:00
Kevin Bates
545dbab070
Merge pull request #5807 from rahulporuri/cln/remove-dead-code
Remove code for unsupported python versions
2020-10-13 18:25:29 -07:00
Kevin Bates
18e4834b12
Merge pull request #5806 from rahulporuri/cln/update-super-usage
Update super usage
2020-10-13 16:27:34 -07:00
Matt Riedemann
67ad5a1c06 Merge remote-tracking branch 'origin/master' into 5798-json-logging 2020-10-13 18:21:02 -05:00