ednut15
99ad777942
Solved issue #4009
2019-06-19 16:07:14 +01:00
韩韬
5f04881be4
fix issue #4002
2019-06-19 15:58:55 +01:00
Joshua Zeltser
287f7b6f02
Merge branch 'issue-acc-overwrite' of https://github.com/uclixnjupyternbaccessibility/notebook into issue-acc-overwrite
2019-06-19 15:54:45 +01:00
Norah Abanumay
8cfb5a3435
#3984 Keyboard focus is clearly visible on the Controls(File,Edit,View,Insert,Cell...etc)present on the menubar.
2019-06-19 15:54:27 +01:00
韩韬
7fc284eda0
Solved Issues #3963 and #3960
2019-06-19 15:39:06 +01:00
ednut15
d8df52b267
Solved Issue #3997
2019-06-19 15:31:19 +01:00
ednut15
b5b494d2ad
#3996 Added role attribute with value button to the element
2019-06-19 15:18:11 +01:00
Joshua Zeltser
a76a3e6cce
added new span to new button to cause narrator to mention it is a dropdown
2019-06-19 11:58:31 +01:00
Joshua Zeltser
80158d81c9
Removed unnecessary edit
2019-06-19 11:42:18 +01:00
fabihaahmed
3b239afcda
Fixes issue #3998 , #3971 and #3968
2019-06-19 11:35:21 +01:00
Joshua Zeltser
6953e4d704
fixed issue 3970 giving upload button an aria-label
2019-06-19 11:26:51 +01:00
韩韬
f8727352ec
fix #issue3961
2019-06-19 10:55:19 +01:00
Joshua Zeltser
24d2c6026f
#3941 : narrator now reads labels of textareas in popups
2019-06-19 10:46:06 +01:00
Joshua Zeltser
9b1fa3d66b
#3938 : solved this issue, but more checking needs to be done to see whether this is sufficient
2019-06-19 10:39:19 +01:00
Joshua Zeltser
f660f037e4
Fixed bug in bower setup
2019-06-18 22:29:05 +01:00
韩韬
ed23e65def
fix issue #3999 , #4001 , #4003 , #3988 , #3987
2019-06-18 21:50:49 +01:00
Joshua Zeltser
42ba2b0a40
Removed extra lines
2019-06-18 18:30:32 +01:00
Joshua Zeltser
37d795e591
Solved Issue 4015
2019-06-18 18:08:56 +01:00
Ashton Reimer
dd0f5d2608
bfix: shutdown_server returns True when pid exists
...
`check_pid` returns `True` if the PID for a notebook server still exists. Therefore, the `if check_pid(pid):` statements on lines 424 and 437 evaluate to `True` even though the notebook server is still running.
This commit simply adds a `not` to each line: `if not check_pid(pid):` so that the conditional only evaluates to `True` if `check_pid` returns `False`, which happens when the notebook server has shutdown, as expected.
2019-06-13 15:36:45 -07:00
Johan Mabille
61ae2d6778
Added control channel to ZMQChannelsHandler
2019-06-12 17:16:11 +02:00
Tim
6174498ab0
Add id for command palette button group ( #4661 )
2019-06-07 11:20:33 +01:00
Pierre Tholoniat
922e97922c
Fix French typo ( #4651 )
...
Corrected "Échec de la connection" to "Échec de la connexion"
2019-06-07 11:17:18 +01:00
Abhinav Sagar
bc920e9879
.travis.yml: The 'sudo' tag is now deprecated in Travis CI ( #4654 )
2019-06-07 11:16:09 +01:00
Min RK
a403d59cb0
Merge pull request #4642 from betatim/js-redirect
...
Use JavaScript to redirect users
2019-05-28 07:46:02 +02:00
Tim Head
077322dcd9
Use JavaScript to redirect users
2019-05-27 15:35:09 +02:00
Min RK
a33f4c60b1
Merge pull request #4591 from dalanicolai/patch-1
...
Update Working With Markdown Cells.ipynb
2019-05-24 15:23:32 +02:00
Thomas Kluyver
9425250005
Merge pull request #4588 from t-makaro/downloadas
...
fix duplicates in download as menu
2019-05-19 11:39:08 +02:00
Thomas Kluyver
9237c3732e
Merge pull request #4615 from LuisARodr/dualmode_execute
...
Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium
2019-05-19 11:29:38 +02:00
Tyler Makaro
1ae7838227
exporter naming scheme
2019-05-17 12:20:41 -07:00
Luis Rodriguez
cd2ea150a0
Refactor for
...
Changed 'for mode in cells_mode' for 'for i, mode in
enumerate(cells_mode)'
Removed the manual 'i' increment and declaration.
2019-05-17 09:11:11 -07:00
Luis Rodriguez
799b8be841
Move repeated assert mode
...
Moved 'assert mode == keyboard_mode' ouside the branches.
This means that if a unknown mode comes its gonna get catched by the
assert and never gona get to the else statement.
For this, the else stament moved to before the assert, caching the mode
error before the assert.
2019-05-17 09:03:15 -07:00
Tyler Makaro
6876f74c6d
moved hard coded exporters
2019-05-16 16:27:26 -07:00
Luis Rodriguez
6679891464
Give space to inline comments
2019-05-16 09:31:22 -07:00
Luis Rodriguez
6b7d179697
Change assert for Exception
2019-05-16 09:28:00 -07:00
Luis Rodriguez
83b3c19de3
Solve insonsistensy on is_focused_on
...
Changed asserts for returns
Changed how the function is called on edit mode check
2019-05-16 09:12:10 -07:00
Luis Rodriguez
b294bf57f8
Refactor of ifs
...
Removed parentheses
Changed '==' for 'is' on None
2019-05-16 09:04:58 -07:00
Luis Rodriguez
c276d81914
Update docstring
...
Added more information about what the checks are
2019-05-16 09:00:49 -07:00
Thomas Kluyver
8ae0c047a9
Merge pull request #4617 from TeresaPartidaS/convert_multiselect_toggle_js_to_selenium
...
Migrate multiselect toggle test to selenium
2019-05-16 09:36:59 +01:00
TPartida
8749a5db99
Modified 'scrolling enabled' test assert
2019-05-15 15:01:40 -07:00
Luis Rodriguez
3a0cb7b113
Refactor validate_dualmode_mode
...
Previously know as validate_notebook_mode changed name to
validate_dualmode_mode to represent better the method.
Added a docstring.
Removed the handling of index being None.
2019-05-15 13:36:44 -07:00
Luis Rodriguez
fccc7d7420
Resolve notebook len duplicate method
2019-05-15 08:32:06 -07:00
Thomas Kluyver
69b7a1d204
Merge pull request #4623 from mtd91429/patch-1
...
Make tooltip buttons have consistent appearance
2019-05-15 12:53:02 +01:00
Thomas Kluyver
93099010ff
Merge pull request #4608 from LuisARodr/dualmode_tests
...
Convert dualmode_cellmode to selenium
2019-05-15 11:06:28 +01:00
mtd91429
cf1a76441c
Make tooltip buttons have consistent appearance
...
Change class of `expandlink` from `ui-corner-all` to `ui-button` to be consistent with `morelink` and `closelink`
2019-05-11 19:18:50 -04:00
TPartida
3f2fff21b0
Remove multiselect_toggle js
2019-05-09 11:59:38 -07:00
TPartida
c674a57955
Convert multiselect_toggle to selenium
2019-05-09 11:58:49 -07:00
Luis Rodriguez
849b7def18
Convert dualmode_markdown to selenium
2019-05-08 12:30:11 -07:00
Luis Rodriguez
ecc27953e3
Remove unused import & refactor
2019-05-08 11:19:10 -07:00
Luis Rodriguez
9158a79ec4
Convert dualmode_execute to selenium
2019-05-08 11:08:31 -07:00
Luis Rodriguez
5b162cfdf9
Convert dualmode_clipboard to selenium
2019-05-08 11:08:09 -07:00
