Commit Graph

834 Commits

Author SHA1 Message Date
Fernando Perez
5067e77292 Merge pull request #1334 from fawce/keycuts
Make Control-S (or Cmd-S on Apple) save the actual notebook instead of bringing up the useless 'save as html' dialog.  This doesn't disable the C-m-s keybinding, simply adds the far more familiar and common C-s.
2012-01-28 16:39:06 -08:00
Fernando Perez
aaae3b5be7 Merge pull request #1335 from ellisonbg/nbtoolbar
Add a toolbar with icons to the notebook interface.  There are for now icons for the most important actions, we will slowly consider the addition of new ones later as necessary.  But this should make everyday usage much more fluid for mouse-based users.

The new toolbar and the header bar have also been made collapsible, which allows users to have a very compact view with only minimal vertical space devoted to the UI and most of the screen available as usable work space.
2012-01-27 23:57:48 -08:00
Brian Granger
1ed9a21039 Adding "Cell" to cell related Edit actions. 2012-01-27 16:16:22 -08:00
Brian Granger
9b723324db Wired the rest of the toolbar buttons up to actions. 2012-01-27 13:54:37 -08:00
Brian Granger
428c82877f Further work on the toolbar UI.
* Cell type selection box is wired up and styled.
* New View menu that allows toolbar/header to be toggled.
2012-01-27 13:45:43 -08:00
Brian Granger
4c88c4686c First draft of toolbar.
We are adding a thin horizontal toolbar below the menubar. This
commit adds the basic UI elements. Still need to hook up the actions
and make this hidable.
2012-01-27 12:31:28 -08:00
fawce
7bf330fc99 backed out change to gitignore 2012-01-27 14:50:39 -05:00
fawce
a53def4a49 fixed missing return for keybinding 2012-01-27 14:49:39 -05:00
fawce
6120c07c4d added key handler for control-s to notebook, seems to work pretty well 2012-01-27 14:18:48 -05:00
Fernando Perez
63133e0c4d Merge pull request #1328 from ipython/coverage
Add XML coverage support to the test suite with new --with-xml-coverage flag.  The resulting XML output files are understood by Jenkins, so now our automated test suite will have coverage reports.
2012-01-27 03:31:32 -08:00
Thomas Kluyver
717285060e Use explicit for loop to find section in testing. 2012-01-27 11:16:35 +00:00
Thomas Kluyver
4b51bacbb2 Don't raise errors from coverage post-processing. 2012-01-27 01:16:46 +00:00
Thomas Kluyver
93a8b9d215 Use separate option --with-xml-coverage to ask for coverage xml output. 2012-01-27 01:16:46 +00:00
Thomas Kluyver
24af9ac298 Use standard command for coverage. 2012-01-27 01:16:46 +00:00
Thomas Kluyver
e29d417931 Produce coverage xml reports from subprocess test runners. 2012-01-27 01:16:46 +00:00
Min RK
125dc8cb74 Merge pull request #1206 from minrk/fixConsole
The notebook js transforms ANSI-escaped text to HTML.  The transformed HTML was previously persisted to ipynb files, rather than the true output.  This has been fixed, and notebooks with ANSI-colored output will need to be re-run for colored output (tracebacks) to be displayed correctly after this change.
2012-01-26 17:14:29 -08:00
Brian E. Granger
91745493f1 Merge pull request #1330 from fperez/linewrap
Add linewrapping to text cells (new feature in CodeMirror).
2012-01-26 14:07:30 -08:00
Fernando Perez
df7d91f30a Add linewrapping to text cells (new feature in CodeMirror). 2012-01-25 22:17:12 -08:00
Fernando Perez
ef1cc56996 Merge pull request #1327 from ellisonbg/updatecm2
Updating CodeMirror to the latest dev master. 

We had found a bug in CodeMirror that was forcing us to call refresh/focus/refresh on Firefox. This bug was fixed upstream. This PR pull in the latest CM with the bug fix and removes the extra refresh calls. All known CM bugs should be fixed, yeh!
2012-01-25 22:16:13 -08:00
Fernando Perez
219ba77482 Merge pull request #1326 from ellisonbg/removeace
Removing Ace edit capability.

We have fixed some of the problems with CodeMirror and feel that
the differences between Ace and CodeMirror are not great enough
to justify having both. We may reintroduce a full-window edit
mode using CodeMirror, but that will come separately.
2012-01-25 20:30:36 -08:00
Fernando Perez
1d5c57d6c9 Remove debug print statement left over from PR #1316. 2012-01-25 19:43:14 -08:00
Brian Granger
0bc0c560aa Removing extra refresh that is no longer needed because of CM fix. 2012-01-25 14:03:49 -08:00
Brian Granger
262d73f652 Updating CodeMirror to latest to incorporate bug fixes. 2012-01-25 13:46:48 -08:00
Brian Granger
c29e928054 Removing Ace edit capability.
We have fixed some of the problems with CodeMirror and feel that
the differences between Ace and CodeMirror are not great enough
to justify having both. We may reintroduce a full-window edit
mode using CodeMirror, but that will come separately.
2012-01-25 12:32:06 -08:00
Brian E. Granger
b14f30c8f1 Merge pull request #1325 from Carreau/fix-tooltip-showpager
forgotten selected_cell -> get_selected_cell
2012-01-25 12:20:40 -08:00
Matthias BUSSONNIER
7e268d8ec8 execute_get_cell -> execute_cell
wrongly rename execute_cell leading to broken execute_all_cell
2012-01-25 15:15:52 +01:00
Matthias BUSSONNIER
8ad0cbe4c0 forgotten selected_cell -> get_selected_cell
somwhere in renaming `selected_cell` to `get_selected_cell` one
occurence has been forgoten in `codecell.js` this was mainly visible by
the fact that the 'show pager' button of the tooltip was non fonctionnal
anymore.
2012-01-25 14:47:15 +01:00
Fernando Perez
236f4dd401 Merge pull request #1316 from ipython/xunit2
Pass subprocess test runners a suitable location for xunit output.  This enables our Jenkins instance at Shining Panda to display a proper summary instead of just a raw console log.
2012-01-24 18:11:57 -08:00
Thomas Kluyver
b01e9ea082 Pass subprocess test runners a suitable location for xunit output. 2012-01-24 21:23:58 +00:00
Brian E. Granger
d8e1b38507 Merge pull request #1303 from ellisonbg/updatecm
This updates CodeMirror and refactors a good bit of the notebook code related to it.

* Updated CodeMirror to the latest stable release.
* Fix numerous bugs related to the CM update.
* Refactored the Cell API and the notebook's cell handling methods.
* Generalized split/merge to work with all cell types.
* Generalized "Edit in Ace" to work with all cell types.
* Loading optimizations: pager starts out hidden, faster loads.
* Shading added to Markdown and HTML cells when they are being edited.
* This branch will require solid usability testing on Safari, FF and Chrome before merging.
* Fixed a number of CM related bugs.
2012-01-23 19:29:53 -08:00
Brian Granger
d3c3c9e712 Fixing auto-indent issues in CodeMirror config.
* Block-level indent/dedent works.
* Tab in docstrings works.
2012-01-23 19:27:18 -08:00
Brian Granger
5947849342 Fixing broken notebook saves. 2012-01-23 19:00:25 -08:00
Brian Granger
c94e6f34d7 Disallow empty notebook names. 2012-01-23 15:36:01 -08:00
Min RK
ea354ad249 Merge pull request #1312 from minrk/hb
two small heartbeat changes:

* flush outgoing heartbeats (notebook and parallel):
  - Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

* relax default heartbeat period in IPython.parallel to 3s from 1s
  - Matches heartbeats elsewhere.  3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues).

closes #1304
2012-01-23 14:14:18 -08:00
MinRK
370078020f flush outgoing heartbeats
Prevents mismatch between heartbeat timer and actual heartbeat send/recv events.

Applied in notebook and parallel.
2012-01-23 13:42:00 -08:00
Brian Granger
244ed795d3 Adding refresh/focus/refresh back to edit to fix bug in FF. 2012-01-23 11:56:07 -08:00
Brian Granger
e6e7d41f5b Fixing bugs in CodeMirror refreshing. 2012-01-23 11:33:02 -08:00
Brian Granger
1e2e086508 Optimizing notebook loading. 2012-01-23 11:33:01 -08:00
Brian Granger
bf0353ae47 Start the pager out collapsed. 2012-01-23 11:33:01 -08:00
Brian Granger
a997e50782 Ace editor now works with Markdown and HTML cells with proper modes. 2012-01-23 11:33:01 -08:00
Brian Granger
68fe221a29 Lots of small notebook improvements.
* Merge/split works for all cell types.
* Notebook.select won't select an already selected cell.
* Bugs in markdown cell editing fixed.
* border-box-sizing used for Markdown cells to get correct css boxes.
* Shading/border added to Markdown cell editor.
2012-01-23 11:33:01 -08:00
Brian Granger
ecfdfad2bf Refactoring of the notebooks cell management.
* Cell insertion code completely rewritten. We now have two methods
  rather than 9: insert_cell_above, insert_cell_below.
* Renaming methods to be more consistent.
* Creating new methods to provide a uniform API.
* Minor bug fixes.
2012-01-23 11:33:01 -08:00
Brian Granger
ccd4de93c7 Updating cell logic.
* Added placeholder to the base Cell class.
* Removed the \u0000 char at the beginning of the TextCell
  placeholder that was there for a CodeMirror bug workaround.
* Other refactoring of Cell related Notebook methods.
2012-01-23 11:33:01 -08:00
Brian Granger
e1a8835dfa Work on the base Cell API.
* Added set_text/get_text in favor of get_code/set_code and
  get_source/set_source.
* Added methods to the base class (get_text, set_text, refresh,
  edit, render, toJSON, fromJSON).
2012-01-23 11:33:01 -08:00
Brian Granger
deb800daff Fixing bugs that have shown up since updating CM to 2.2. 2012-01-23 11:33:01 -08:00
Brian Granger
13ca0054f7 Updating to CodeMirror 2.2, latest stable release. 2012-01-23 11:33:01 -08:00
Fernando Perez
0051df30f3 Merge pull request #1301 from nathan-rice/master
Require pyreadline 1.7.1 on Windows, which fixes a number of small problems for which we had workarounds.

Closes #1202.
2012-01-20 17:20:19 -08:00
Nathan Rice
74b1c7d61e pyreadline dependency pushed to 1.7.1 for all versions of windows. Also, solves an issue that has been observed when IPython is used with some older versions of pyreadline. 2012-01-20 13:21:36 -05:00
Brian Granger
5d303263b2 Merge branch 'issue1290' 2012-01-19 09:47:15 -08:00
Brian Granger
1b8b716b48 Removing left over console.logs. 2012-01-19 09:47:05 -08:00