Commit Graph

266 Commits

Author SHA1 Message Date
Thomas Kluyver
963921c4ff Merge pull request #6832 from minrk/request-only-once
actually send only one kernel_info request
2014-11-03 10:37:17 -08:00
Min RK
525f6a7561 fix backward f, nb args for nbformat.write 2014-11-01 16:41:13 -07:00
MinRK
7cf53c998c restore ability to sign v3 notebooks 2014-11-01 16:41:13 -07:00
MinRK
af735018f3 don't use nbformat.current in IPython.html
use top-level nbformat.read/write, v4 directly for compose
2014-11-01 16:41:11 -07:00
MinRK
12f94ae2a2 use from_dict for dict->notebook
not confusing to_notebook_json
2014-11-01 16:41:09 -07:00
MinRK
dd95b1ef5f remove heading cells in v4 2014-11-01 16:41:07 -07:00
MinRK
07079095a8 update html/js to nbformat 4 2014-11-01 16:41:02 -07:00
Min RK
3e82ea8319 actually send only one kernel_info request
store the Future for the initial request,
allowing subsequent requests to wait on the same pending reply.

Previously, any incoming requests that arrived while waiting for the first reply would send their own request.
2014-11-01 13:38:55 -07:00
Min RK
e329a79bc8 language is removed from kernel specs
don't use it when testing kernel spec API
2014-10-31 15:09:51 -07:00
Min RK
a2575af6a7 log kernel specs that fail to load 2014-10-31 15:03:30 -07:00
Min RK
e5b135a905 debugging websocket connections
- add debug statement at the very beginning of a web socket request
- add debug statement in open, indicating that the connection has been accepted
- add timeout, so failed or slow kernel_info doesn't cause the request to never get a response
- don't send kernel_info_request before authenticating the request

The last one required some icky coroutine shenanigans,
because of our subclass structure, but it should work fine.
2014-10-29 09:17:52 -07:00
MinRK
a5a43e2746 Don't resend kernel info requests if a bad reply is received 2014-10-26 19:06:48 -07:00
MinRK
94d6196ef9 add websocket workarounds for tornado 3
WebSocketHandler.get is new in tornado 4
2014-10-26 19:06:48 -07:00
MinRK
769fe38789 cache kernel_info reply for protocol adaptation
WebSocket connections will not open until kernel_info is retrieved,
removing a race condition waiting for the reply to indicate adaptation,
which could result in a v5 message being sent to a v4 kernel.
The reply is cached, so that it need not be requested on each new connection.
2014-10-26 14:48:55 -07:00
MinRK
3693ac83ae support binary message from javascript 2014-10-15 12:23:32 -07:00
MinRK
c9c131ebf9 s/unserialize/deserialize 2014-10-15 12:23:32 -07:00
MinRK
7da61bfc13 use default kernel name in kernels service
matches sessions API
2014-10-12 14:59:03 -07:00
MinRK
624f0071a2 remove on_first_message authentication
in ZMQStreams. No need for weird, special first message.

- use regular cookie auth
- use url param for session id
2014-10-09 15:12:20 -07:00
Matthias Bussonnier
b2a0798fdf Merge pull request #6598 from minrk/nbformat-backport
nbformat validation
2014-10-09 11:58:56 +02:00
Matthias Bussonnier
7d7b85a043 Merge pull request #6649 from minrk/302-notebooks
redirect /api/notebooks to /api/contents
2014-10-09 10:52:48 +02:00
MinRK
b87fee048c redirect /api/notebooks to /api/contents
eases 2.x-3.x transition for consumers such as emacs-ipython-notebook
2014-10-08 12:33:43 -07:00
MinRK
b2d946d44e don't convert notebooks on upload 2014-10-08 12:33:34 -07:00
MinRK
8392c7ac9e don't check_and_sign old notebooks on upload 2014-10-08 12:33:34 -07:00
MinRK
4ae05c729c trust is stored in code_cell.metadata
not top-level code_cell
2014-10-08 12:33:33 -07:00
MinRK
ddd3aa2a5a add dialogs for failed save/load
- failed validation doesn't prevent save/load,
  but the user is now warned about it.
- there is now a warning dialog if fromJSON fails,
  rather than the usual silent failure.
2014-10-08 12:33:32 -07:00
Jessica B. Hamrick
d606d53b4e More informative error messages 2014-10-08 11:30:30 -07:00
Matthias Bussonnier
e808d23594 Merge pull request #6607 from minrk/cluster-load-remove
remove deleted profiles from cluster list
2014-10-05 11:45:58 +02:00
MinRK
ee1d9d65f3 stop using deprecated DelayedCallback
in favor of simpler IOLoop.add_timeout

It was added in pyzmq, but deprecated in pyzmq-13.
2014-10-03 12:05:23 -07:00
MinRK
1f231f7b5a remove deleted profiles from cluster list 2014-10-03 11:36:19 -07:00
Jessica B. Hamrick
6bc5702398 More descriptive short message 2014-09-30 12:21:01 -07:00
Jessica B. Hamrick
46e40e5ea1 Return a proper JSON object 2014-09-30 10:50:09 -07:00
Jessica B. Hamrick
5e1e8a116c Use 501 error code instead of 400 2014-09-30 10:50:09 -07:00
Jessica B. Hamrick
c4a89cd54d Better user experience when kernel isn't found 2014-09-30 10:50:09 -07:00
Jessica B. Hamrick
cfc234dc89 Handle NoSuchKernel errors more gracefully 2014-09-30 10:50:08 -07:00
MinRK
974d45343e allow kernel_name to be undefined in requests
fallback to KM.default_kernel_name in that case
2014-09-27 15:16:42 -07:00
MinRK
5bc118fb6c handle system-wide kernelspecs
in html tets_kernelspecs_api, which can cause counts to be greater than 2
2014-09-10 14:30:44 -07:00
Matthias Bussonnier
97e99d0661 Merge pull request #6412 from takluyver/sessions-rest-api-fix
Sessions rest api fix
2014-09-06 15:04:13 -07:00
Thomas Kluyver
fa6056e9ed Sort directory contents in test before assertion
Should fix recent test failures, but I can't replicate failure on my
computer, so it's not clear that it's fixed.
2014-09-05 18:44:58 -07:00
Thomas Kluyver
b2737e668e Add tests and fix some issues
Tests taken from #6360
2014-09-05 10:16:37 -07:00
Thomas Kluyver
0e109ee4be Correct comment 2014-09-05 09:40:02 -07:00
Thomas Kluyver
ca8dabf705 Fix 404 error when accessing nonexistant session 2014-09-04 15:13:59 -07:00
Thomas Kluyver
76b05b24af Handle sessions where the kernel has been killed 2014-09-04 15:13:59 -07:00
Thomas Kluyver
81b06d81a1 Merge pull request #6358 from minrk/contents-missing
fix directory listing with broken symlinks
2014-09-04 14:43:45 -07:00
Min RK
fbae96f9cb Merge pull request #6269 from takluyver/atomic-save
Implement atomic save
2014-09-02 10:59:38 -07:00
MinRK
819c3c326c fix directory listing with broken symlinks
directory listing would 404 if any listed file doesn't exist
(e.g. symlink to missing target).

Previously-failing test included.
2014-08-26 09:12:54 -07:00
MinRK
bd5a88e954 handle undefined or closed zmq_stream in on_message
can happen if a message is waiting in a pipe and the web socket is closed before the message is handled.

And give ZMQChannels a nice repr with their kernel ID
2014-08-13 21:51:52 -07:00
Thomas Kluyver
8b7d4c1c2f Rework atomic_writing with tests & docstring 2014-08-05 10:50:09 -07:00
Thomas Kluyver
04cbce2a14 Implement atomic save
Ping @fperez, this should avoid issues with corrupted/lost notebooks
when the disk is full, though I haven't worked out how to test it just
yet.

Closes gh-6254
2014-08-04 11:22:42 -07:00
MinRK
3e79eea46b update contents per further review
- fix is_hidden always returning True on nonexistent files
- create hidden dir fails with 400
- don't read binary files twice
- logging improvements
- dialog on invalid notebook upload
- warn about disabled `--save`
2014-07-31 11:57:38 -07:00
MinRK
3c26b079f0 updates per review
- clarified docstrings and errors
- still more notebook/file renames
- configurable untitled names
- copy_from can be full path
- fix running, upload, new-tab behaviors in dashboard

Yay, review!
2014-07-31 11:57:38 -07:00