Commit Graph

20 Commits

Author SHA1 Message Date
Min RK
39041a9f03 address review in contents service
- various docstrings, comments clarified and updated
- misc typos
- fix and test creating an untitled directory via POST
- only define `message` if there's something to say
2014-11-10 14:02:21 -08:00
MinRK
3ada0c2c27 Remove separate 'path', 'name' in Contents API
- path is full path (including name)
- name is only used for read-only convenience, and plays no role in any API
- remove 'untitled upload' (POST with content and no path)
2014-11-10 14:02:18 -08:00
Min RK
525f6a7561 fix backward f, nb args for nbformat.write 2014-11-01 16:41:13 -07:00
MinRK
af735018f3 don't use nbformat.current in IPython.html
use top-level nbformat.read/write, v4 directly for compose
2014-11-01 16:41:11 -07:00
MinRK
12f94ae2a2 use from_dict for dict->notebook
not confusing to_notebook_json
2014-11-01 16:41:09 -07:00
MinRK
dd95b1ef5f remove heading cells in v4 2014-11-01 16:41:07 -07:00
MinRK
b2d946d44e don't convert notebooks on upload 2014-10-08 12:33:34 -07:00
MinRK
ddd3aa2a5a add dialogs for failed save/load
- failed validation doesn't prevent save/load,
  but the user is now warned about it.
- there is now a warning dialog if fromJSON fails,
  rather than the usual silent failure.
2014-10-08 12:33:32 -07:00
Thomas Kluyver
81b06d81a1 Merge pull request #6358 from minrk/contents-missing
fix directory listing with broken symlinks
2014-09-04 14:43:45 -07:00
MinRK
819c3c326c fix directory listing with broken symlinks
directory listing would 404 if any listed file doesn't exist
(e.g. symlink to missing target).

Previously-failing test included.
2014-08-26 09:12:54 -07:00
Thomas Kluyver
8b7d4c1c2f Rework atomic_writing with tests & docstring 2014-08-05 10:50:09 -07:00
Thomas Kluyver
04cbce2a14 Implement atomic save
Ping @fperez, this should avoid issues with corrupted/lost notebooks
when the disk is full, though I haven't worked out how to test it just
yet.

Closes gh-6254
2014-08-04 11:22:42 -07:00
MinRK
3e79eea46b update contents per further review
- fix is_hidden always returning True on nonexistent files
- create hidden dir fails with 400
- don't read binary files twice
- logging improvements
- dialog on invalid notebook upload
- warn about disabled `--save`
2014-07-31 11:57:38 -07:00
MinRK
3c26b079f0 updates per review
- clarified docstrings and errors
- still more notebook/file renames
- configurable untitled names
- copy_from can be full path
- fix running, upload, new-tab behaviors in dashboard

Yay, review!
2014-07-31 11:57:38 -07:00
MinRK
bec995aa63 updates per review
a few more notebook mentions in docstrings,
and inappropriate use of setdefault.
2014-07-31 11:57:37 -07:00
MinRK
93b300adda support deleting empty directories
can’t copy directories
2014-07-31 11:57:37 -07:00
MinRK
260afd76ae contents service review
- missed some s/notebook/file/ in docstrings
- manager doesn’t sort contents
2014-07-31 11:57:37 -07:00
MinRK
8c4069cc00 add support and tests for uploading and saving regular files 2014-07-31 11:57:36 -07:00
MinRK
0c0eb43719 teach contents service about non-notebook files 2014-07-31 11:57:36 -07:00
MinRK
6cce477e07 rename notebooks service to contents service
minimal functional changes, committing because tests are passing.
2014-07-31 11:57:36 -07:00