Commit Graph

11279 Commits

Author SHA1 Message Date
Maitiu O Ciarain
0827dcb0b5 Fix quotes and tidy up the help messages 2018-08-07 10:52:35 +01:00
Maitiu O Ciarain
090f9c2314 Correctly pass them to the underlying tornado server 2018-08-07 09:26:12 +01:00
Maitiu O Ciarain
a37404f6b9 Make the max_body_size & max_buffer_size configurable 2018-08-07 09:25:00 +01:00
Gabriel
268332dde2
update codemirror component to 5.37
This should fix f string syntax highlighting 
https://github.com/jupyter/notebook/issues/2037
2018-08-02 14:12:43 -04:00
Min RK
b94cc449db
Merge pull request #3712 from forbxy/master
fix:can't choose same file twice when in upload file
2018-08-01 13:11:44 +02:00
Min RK
237a31060e
Merge pull request #3784 from gnestor/inline-run-button
Fix uneven input prompt width for markdown cells
2018-08-01 13:01:38 +02:00
Min RK
e33a16f42f use localhost as default local hostname
so this list isn't empty when these handlers are used outside NotebookApp
2018-07-31 14:02:12 +02:00
Min RK
1901eeac63 ip_address only accepts unicode on Python 2
ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2

need to decode it, otherwise 127.0.0.1 won't be treated as local
2018-07-31 13:51:24 +02:00
Matthias Bussonnier
593bd40895
Merge pull request #3806 from aaronchall/patch-2
indent code block
2018-07-30 16:54:23 -07:00
Aaron Hall, MBA
b644d7ee40
indent code block 2018-07-30 12:49:34 -04:00
Min RK
ceaf1c1158
Merge pull request #3778 from beledouxdenis/master-get_secure_cookie_options
[FIX] notebookapp, auth: `get_secure_cookie` kwargs
2018-07-30 10:09:34 +02:00
Min RK
1d17c796d0
Merge pull request #3799 from aaronchall/patch-1
Fill in Checkpoints section
2018-07-30 10:04:27 +02:00
Thomas Kluyver
f5a34179dc
Merge pull request #3800 from Xctrunner/master
fixing grammatical errors and typos
2018-07-27 16:43:37 +01:00
Aaron Hall, MBA
251c9e7dc8
Fill in Checkpoints section
(I think it needs more complete examples like ContentsManager has regarding what is returned by these methods.)
2018-07-26 13:51:58 -04:00
Walter Martin
ecc4d26f1d fixing grammatical errors and typos 2018-07-24 21:01:51 -04:00
Madicken Munk
f9d578ee40 add pytest to test env requirements and suggest it in contributing docs 2018-07-20 16:52:21 -05:00
Grant Nestor
75d2744eb4 Fix uneven input prompt width for markdown cells 2018-07-19 07:50:20 -07:00
Thomas Kluyver
d129f78fa0
Merge pull request #3777 from gnestor/mathjax-target
Use official mathjax package vs. components-mathjax
2018-07-19 09:52:59 +02:00
Thomas Kluyver
d61cd6eaa7
Merge pull request #3776 from gnestor/inline-run-button
Update styles for inline run button
2018-07-19 09:41:44 +02:00
Denis Ledoux
3729dd02ac [FIX] notebookapp, auth: get_secure_cookie kwargs
Per Tornado's documentation:

>By default, Tornado’s secure cookies expire after 30 days.
>To change this, use the expires_days keyword argument to
>set_secure_cookie and the max_age_days argument to get_secure_cookie.
>These two values are passed separately so that you may
>e.g. have a cookie that is valid for 30 days for most purposes,
>but for certain sensitive actions
>(such as changing billing information)
>you use a smaller max_age_days when reading the cookie.

With the current implementation in `auth/login.py`,
this is possible to pass the `expires_days` option
but not possible to enforce it as this is not possible
to pass `max_age_days` to `get_secure_cookie`

This makes impossible to set the cookie expiration without
using a custom `LoginHandler`.

This revision is about adding the possibility to pass options
to Tornado's `get_secure_cookie` method,
so it can be possible to set the cookies expiration,
among others.
2018-07-19 09:36:36 +02:00
Grant Nestor
43bd70b246 Fix uneven input prompt width 2018-07-18 21:38:16 -07:00
Min RK
a53d2c8489 flush iopub before sending restarting/dead status messages
to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
2018-07-18 14:00:44 -07:00
Grant Nestor
3a2690fc35 Use official mathjax package vs. components-mathjax 2018-07-17 13:39:23 -07:00
Grant Nestor
3c4bc0ef62 Display inline run button on same line as input prompt 2018-07-17 12:34:31 -07:00
Grant Nestor
f54e4355e8 Only display inline run button on mobile 2018-07-17 12:33:48 -07:00
Thomas Kluyver
a71a822de2
Merge pull request #3767 from takluyver/reenable-host-check
Re-enable Host header check after 5.6
2018-07-16 21:39:34 +02:00
M Pacer
be16b9540f
Merge pull request #3768 from munkm/testing
adding selenium to test requirements
2018-07-15 10:51:27 -05:00
Thomas Kluyver
0300f7341d Work around Mac's scoped link-local address for localhost 2018-07-15 09:13:26 +02:00
Madicken Munk
f2499f3713 adding selenium to test requirements 2018-07-14 11:09:39 -05:00
Thomas Kluyver
2bb4252f21 Re-enable Host header check after 5.6 2018-07-14 14:06:20 +02:00
Thomas Kluyver
2dd46b16c9 back to development 2018-07-14 13:43:16 +02:00
Thomas Kluyver
7674331e3d release 5.6.0 2018-07-14 13:36:19 +02:00
Thomas Kluyver
86e6f7954c
Merge pull request #3766 from takluyver/disable-host-check
Disable the host check for 5.6 because of gh-3754
2018-07-14 13:15:28 +02:00
Thomas Kluyver
a0503629ba Disable the host check for 5.6 because of gh-3754 2018-07-14 10:52:51 +02:00
Min RK
ebc60bc22e
Merge pull request #3752 from takluyver/changelog-56-b
Update changelog with recent changes merged
2018-07-13 11:43:13 -05:00
Thomas Kluyver
2c562e8587 Update changelog with recent changes merged 2018-07-12 11:06:13 +02:00
Thomas Kluyver
2ff28491f3
Merge pull request #3751 from gnestor/upgrade-mathjax
Upgrade mathjax
2018-07-12 10:39:06 +02:00
Grant Nestor
621a1cd83a Ignore package-lock.json 2018-07-11 22:06:50 -07:00
Grant Nestor
d0d156df70 Upgrade mathjax 2018-07-11 22:06:42 -07:00
Mokkapati, Praneet(ES)
b3457a068e Disabling Slide Type changes, when a cell is not editable 2018-07-07 17:59:57 +05:30
Mokkapati, Praneet(ES)
24dd9d67d7 Disabling Adding or Removing Tags, when a cell is not editable 2018-07-07 17:58:56 +05:30
Thomas Kluyver
9d0ea1a427
Merge pull request #3726 from takluyver/selenium-newnb-clickable
Wait for 'New' dropdown button to be clickable for Selenium tests
2018-07-04 14:53:30 +02:00
Min RK
b670fae728
Merge pull request #3714 from takluyver/check-host
Check 'Host' header for local connections
2018-07-03 11:40:42 +02:00
Thomas Kluyver
c4c49b71ea Wait for 'New' dropdown button to be clickable for Selenium tests 2018-06-30 20:22:52 +02:00
Thomas Kluyver
1b69205530
Merge pull request #3703 from minrk/public-host
add `or 127.0.0.1` when listening on all-ips
2018-06-30 20:01:26 +02:00
Thomas Kluyver
0d6ffa6888 Explain how to disable host check in warning message 2018-06-30 19:37:42 +02:00
Thomas Kluyver
c99935556e Decode IP addresses on Windows 2018-06-25 17:26:51 +02:00
Thomas Kluyver
845ea48c31 getaddrinfo() on Py2 only takes positional args 2018-06-25 14:49:49 +02:00
Thomas Kluyver
fa3abf2209 Allow remote access by default when we're listening on external addresses 2018-06-25 13:53:14 +02:00
Thomas Kluyver
7f1bba613d Check 'Host' header for local connections 2018-06-25 10:26:10 +02:00