Commit Graph

11440 Commits

Author SHA1 Message Date
Joshua Zeltser
24f1191cfa fixed bug stopping the edit notebook metadata popup from closing 2019-06-25 12:19:46 +01:00
Joshua Zeltser
fc2c46141d removed merge conflicts 2019-06-24 16:34:08 +01:00
Joshua Zeltser
1a9a096f9c Solved issue #4006 2019-06-24 16:31:25 +01:00
Min RK
a403d59cb0
Merge pull request #4642 from betatim/js-redirect
Use JavaScript to redirect users
2019-05-28 07:46:02 +02:00
Tim Head
077322dcd9 Use JavaScript to redirect users 2019-05-27 15:35:09 +02:00
Min RK
a33f4c60b1
Merge pull request #4591 from dalanicolai/patch-1
Update Working With Markdown Cells.ipynb
2019-05-24 15:23:32 +02:00
Thomas Kluyver
9425250005
Merge pull request #4588 from t-makaro/downloadas
fix duplicates in download as menu
2019-05-19 11:39:08 +02:00
Thomas Kluyver
9237c3732e
Merge pull request #4615 from LuisARodr/dualmode_execute
Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium
2019-05-19 11:29:38 +02:00
Tyler Makaro
1ae7838227 exporter naming scheme 2019-05-17 12:20:41 -07:00
Luis Rodriguez
cd2ea150a0 Refactor for
Changed 'for mode in cells_mode' for 'for i, mode in
enumerate(cells_mode)'
Removed the manual 'i' increment and declaration.
2019-05-17 09:11:11 -07:00
Luis Rodriguez
799b8be841 Move repeated assert mode
Moved 'assert mode == keyboard_mode' ouside the branches.
This means that if a unknown mode comes its gonna get catched by the
assert and never gona get to the else statement.
For this, the else stament moved to before the assert, caching the mode
error before the assert.
2019-05-17 09:03:15 -07:00
Tyler Makaro
6876f74c6d moved hard coded exporters 2019-05-16 16:27:26 -07:00
Luis Rodriguez
6679891464 Give space to inline comments 2019-05-16 09:31:22 -07:00
Luis Rodriguez
6b7d179697 Change assert for Exception 2019-05-16 09:28:00 -07:00
Luis Rodriguez
83b3c19de3 Solve insonsistensy on is_focused_on
Changed asserts for returns
Changed how the function is called on edit mode check
2019-05-16 09:12:10 -07:00
Luis Rodriguez
b294bf57f8 Refactor of ifs
Removed parentheses
Changed '==' for 'is' on None
2019-05-16 09:04:58 -07:00
Luis Rodriguez
c276d81914 Update docstring
Added more information about what the checks are
2019-05-16 09:00:49 -07:00
Thomas Kluyver
8ae0c047a9
Merge pull request #4617 from TeresaPartidaS/convert_multiselect_toggle_js_to_selenium
Migrate multiselect toggle test to selenium
2019-05-16 09:36:59 +01:00
TPartida
8749a5db99 Modified 'scrolling enabled' test assert 2019-05-15 15:01:40 -07:00
Luis Rodriguez
3a0cb7b113 Refactor validate_dualmode_mode
Previously know as validate_notebook_mode changed name to
validate_dualmode_mode to represent better the method.
Added a docstring.
Removed the handling of index being None.
2019-05-15 13:36:44 -07:00
Luis Rodriguez
fccc7d7420 Resolve notebook len duplicate method 2019-05-15 08:32:06 -07:00
Thomas Kluyver
69b7a1d204
Merge pull request #4623 from mtd91429/patch-1
Make tooltip buttons have consistent appearance
2019-05-15 12:53:02 +01:00
Thomas Kluyver
93099010ff
Merge pull request #4608 from LuisARodr/dualmode_tests
Convert dualmode_cellmode to selenium
2019-05-15 11:06:28 +01:00
mtd91429
cf1a76441c
Make tooltip buttons have consistent appearance
Change class of `expandlink` from `ui-corner-all` to `ui-button` to be consistent with `morelink` and `closelink`
2019-05-11 19:18:50 -04:00
TPartida
3f2fff21b0 Remove multiselect_toggle js 2019-05-09 11:59:38 -07:00
TPartida
c674a57955 Convert multiselect_toggle to selenium 2019-05-09 11:58:49 -07:00
Luis Rodriguez
849b7def18 Convert dualmode_markdown to selenium 2019-05-08 12:30:11 -07:00
Luis Rodriguez
ecc27953e3 Remove unused import & refactor 2019-05-08 11:19:10 -07:00
Luis Rodriguez
9158a79ec4 Convert dualmode_execute to selenium 2019-05-08 11:08:31 -07:00
Luis Rodriguez
5b162cfdf9 Convert dualmode_clipboard to selenium 2019-05-08 11:08:09 -07:00
Luis Rodriguez
3cdc418799 Add alt command, gets, and validate_notebook_state 2019-05-08 11:07:11 -07:00
Luis Rodriguez
89e678c74c Convert dualmode_cellmode to selenium 2019-05-06 11:43:03 -07:00
Thomas Kluyver
01b084381c
Merge pull request #4563 from emiliotl/convert_clipboard_js_to_selenium
Converted clipboard js to selenium and renamed undelete.py
2019-05-04 11:38:25 +01:00
Emilio Talamante Lugo
b2653ddb97 Add some code style improvements by not using list comprehension when not required 2019-05-02 09:56:28 -07:00
Daniel Nicolai
0ca8639f60
Update Working With Markdown Cells.ipynb
Add explicit instruction for online documentation pages
2019-04-25 17:12:29 +02:00
Tyler Makaro
cc5157d695 fix duplicates in download as meny 2019-04-24 21:22:14 -07:00
Emilio Talamante Lugo
31fce8270a Converted clipboard js to selenium and rename undeleted to conventional name 2019-04-12 14:38:14 -07:00
Min RK
eea37a6b21 changelog for 5.7.8 2019-04-08 14:24:48 +02:00
Thomas Kluyver
8c8ce334b5
Merge pull request #4528 from minrk/override-mime-types
explicitly ignore windows registry for mimetypes
2019-04-05 13:42:10 +01:00
Thomas Kluyver
55e7a6635b
Merge pull request #4536 from takluyver/sphinxext-github-out
Use separately packaged sphinxcontrib_github_alt
2019-04-04 08:14:32 +01:00
Thomas Kluyver
1a6fc8e5b6
Merge pull request #4531 from Quansight/change-default-ssl
Changed the default protocol
2019-04-04 08:07:21 +01:00
Ivan Ogasawara
55177807bc Fixed small issue and added more information about PROTOCOL_TLS 2019-04-03 12:41:10 -04:00
Ivan Ogasawara
61c50b1b8c Improve code, add docstring 2019-04-03 10:36:37 -04:00
Ivan Ogasawara
c5264b6cea Changed the default protocol
Applied suggestion from review

Fixed hasattr issue
2019-04-02 16:52:17 -04:00
Thomas Kluyver
f21650ed0c
Merge pull request #4512 from emiliotl/convert_dmode_arrows_and_fix_dmode_insert_tests
Fixed dualmode insert test and convert dualmode arrows test to selenium
2019-04-01 14:57:22 +01:00
Thomas Kluyver
1ffd35f524
Merge pull request #4529 from ivigamberdiev/patch-1
Update link and http -> https
2019-04-01 14:55:49 +01:00
Thomas Kluyver
d77a1e7ae8 Use separately packaged sphinxcontrib_github_alt 2019-04-01 14:24:14 +01:00
Min RK
b1e4ac2520
Merge pull request #4534 from hroncok/sphinx2
Switch to Sphinx logging API
2019-04-01 13:14:40 +02:00
Elliott Sales de Andrade
0460caab9a Switch to Sphinx logging API
Fixes https://github.com/jupyter/notebook/issues/4533

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
2019-03-31 11:33:21 +02:00
Emilio Talamante Lugo
d8120e5845 Rename ctrl method to cmdtrl which covers the mains OS 2019-03-29 20:24:30 -07:00