Commit Graph

55 Commits

Author SHA1 Message Date
Min RK
22e206de6f ContentsManager type kwarg to match model key
remove `_` suffix, making it consistent with models,
REST API, etc.
2014-12-09 14:53:08 -08:00
Thomas Kluyver
4cee2f5f3a Merge pull request #7128 from minrk/more-v-less-m
A little more V, a little less M in the text editor
2014-12-09 14:03:04 -08:00
Thomas Kluyver
9f48e86477 Merge pull request #7136 from minrk/octet-stream
set default mimetype to octet-stream for binary files
2014-12-08 18:23:31 -08:00
Scott Sanderson
ccc8cb9cbf Minor cleanups in the contents API.
Noticed while poking around with a linter enabled.
2014-12-08 19:22:03 -05:00
Min RK
407e63cb80 set default mimetype to octet-stream for binary files
mimetype only specified if content=True
2014-12-08 14:31:32 -08:00
Min RK
c81609f5d6 redirect /edit/ to /files/ if not (utf8) text 2014-12-08 11:34:21 -08:00
Min RK
c238553a4e set application/json on contents model replies 2014-12-07 13:10:15 -08:00
Matthias Bussonnier
de52775797 Merge pull request #7078 from takluyver/kernelpath
Rework get_kernel_path logic
2014-12-04 16:59:54 +01:00
Thomas Kluyver
d273b56044 Clean up get_kernel_path logic 2014-12-02 11:54:19 -08:00
Matthias Bussonnier
fd2588612a return API path instead of filesystem 2014-11-28 11:31:22 +01:00
Thomas Kluyver
25ee73a554 Loading a file works 2014-11-20 11:52:35 -08:00
Min RK
837ef7f122 s/open_w/atomic_writing/ 2014-11-19 19:56:54 -08:00
Min RK
c9a4e5b00d handle various permission failures
- turn various EPERM, EACCES errors into 403
- add `writable` bool field to contents models
- if a notebook is not `writable`, save is disabled
2014-11-19 19:56:52 -08:00
Thomas Kluyver
8252f56b00 Allow FileContentsManager and MappingKernelManager to be used outside NotebookApp 2014-11-18 17:41:21 -08:00
Thomas Kluyver
6d776a5292 Allow starting the server with both file_to_run and notebook_dir
file_to_run and notebook_dir would collide, with possible dictionary
ordering randomness depending on how they were passed.

With this change, the default value of notebook_dir is pulled from
file_to_run, instead of pushing the value when file_to_run is changed.
This makes it possible to specify both and have the server behave as
expected.
2014-11-18 17:41:21 -08:00
Thomas Kluyver
d04e41251d Merge pull request #6915 from minrk/contents-no-0
use Untitled instead of Untitled0
2014-11-13 14:04:00 -08:00
Min RK
456e65b1f3 adjustments to filename increment
- start with no number (Untitled0 -> Untitled.ipynb)
- copy of copy increments instead of adding another `-Copy` (copy Foo-Copy1.ipynb gives Foo-Copy2.ipynb, not Foo-Copy1-Copy1.ipynb)
- copy file to new folder starts with the original filename, instead of unconditional `-Copy0`
2014-11-12 16:24:35 -08:00
Thomas Kluyver
c9b6e30526 Actually pass URL params with API request 2014-11-11 18:18:36 -08:00
Thomas Kluyver
f1f81e2efa Rename get_model() to get() 2014-11-11 14:51:21 -08:00
Thomas Kluyver
6f48b58b18 Fix various review comments 2014-11-11 14:46:53 -08:00
Thomas Kluyver
b5a6cb7da1 Allow specifying format when getting files from contents API 2014-11-11 14:20:56 -08:00
Thomas Kluyver
ce6dd40c5c Add type parameter for contents GET requests 2014-11-11 12:17:36 -08:00
Min RK
da832ef59f split ContentsManager.new, add ContentsManager.new_untitled 2014-11-10 14:52:14 -08:00
Min RK
39041a9f03 address review in contents service
- various docstrings, comments clarified and updated
- misc typos
- fix and test creating an untitled directory via POST
- only define `message` if there's something to say
2014-11-10 14:02:21 -08:00
Min RK
74c897cc0b unicode! 2014-11-10 14:02:20 -08:00
Min RK
bc4f0b32bb rename ContentsManager.create_file->new
consistent with js API
2014-11-10 14:02:19 -08:00
Min RK
b6c4baa2fb remove copy via PUT
only copy via POST to directories
2014-11-10 14:02:19 -08:00
MinRK
3ada0c2c27 Remove separate 'path', 'name' in Contents API
- path is full path (including name)
- name is only used for read-only convenience, and plays no role in any API
- remove 'untitled upload' (POST with content and no path)
2014-11-10 14:02:18 -08:00
Min RK
525f6a7561 fix backward f, nb args for nbformat.write 2014-11-01 16:41:13 -07:00
MinRK
7cf53c998c restore ability to sign v3 notebooks 2014-11-01 16:41:13 -07:00
MinRK
af735018f3 don't use nbformat.current in IPython.html
use top-level nbformat.read/write, v4 directly for compose
2014-11-01 16:41:11 -07:00
MinRK
12f94ae2a2 use from_dict for dict->notebook
not confusing to_notebook_json
2014-11-01 16:41:09 -07:00
MinRK
dd95b1ef5f remove heading cells in v4 2014-11-01 16:41:07 -07:00
MinRK
07079095a8 update html/js to nbformat 4 2014-11-01 16:41:02 -07:00
Matthias Bussonnier
b2a0798fdf Merge pull request #6598 from minrk/nbformat-backport
nbformat validation
2014-10-09 11:58:56 +02:00
MinRK
b87fee048c redirect /api/notebooks to /api/contents
eases 2.x-3.x transition for consumers such as emacs-ipython-notebook
2014-10-08 12:33:43 -07:00
MinRK
b2d946d44e don't convert notebooks on upload 2014-10-08 12:33:34 -07:00
MinRK
8392c7ac9e don't check_and_sign old notebooks on upload 2014-10-08 12:33:34 -07:00
MinRK
4ae05c729c trust is stored in code_cell.metadata
not top-level code_cell
2014-10-08 12:33:33 -07:00
MinRK
ddd3aa2a5a add dialogs for failed save/load
- failed validation doesn't prevent save/load,
  but the user is now warned about it.
- there is now a warning dialog if fromJSON fails,
  rather than the usual silent failure.
2014-10-08 12:33:32 -07:00
Thomas Kluyver
fa6056e9ed Sort directory contents in test before assertion
Should fix recent test failures, but I can't replicate failure on my
computer, so it's not clear that it's fixed.
2014-09-05 18:44:58 -07:00
Thomas Kluyver
81b06d81a1 Merge pull request #6358 from minrk/contents-missing
fix directory listing with broken symlinks
2014-09-04 14:43:45 -07:00
MinRK
819c3c326c fix directory listing with broken symlinks
directory listing would 404 if any listed file doesn't exist
(e.g. symlink to missing target).

Previously-failing test included.
2014-08-26 09:12:54 -07:00
Thomas Kluyver
8b7d4c1c2f Rework atomic_writing with tests & docstring 2014-08-05 10:50:09 -07:00
Thomas Kluyver
04cbce2a14 Implement atomic save
Ping @fperez, this should avoid issues with corrupted/lost notebooks
when the disk is full, though I haven't worked out how to test it just
yet.

Closes gh-6254
2014-08-04 11:22:42 -07:00
MinRK
3e79eea46b update contents per further review
- fix is_hidden always returning True on nonexistent files
- create hidden dir fails with 400
- don't read binary files twice
- logging improvements
- dialog on invalid notebook upload
- warn about disabled `--save`
2014-07-31 11:57:38 -07:00
MinRK
3c26b079f0 updates per review
- clarified docstrings and errors
- still more notebook/file renames
- configurable untitled names
- copy_from can be full path
- fix running, upload, new-tab behaviors in dashboard

Yay, review!
2014-07-31 11:57:38 -07:00
MinRK
bec995aa63 updates per review
a few more notebook mentions in docstrings,
and inappropriate use of setdefault.
2014-07-31 11:57:37 -07:00
MinRK
93b300adda support deleting empty directories
can’t copy directories
2014-07-31 11:57:37 -07:00
MinRK
260afd76ae contents service review
- missed some s/notebook/file/ in docstrings
- manager doesn’t sort contents
2014-07-31 11:57:37 -07:00