Commit Graph

162 Commits

Author SHA1 Message Date
Jason Grout
0bdfdc03ca python3 does not like adding lists and map results
Thanks to @takluyver for pointing this out
2015-01-08 18:43:38 +00:00
Jason Grout
18cfbc0d11 Generate fontweight enum values without an extraneous variable from a comprehension
In python 2, the comprehension will create a new class attribute, i.  Using a map will not create the extra local variable.
2015-01-08 18:24:38 +00:00
Jonathan Frederic
73637fb694 Merge pull request #7097 from jasongrout/widget-visibility
Expand the semantics of the widget visible attribute to allow for visibility: hidden
2014-12-10 10:54:15 -08:00
Min RK
7d465c7e96 Merge pull request #7139 from jdfreder/widget-space-fix
Fix padding of widgets.
2014-12-09 15:06:21 -08:00
Jonathan Frederic
2cc041444a Explicit 2.5px 2014-12-09 10:35:02 -08:00
Jonathan Frederic
cb12229480 Fix padding of widgets. 2014-12-08 17:32:43 -08:00
Jonathan Frederic
d466601dbb Persistence API,
This is a combination of 10 commits.
Enable widget instanciation from front-end.

Address @minrk 's review comments.

Make API that allows users to persist widget state easily.

Added support for view persistence

Started adding support for model persistence.

Half way there!

Finished persistence API.

Move persistence code into the widget framework.

Fin.

Bug fixes
2014-12-08 17:18:09 -08:00
Jason Grout
26bec1ad36 Add None as a widget visible value to allow for visiblity: hidden
Now, visible can have three values:
  * True - show the widget
  * False - hide the widget and collapse the empty space
  * None - hide the widget and show the empty space
2014-12-04 00:27:59 +00:00
Min RK
b5e7ce30ca handle setting Widget.comm = None
which is done in `Widget.close`

fixes loads of warnings in widget test output, caused every time a widget is closed.
2014-11-12 11:29:10 -08:00
Sylvain Corlay
ed5e602950 jupyter -> IPython 2014-10-29 21:52:03 -04:00
Sylvain Corlay
374459e5e7 Adding custom keys for core jptr notebook 2014-10-29 21:52:03 -04:00
Sylvain Corlay
18e77a090a registering core widgets 2014-10-29 21:52:03 -04:00
Sylvain Corlay
e5b347804a widget registry 2014-10-29 21:52:03 -04:00
Jonathan Frederic
ba77877c18 Rebase fixes 2014-10-28 17:55:36 -07:00
Jonathan Frederic
db10ae8f2d s/target_name/widget_class 2014-10-28 16:49:46 -07:00
Jonathan Frederic
cb2c76999c Address some more review comments... 2014-10-28 16:49:46 -07:00
Jonathan Frederic
a68df8a8b1 Address @minrk 's review comments. 2014-10-28 16:49:46 -07:00
Jonathan Frederic
fbca0bfa3f Rebase fixes. 2014-10-28 16:49:45 -07:00
Jonathan Frederic
2b5ebb9e8f Make Python push initial state.
Also added initial state push callback.
2014-10-28 16:49:45 -07:00
Jonathan Frederic
e7ee9c12b3 Enable widget instanciation from front-end. 2014-10-28 16:44:02 -07:00
Thomas Kluyver
031530da42 Support specifying requirejs modules for widget models 2014-10-24 12:14:43 -07:00
Jonathan Frederic
79670e8afb Merge pull request #6494 from takluyver/widget-comm-require
Allow widget views to be loaded from require modules
2014-10-21 10:11:41 -07:00
Jonathan Frederic
1172876191 Add version trait to Widget base,
From widget Trello: version numbers for widget models;
when reloaded, will give the widget a chance to do
something intelligent or fail (by default) if the
version number doesn't match.
2014-10-13 11:52:19 -07:00
Min RK
60bfcf8c74 Merge pull request #6665 from jdfreder/travis_please_run_on_this
Separate widget model name from com target name.
2014-10-09 11:45:41 -07:00
Jonathan Frederic
4b968ece0b s/target_name/model_name 2014-10-09 10:55:46 -07:00
Jonathan Frederic
24096b0f45 Separate widget model name from com target name. 2014-10-08 21:31:00 -07:00
Jonathan Frederic
60531c917f Merge pull request #6481 from jdfreder/intvalidatefix
Fix bug in bounded int/float logic.
2014-10-07 10:50:02 -07:00
Thomas Kluyver
09b10dcb86 Make changes suggested by @jdfreder 2014-10-05 09:35:54 -07:00
Thomas Kluyver
5953a3f874 Allow widget views to be loaded from require modules
This required refactoring things that create widget views to use
callbacks instead of return values.
2014-10-05 09:35:53 -07:00
Jonathan Frederic
f83140dae8 s/long thing/set_state 2014-09-30 15:55:31 -04:00
Jonathan Frederic
341527779b Fix notify_trait getting called too early. 2014-09-25 14:51:38 -07:00
Sylvain Corlay
a9fca81e95 Set default view to None and never display widget with no view 2014-09-24 23:10:41 -04:00
Jonathan Frederic
aec576a5f2 Fix infinite loop typo 2014-09-24 15:48:19 -07:00
Brian E. Granger
4ec1a3b41e Merge pull request #6235 from jdfreder/addclass
Remove add/remove_class and set/get_css.
2014-09-23 16:28:50 -07:00
Jonathan Frederic
d4d554052e Address problems found in in-person review 2014-09-23 15:18:00 -07:00
Jonathan Frederic
02e3a58030 s/fore_color/color
s/back_color/background_color
2014-09-16 10:17:59 -07:00
Jonathan Frederic
78db5dc24e Merge pull request #6377 from jasongrout/fix-widget-prefix
Strip the IPY_MODEL_ prefix from widget IDs before referencing them.
2014-09-15 13:40:09 -07:00
Jason Grout
2acee4a269 Strip the IPY_MODEL_ prefix from widget IDs before referencing them. 2014-08-28 19:52:20 +00:00
Jonathan Frederic
a0e70e350f Fix some bugs found by the widget examples,
add margin and padding base traits,
add overflow traits to box base.
2014-08-28 11:15:24 -07:00
Jonathan Frederic
fdcf263965 Partial implementation of styles 2014-08-28 11:09:55 -07:00
Jonathan Frederic
9af77a6374 Initial crack at using specific traits for styling. 2014-08-28 11:09:55 -07:00
Jonathan Frederic
f85a01041c Remove add/remove class methods,
Remove helper set/get css methods
2014-08-28 11:09:55 -07:00
Jonathan Frederic
1b29be13c6 Merge pull request #6332 from jasongrout/widget-property-lock
Widget property lock should compare json states, not python states
2014-08-25 10:12:04 -07:00
Jonathan Frederic
8877d32c4e Merge pull request #6194 from SylvainCorlay/immediate-widget-comm
Allow model id to be set externally on creation of the widget.
2014-08-19 14:33:03 -07:00
Jason Grout
0e5ceca059 Make the widget property_lock store the JSON state, not the original object
Comparison between arbitrary python objects can get crazy, whereas we really
only care about if the JSON state we are syncing is different.  So with this change,
we store and check against the JSON state.
2014-08-18 17:28:07 +00:00
Jonathan Frederic
690059f8f8 Merge pull request #6296 from jasongrout/sync-hold
Add a new context manager, Widget.hold_sync(), which holds any syncing until the manager exits
2014-08-14 12:45:19 -07:00
Jason Grout
5cd46788f9 Before syncing a widget's state, check first for the property lock, then for the widget state lock 2014-08-12 18:23:57 +00:00
Jason Grout
af26d9cc24 Add a new context manager, Widget.hold_sync(), which holds any syncing until the manager exits
Sometimes for consistency or efficiency purposes, it makes sense to update
a group of properties all at once.  This context manager makes this possible.

We also fix a bug where send_state was not passing the key on to get_state.
2014-08-12 17:29:41 +00:00
Sylvain Corlay
f9fa4ada06 allowing widet id to be set externally 2014-08-11 18:36:59 +00:00
Jason Grout
8513f673e3 Make the widget comm attribute more straigtforward
Instead of automagically instantiating a comm when it is accessed, require a call to open().  This makes the comm attribute much less magical, and hopefully more understandable.
2014-08-11 18:36:59 +00:00