Commit Graph

5967 Commits

Author SHA1 Message Date
Jason Grout
aa8e36064c Make it possible for msg.buffers in javascript to be either ArrayBuffers or views 2015-03-23 19:37:35 +00:00
Sylvain Corlay
55246125e4 Adding readout for Valid widget 2015-03-23 19:20:56 +00:00
Sylvain Corlay
c1a3e7f389 Valid widget 2015-03-23 19:20:56 +00:00
MinRK
3f93c80d7e remove pexpect from external
make it a dependency on non-Windows
2015-03-23 11:22:09 -07:00
Sylvain Corlay
5c0a797813 inherit from Unicode 2015-03-21 14:45:28 -04:00
Sylvain Corlay
19768ba7a3 Move color trait type to the widget package 2015-03-21 12:49:10 -04:00
Sylvain Corlay
7262de2216 Using the Color trait type for styling widgets 2015-03-21 00:57:42 -04:00
Scott Sanderson
7971a5ffc7 TEST: Also test deletion. 2015-03-20 21:12:08 -04:00
Scott Sanderson
fdcbd02ffb TEST: Add test for renaming files with checkpoint.
The checkpoint name should follow the file rename.
2015-03-20 20:42:42 -04:00
Matthias Bussonnier
265c1d8a28 Merge pull request #7933 from jdfreder/buttonmove
Move dynamic buttons to the left and upload button to the right.
2015-03-20 13:18:57 -07:00
Matthias Bussonnier
166595686c Merge pull request #8059 from minrk/deselect-click
deselect all when clicking partial checkbox
2015-03-20 13:12:22 -07:00
Jonathan Frederic
dfa2804887 invoke css 2015-03-20 12:14:29 -07:00
Jonathan Frederic
a840383a38 Add tooltip on the upload button. 2015-03-20 12:14:29 -07:00
Jonathan Frederic
a6ceb828aa Add dynamic instructions 2015-03-20 12:14:29 -07:00
Jonathan Frederic
f283754df0 invoke css 2015-03-20 12:13:17 -07:00
Jonathan Frederic
94a8d09dfc Move upload to the right and dynamic buttons to the left. 2015-03-20 12:13:17 -07:00
Min RK
1c09425838 Merge pull request #8000 from mathieu1/dashboard-nb-rename-dialog
Fix rename issues in dashboard
2015-03-20 15:00:37 -04:00
Robert Smith
e539734f5a Remove image resizer. 2015-03-20 10:41:29 -06:00
Min RK
0fa751b894 Merge pull request #7798 from jasongrout/buffer-memoryview
Extract session buffers as memoryviews
2015-03-20 09:49:27 -04:00
Min RK
9ded491c97 Merge pull request #7708 from SylvainCorlay/allow_none
allow_none=False for all trait types but Instance and Type
2015-03-20 09:48:40 -04:00
Min RK
b9f5a43ebd setup.py jsversion 2015-03-20 09:46:07 -04:00
Min RK
b8bbc958a4 Merge pull request #8091 from quantopian/move-test
TEST: Move test_escape_root to TestFileContentsManager
2015-03-20 09:06:22 -04:00
Matthias Bussonnier
b64389a1b5 Merge pull request #8092 from Carreau/log-erros
log error when there is one.
2015-03-19 17:44:53 -07:00
Scott Sanderson
e21b99900d MAINT: Remove unused import. 2015-03-19 18:35:02 -04:00
Matthias Bussonnier
1a377f8a44 log error when there is one.
Otherwise it's a pain to debug
2015-03-19 15:27:30 -07:00
Scott Sanderson
257c7296c9 TEST: Move test_escape_root to TestFileContentsManager
`root_dir` is specific to the FileContentsManager implementation.
2015-03-19 18:13:08 -04:00
Matthias Bussonnier
8c69b4c376 Merge pull request #8082 from minrk/output-z-index
set z-index on output_wrapper
2015-03-19 10:59:49 -07:00
Min RK
090c847aa4 Merge pull request #8084 from Carreau/delete-duplicate
Bad code duplication, I suppose duplicate was meant.
2015-03-18 23:20:49 -04:00
Matthias Bussonnier
657dffe20f Bad code duplication, I suppose duplicate was meant. 2015-03-18 16:30:10 -07:00
Min RK
63f120db45 set z-index on output_wrapper
avoids scrolled output overlaying input in some strange circumstances
2015-03-18 19:04:49 -04:00
Thomas Kluyver
f4e25f5d77 Merge pull request #8058 from Carreau/css-v-ch
fix css checkbox vertical align, closes #8065
2015-03-17 11:40:43 -07:00
Thomas Kluyver
05d5b586e5 Merge pull request #8045 from Carreau/cmconfigmerge
Merge codemirror config with user config.
2015-03-16 14:40:45 -07:00
Matthias Bussonnier
bfc45392f8 remove Stray .c 2015-03-16 14:23:04 -07:00
Min RK
71fcc3375a deselect all when clicking partial checkbox
stores state in `data('indeterminate')` instead of `prop('indeterminate')`
because the property is cleared before the event handler is called
2015-03-14 16:04:06 -06:00
Matthias Bussonnier
14ab9854c6 fix css checkbox vertical align, closes #8065 2015-03-14 14:34:59 -07:00
Matthias Bussonnier
3b338cb424 Not critical, and more color as warning is orange 2015-03-13 15:37:48 -07:00
Matthias Bussonnier
025ec6df77 Rename local variable to avoid confusion. 2015-03-13 14:37:38 -07:00
Matthias Bussonnier
63a4a764f2 Merge codemirror config with user config.
Simplify customisation of codemirror without duplicating the all
codecell configuration.

Closes #8038
2015-03-13 13:40:44 -07:00
Min RK
676da764fe scroll quickhelp dialog if large
using `calc(100vh-padding)` for max-height
2015-03-13 13:16:13 -07:00
Thomas Kluyver
cf6925ce7a Merge pull request #8005 from minrk/files-as-file
Get /files/ unmodified from contents
2015-03-13 12:35:15 -07:00
Min RK
c6e440c1f9 Merge pull request #7992 from Carreau/falsejs
remove false info in custom.js
2015-03-13 12:25:50 -07:00
Min RK
0e4417326f Merge pull request #8027 from bollwyvl/fix-select-multiple
Don't re-implement option.click to trigger select.change

closes #8012
2015-03-13 12:25:05 -07:00
Min RK
91cf4ba394 get mime from filename
remove never-true `type: notebook` case
2015-03-13 12:23:07 -07:00
Matthias Bussonnier
22f619f316 add dot end of sentence. 2015-03-13 11:47:24 -07:00
Min RK
3a21271d7e Merge pull request #7926 from Carreau/config-3.1
Fix configurability of codecell
2015-03-12 17:49:28 -07:00
Matthias Bussonnier
0e46460094 Remove false info in custom.js 2015-03-12 17:15:22 -07:00
Thomas Kluyver
484958d282 Merge pull request #7983 from minrk/contents-escape-root
contents: double check that os_path is always within root
2015-03-12 15:20:51 -07:00
Min RK
08d8fe6c10 Merge pull request #8024 from Carreau/fix-focus
Fix save switch to command mode after shortcut
2015-03-12 15:19:27 -07:00
Matthias Bussonnier
596dd46e93 Merge pull request #7932 from jdfreder/dashcss
Fix alignment of dashboard things.
2015-03-12 15:09:37 -07:00
Matthias Bussonnier
86e131d478 Merge pull request #7982 from minrk/window-height
use $(window).height() instead of window.innerHeight
2015-03-12 15:05:00 -07:00
Justin Tyberg
8c486f0963 Fix custom.js samples to define requirejs module rather than require it. 2015-03-12 16:17:50 -04:00
Matthias Bussonnier
0408e7e4e4 Fix save switch to command mode after shortcut
When triggering actions with button one have to refocus the notebook
cell. Though with keyboard shortcut, you don't want cell to switch to
command mode.
2015-03-12 10:57:02 -07:00
Nicholas Bollweg
1fa4296cef fixes #8012 2015-03-12 07:42:50 -04:00
Matthias Bussonnier
75fe862814 remove private methods 2015-03-09 17:54:26 -07:00
Min RK
a89e800e18 trigger save before copy if there are unsaved changes.
just like we do before downloading
2015-03-09 09:50:17 -07:00
Min RK
a4321ccf5a Get /files/ unmodified from contents
request raw files instead of parsing notebooks

avoids reserializing (inconsistently) on download of notebooks.
2015-03-09 09:40:15 -07:00
Mathieu
23d9ad741f remove debug logging 2015-03-09 09:54:24 +01:00
Mathieu
237b34e2df fix rename issues in dashboard
- Do not display the full path of the selected item in the text box
- Adapt dialog for files and notebook
- Do not allow renaming a running notebook
2015-03-09 09:01:58 +01:00
Jonathan Frederic
c5f20e9481 Merge pull request #7681 from mathieu1/tree-selector-ui
Streamline tree-selector menu
2015-03-05 23:35:33 -08:00
Min RK
62e4a5d072 contents: double check that os_path is always within root
check based on tornado `StaticFileHandler.validate_absolute_path`

I haven't been able to actually escape root, but we should have this check anyway.
2015-03-05 17:25:06 -08:00
Min RK
bfa501855a use $(window).height() instead of window.innerHeight
to measure window height when resizing contents

Sometimes these values differ by a pixel,
we may never know why.

window.innerHeight seems to be larger when they disagree, causing an extra scrollbar to be drawn.
2015-03-05 16:46:58 -08:00
Thomas Kluyver
1daa179153 Merge pull request #7981 from Carreau/focus-after-save
Refocus notebook after click on save
2015-03-05 14:35:22 -08:00
Matthias Bussonnier
afd74fbb94 Refocus notebook after click on save
closes #7963
2015-03-05 14:22:31 -08:00
Mathieu
eaeff19314 simpler select function 2015-03-05 17:05:02 +01:00
Scott Sanderson
7a1b8d7dff DEV: Add re-raise toggle for server extensions.
Also renames toggles to "reraise_*_extension_failures".
2015-03-04 18:09:35 -05:00
Peter Parente
dc8f9b0733 Ensure Cache-Control is set once and only once
Whether browsers should pick the first or last instance of a duped header is ill defined
2015-03-03 22:40:27 -05:00
Min RK
dfb36abc4d make 'download as PDF' say 'via LaTeX'
so it's clear that LaTeX is required
2015-03-03 13:46:26 -08:00
Jason Grout
e1a6dbd4be Handle kernel messages synchronously
A problem can happen when two messages come in for different
comms, where the second depends on the first (for example, the
first might be a message setting the state of a widget, and the
second triggering a view creation for the widget).  Since comm
message queues are independent of each other, the second message
could be executed before the first message.

This exposes a more fundamental assumption users are likely to
have that messages from python are processed synchronously.

Thanks to @dmadeka for reporting an error that led to discovering this issue.
2015-03-03 16:01:23 +00:00
Jonathan Frederic
e50344f4e6 invoke css 2015-03-02 14:27:53 -08:00
Jonathan Frederic
b8ffcf351c invoke css 2015-03-02 14:26:14 -08:00
Jonathan Frederic
5ad87d13d6 Merge pull request #7902 from gertingold/radio
fix margin in RadioButtons
2015-03-02 14:25:06 -08:00
Jonathan Frederic
0cf008d23d Only pad indicator text. 2015-03-02 14:21:30 -08:00
Jonathan Frederic
65868feb17 Move checkbox down two pixels b/c it looks like 💩 where it is. 2015-03-02 14:17:54 -08:00
Jonathan Frederic
e09b83e910 Merge pull request #7725 from SylvainCorlay/fabutton
Adding font-awesome icon to button and toggle button
2015-03-02 11:54:06 -08:00
Sylvain Corlay
03b884a615 Moving styling to else statement 2015-03-02 14:34:37 -05:00
Matthias Bussonnier
103f2f1df2 Update comment for future removal of code 2015-03-02 10:34:38 -08:00
Matthias Bussonnier
ed60311a75 Fix configurability of codecell
code cell where actually not configurable,
this fixes that + add a convenient methods to dump the
content of the configuration in the config file.

this also close #7896 by defaulting closebracket to true,
which is now configurable :-)

It also switches the default magic highlight mode to string so that they
could also be configured.
2015-03-02 10:29:06 -08:00
Min RK
6cb15fbffe Merge pull request #7780 from jasongrout/message-race
Fix race condition in javascript kernel message processing
2015-03-02 09:27:36 -08:00
Matthias Bussonnier
242fc93f93 Merge pull request #7889 from Carreau/after-one-year
Js completion traceback, erase line on tab, and double complete.
2015-03-01 21:19:03 -08:00
Min RK
f76ce1d6b9 warn about failure to bind to localhost
when falling back on 127.0.0.1
2015-03-01 20:22:51 -08:00
Min RK
c605ea44cc fallback on 127.0.0.1 if localhost cannot be bound
Some (broken) systems cannot bind to localhost.
This handles that failure and falls back to 127 as the default
2015-03-01 20:22:51 -08:00
Min RK
17ee541add actually catch failure to load widget state
load callback was called directly,
rather than in promise function that catches errors
2015-02-28 15:10:48 -08:00
Min RK
fb12238bb2 update js serialize test
msg count and msgspec v5 API changes
2015-02-28 13:31:05 -08:00
Thomas Kluyver
2b95955079 Merge pull request #7906 from minrk/skip-perm-test-windows
skip permission error -> 403 test on Windows
2015-02-28 13:17:30 -08:00
Matthias Bussonnier
709126542a Merge pull request #7832 from minrk/default-secure-session
remove default_secure, make Session secure by default
2015-02-28 12:59:14 -08:00
Min RK
0bc4549d25 skip permission -> 403 test on Windows
The test actually passes on my VM (Win 7),
but not on Jenkins (Server 2012).

I haven't figured out how to identify the subset of Windows systems where it won't work,
but since the problem appears to be in the test,
not the tested code, skipping on Windows seems the right way to go.
2015-02-28 11:52:52 -08:00
Min RK
d9f01671ae make it clearer that we adapt to old messages
> Adapting to protocol vX for kernel Y

instead of

> Kernel Y speaks protocol version X

some have interpreted the "Kernel speaks" statement was an error message;
this should be clearer about what's happening,
and that there is no error.
2015-02-28 11:35:37 -08:00
Min RK
109ee00ebb get session.key from kernel manager
in kernel channel handlers

we were accidentally relying on loading Session.key from config set via the default_secure decorator,
which forced the key to be the same for every kernel.
2015-02-28 11:22:19 -08:00
Min RK
96334d4594 deprecate default_secure decorator
make Session secure by default on its own

I think the decorator was an artifact of very early design prototyping, and really isn't necessary.
2015-02-28 11:22:19 -08:00
Matthias Bussonnier
dad4ba22b8 Merge pull request #7881 from minrk/ssl-options
add ssl_options config value
2015-02-28 10:15:57 -08:00
Matthias Bussonnier
de90843b29 Merge pull request #7893 from Carreau/add-markdown-menu
Add Markdown to the list of downloadable nbconverted formats.
2015-02-28 10:15:12 -08:00
Matthias Bussonnier
4c567fb544 Merge pull request #7779 from abeguerra/defect-5544-fix-hyperlink-display
Fixed rendering of URL in append_stream function
2015-02-28 10:05:56 -08:00
Gert-Ludwig Ingold
5cef46f26e fix margin in RadioButtons 2015-02-28 18:42:34 +01:00
Min RK
65b2b3a651 Merge pull request #7888 from Carreau/horse
Don't recompute values
2015-02-27 17:28:45 -08:00
Fernando Perez
50c8c5feed Merge pull request #7852 from minrk/open-perm
Catch IOError in addition to OSError.

Closes #7848
2015-02-27 17:07:53 -08:00
Thomas Kluyver
2111ac4812 back to development 2015-02-27 15:47:42 -08:00
Thomas Kluyver
76ce8cd2fb Release 3.0 2015-02-27 15:46:17 -08:00
Matthias Bussonnier
59cab4c2d8 Add Markdown to the list of downloadable nbconverted formats.
Seem it was just forgotten. The list was not auto generated on purpose
IIRC, as some format, like TeX were deemed not useful in menu.
2015-02-27 09:17:55 -08:00
Matthias Bussonnier
a30b9b9446 Fix #4777 and #7887
The function in charge of actually converting cursor offset to
CodeMirror line number and character number was actually crashing when
the cursor was at the last character (loop until undefined, then access
length of variable, which is undefined).

This was hiding a bug in which when you would completer to a single
completion pressing tab after as-you-type filtering, the completion
would be completed twice.

The logic that was supposed to detect whether or not all completions had
a common prefix was actually faulty as the common prefix used to be a
string but was then changed to an object. Hence the logic to check
whether or not there was actually a common prefix was always true, even
for empty string, leading to the deletion of the line (replace by '') in
some cases.
2015-02-26 20:37:12 -08:00
Matthias Bussonnier
230ea32f0d Dont recompute values 2015-02-26 20:00:38 -08:00