Commit Graph

2642 Commits

Author SHA1 Message Date
MinRK
dc65b33d14 simplify handler patterns
PATH pattern will now sometimes include leading slash,
but that's okay because nbmanager will strip them.

fewer redirect patterns needed
2013-10-17 14:09:15 -07:00
MinRK
a31cfdc8a8 ensure 'path' never has leading or trailing slash in nbmanager
Don't trust API callers to always get this right.
2013-10-17 14:09:15 -07:00
MinRK
83114a11d8 add TrailingSlashHandler
redirects all GET requests with a trailing slash
2013-10-17 14:09:15 -07:00
MinRK
a7f297f8f3 save before download-as
uses `async : false`

closes #852

download-as-py still unavailable.
2013-10-17 14:09:15 -07:00
MinRK
8b94ee2b47 use async : false to avoid pop-up blocker on New / Copy notebook 2013-10-17 14:09:14 -07:00
MinRK
b33ffa7068 update upload and copy
adds 'notebook.ipynb/copy' url handler

because we were putting too many things in a single POST handler.
2013-10-17 14:09:14 -07:00
MinRK
75e14424c6 cleanup old, unused /notebooks/foo API methods
these have moved to `/api/notebooks`
2013-10-17 14:09:14 -07:00
MinRK
4e12521082 fix dashboard upload 2013-10-17 14:09:14 -07:00
MinRK
c21ea96476 log exceptions parsing JSON 2013-10-17 14:09:14 -07:00
MinRK
5b1a648fc8 move os_path to FileNBMan
doesn't belong in base NotebookManager
2013-10-17 14:09:14 -07:00
MinRK
d1e0aded7d mixup notebook_list 2013-10-17 14:09:14 -07:00
MinRK
fe59217989 move url_[un]escape to utils from nbm 2013-10-17 14:09:13 -07:00
MinRK
16e8d0ff43 adjust definition of 'path' in notebooks
never includes leading or trailing '/'
2013-10-17 14:09:13 -07:00
MinRK
e46412e30f fix --notebook-dir configurable when there is no trailing slash 2013-10-17 14:09:13 -07:00
MinRK
cded90efe3 update json_errors decorator
separate handling of HTTPError and unhanded exceptions
2013-10-17 14:09:13 -07:00
MinRK
141d088a51 logo link to current tree level
rather than top level
2013-10-17 14:09:13 -07:00
MinRK
40f577b538 add utils.url_path_join
javascript equivalent of Python-side function.
2013-10-17 14:09:13 -07:00
MinRK
dd93a2211a add utils.js to tree template 2013-10-17 14:09:13 -07:00
MinRK
c79dcc8e73 quote data attributes
prevents errors when these are empty strings
2013-10-17 14:09:13 -07:00
Zachary Sailer
da58c8c470 Fixed session js ajax request.
Session was not creating a kernel object on the client side,
after the server created successfully created a session.
2013-10-17 14:09:12 -07:00
Zachary Sailer
d3e456d9a1 add tests to notebooks api
- check for correct status codes
- check headers location
- fix COPY api
2013-10-17 14:09:12 -07:00
Zachary Sailer
9e0beba86f adding to test_kernels_api.py
- Check all HTTP status code responses for requests
- Test invalid kernel IDs
- Check 'location' key in POST request to kernels
2013-10-17 14:09:12 -07:00
Zachary Sailer
c26700cd3a changes after session manager code review 2013-10-17 14:09:12 -07:00
Zachary Sailer
7aaaab0668 fixed notebook rename after nbmanager refactor 2013-10-17 14:09:12 -07:00
MinRK
14fd50f80b Simplify Tree handlers
- 404 on missing path
- only need one handler for each of redirect and dashboard,
  don't need duplicates.
- project property on Handlers is unclear
2013-10-17 14:09:12 -07:00
MinRK
ed66b8b8fe add path2url and url2path to html.utils 2013-10-17 14:09:12 -07:00
Zachary Sailer
2a946c62ab added tests to nbmanager for url encode/decode 2013-10-17 14:09:11 -07:00
Zachary Sailer
97bc426bb7 add error catching to kernel manager
also, adding further tests to kernel manager
2013-10-17 14:09:11 -07:00
Brian E. Granger
c0bc0410ce Review and refactoring of notebooks web service. 2013-10-17 14:09:11 -07:00
MinRK
5568cd5db0 ensure test_no_kernels runs first
since it expects a clean notebook server.
2013-10-17 14:09:11 -07:00
MinRK
b0468580f7 don't start new notebook server for each test *method*
it takes much too long.

This change starts a new notebook server for each test class.

Even that is probably too much, but the module organization makes it troublesome
to start a single notebook server for all services tests.
2013-10-17 14:09:11 -07:00
Zachary Sailer
27680dacb2 Code review changes.
Fixed handler issues and api tests from code review
from @minrk and @carreau.
2013-10-17 14:09:11 -07:00
Brian E. Granger
2d6f4628c4 Adding JSON error handling and fixing location headers. 2013-10-17 14:09:10 -07:00
Zachary Sailer
04c6a3cfac refactoring of nbmanager and filenbmanager
major clean up of the two managers. We make sure to follow
the standard models described in IPEP 16
2013-10-17 14:09:10 -07:00
Zachary Sailer
050a3098a8 review fixes on tests, add extra kernel api test 2013-10-17 14:09:10 -07:00
Zachary Sailer
e9ac1c2d37 add tests for session api 2013-10-17 14:09:10 -07:00
Zachary Sailer
8ce586a241 move notebooks api tests into notebooks/tests 2013-10-17 14:09:10 -07:00
Paul Ivanov
f517d44d4b removing contents changes from this PR 2013-10-17 14:09:10 -07:00
Zachary Sailer
95b505d602 Added notebooks API tests. 2013-10-17 14:09:10 -07:00
Zachary Sailer
5f1b7727d8 fix bug in test_contentmanager 2013-10-17 14:09:09 -07:00
Brian E. Granger
136a19e5eb Added base class for Notebook API tests. 2013-10-17 14:09:09 -07:00
Zachary Sailer
483d16c8ed clean kernel manager 2013-10-17 14:09:09 -07:00
Zachary Sailer
22e351ae3b cleaning nb handlers, adding doc-strings/comments 2013-10-17 14:09:09 -07:00
Zachary Sailer
8c2009874c session manager restructuring
Redid the sessionmanager, added tests for the session manager,
and added a sqlite database to hold kernel,session,nb mapping.
2013-10-17 14:09:09 -07:00
Paul Ivanov
b8318708eb clean up of get_os_path and its tests
work with @Zsailer
2013-10-17 14:09:09 -07:00
Zachary Sailer
34b9840786 fixing broken links from recent changes.
After fixing operating system path changes in previous commits,
many links needed to be adjusted to direct to the correct URL.
2013-10-17 14:09:09 -07:00
Zachary Sailer
470595f9e7 handle path separators with os.sep and add tests
Added more tests to the notebook manager to check for the correct
path separators on different operating system. Fixed the get_path
method.
2013-10-17 14:09:08 -07:00
Zachary Sailer
bdbe30dc3a url encode/decode tests added to nbmanager 2013-10-17 14:09:08 -07:00
Paul Ivanov
f42de98c5b use new assumptions for named_notebook_path 2013-10-17 14:09:08 -07:00
Paul Ivanov
7ca8a21bf6 named_notebook_path: consistent usage convention 2013-10-17 14:09:08 -07:00