Jonathan Frederic
c7860d8bc8
Post in person review
...
Removed logic for reverse ordered events
Removed almost all of the log statements
Removed list for should unfocus callbacks
Removed all the logic in focus_editor
Only call focus_editor if the keyboard was used to enter edit mode
2014-02-27 15:45:06 -08:00
Jonathan Frederic
3595c099c2
Fixed rebase problems
2014-02-27 15:45:06 -08:00
Jonathan Frederic
10d79a9102
Added cell unfocus event canceller API
2014-02-27 15:45:05 -08:00
Jonathan Frederic
a6aaa8a886
Use is_focused for element kbman removal event
2014-02-27 15:45:05 -08:00
Jonathan Frederic
6f7c502157
Fixed lots of bugs
...
Half overhaul of notebook focus events...
2014-02-27 15:45:05 -08:00
Jonathan Frederic
206d35a89e
DEBUG
...
Added lots of log calls and a couple small 'fixes' (attempts)
2014-02-27 15:45:05 -08:00
Jonathan Frederic
7913305312
jshint
2014-02-27 15:45:05 -08:00
Thomas Kluyver
0059c317c3
Merge pull request #5216 from minrk/notebook-dir-cli
...
fixup positional arg handling in notebook app
2014-02-27 15:13:37 -08:00
Min RK
4038421da6
Merge pull request #5221 from jdfreder/ctuple
...
Change widget children List to Tuple.
2014-02-26 20:42:01 -08:00
MinRK
bdde544d47
don't forget base_url when updating address bar in rename
2014-02-26 15:01:07 -08:00
Paul Ivanov
7d1da4c550
refer to notebooks, not kernels.
2014-02-26 12:35:20 -08:00
MinRK
d8b6a1a0ba
don't validate ContainerWidget.children
...
just use a plain Tuple, so we don't have to define a new Trait
2014-02-25 19:08:43 -08:00
Paul Ivanov
b74b10e308
added IPython.session_list
...
before this, kernel_list and notebook_list each fetched and held onto
their own copy of the sessions.
2014-02-25 18:09:16 -08:00
Jonathan Frederic
6c1ef48f1a
Merge pull request #5173 from jdfreder/movewidgets
...
Moved widget files into static/widgets/*
2014-02-25 16:14:10 -08:00
MinRK
cc1ba8b1f7
remove incorrect is instance check in children_changed
2014-02-25 15:00:48 -08:00
MinRK
c89ec19fca
don't check shape of ContainerWidget.children
2014-02-25 14:37:12 -08:00
Jonathan Frederic
7855de2f13
s/CTuple/Tuple
2014-02-25 13:50:58 -08:00
Jonathan Frederic
dedbc3b0e1
Changed children list to CTuple.
...
Also removed some unused refences in the widget code
and added support for tuples in the pack/unpack code.
2014-02-25 09:46:27 -08:00
Min RK
0117b587ab
Merge pull request #4985 from damianavila/closebrackets
...
Enable autoCloseBrackets in CodeMirror by default.
2014-02-25 09:04:22 -08:00
MinRK
bb7f27541f
write config instead of direct assignment from the command-line
...
Gross.
2014-02-24 15:48:43 -08:00
MinRK
6e09314027
fixup positional arg parsing in notebook app
...
- `ipnb .` triggers override of sub-config, even when the parent isn't changed
- `ipnb /path/nb.ipynb` sets notebook_dir to `/path`
2014-02-24 15:42:49 -08:00
Paul Ivanov
06c689caa3
remove reiterated repetitively redundant "actively"
2014-02-24 15:02:08 -08:00
Paul Ivanov
a2b9c75e93
don't double-join the notebook path
2014-02-24 14:18:22 -08:00
Paul Ivanov
a27168ae3b
refresh of Notebook list should reload sessions
2014-02-24 13:12:15 -08:00
Paul Ivanov
af90cd8c62
fix typo in method name
2014-02-24 13:11:50 -08:00
Paul Ivanov
cb1bb62272
ok, Running tab is working now
2014-02-24 13:11:13 -08:00
Min RK
c73acb300f
Merge pull request #5200 from Carreau/jinja-no-cache
...
Allow to pass option to jinja env
2014-02-23 22:15:29 -08:00
Matthias BUSSONNIER
816df5bb34
Allow to pass option to jinja env
...
Mainly to pass cache_size=-1 while developping not to cache templates
2014-02-23 23:28:57 +01:00
zah
439003d709
Children fire event
...
Now when a container widget is displayed, the _handle_displayed method
of each of its children is fired.
2014-02-23 20:31:39 +01:00
MinRK
e02308e436
capture logging in a few tests
...
this could probably be made more general,
but these were the two places I noticed log output.
2014-02-22 21:12:19 -08:00
Fernando Perez
371afec677
Merge pull request #5112 from minrk/completion-band-aid
...
Band-aid for completion in the notebook: not the ideal solution, but will have to do the job for now so that typing while completing works.
closes #4860
2014-02-21 18:08:19 -08:00
Brian E. Granger
708c30c912
Merge pull request #5136 from minrk/interact-default
...
set default value from signature defaults in interact
2014-02-21 16:28:52 -08:00
Brian E. Granger
edb8d68331
Merge pull request #5132 from minrk/oops-pdf-transform
...
remove application/pdf->pdf transform in javascript
2014-02-21 16:28:12 -08:00
Brian E. Granger
7a35e2a0be
Merge pull request #5116 from minrk/os_path
...
reorganize who knows what about paths
2014-02-21 16:27:05 -08:00
Jonathan Frederic
28423647a2
Updated require references to point to new files
2014-02-21 16:25:52 -08:00
Jonathan Frederic
e0ba52c802
Moved widget files into static/widgets/*
...
Since they do not depend on anything ntoebook related
2014-02-21 16:25:52 -08:00
Min RK
612acd2e08
Merge pull request #5170 from jdfreder/widget-throttle-trait
...
Added msg_throttle sync=True widget traitlet
2014-02-21 15:32:10 -08:00
MinRK
386274488d
don't create notebook_dir if it doesn't exist
2014-02-21 13:22:57 -08:00
MinRK
d37780c6a6
use config instead of App.instance to propagate notebook_dir
...
Should behave more logically (I hope).
2014-02-21 13:22:57 -08:00
MinRK
f9e8824fef
use NotebookManager APIs in nbconvert handler
2014-02-21 13:22:56 -08:00
MinRK
cb25736a24
reorganize who knows what about paths
...
- add NotebookApp.notebook_dir
- add KernelManager.root_dir
- remove NotebookManager.notebook_dir, move to FileNBM.notebook_dir
Default value for KM.root_dir and fNBM.notebook_dir is NotebookApp.notebook_dir, but they can be configured separately.
SessionManager passes the API path to KernelManager,
which is responsible for turning it into the kernel's cwd.
2014-02-21 13:22:56 -08:00
Brian E. Granger
eda4569099
Merge pull request #5037 from jdfreder/ff-widget-align
...
FF Fix: alignment and scale of text widget
2014-02-21 12:37:40 -08:00
Jonathan Frederic
ef3f61f906
Use set_rendered to set the error msg of the cell.
2014-02-21 10:31:29 -08:00
Jonathan Frederic
946212d5fa
Treat set_rendered as unsafe.
2014-02-21 10:05:07 -08:00
Jonathan Frederic
407fc0a017
s/with with/with
2014-02-21 09:42:14 -08:00
Jonathan Frederic
6a224d131b
Move todos into set_rendered
2014-02-21 09:40:14 -08:00
MinRK
62f318c777
undo failed changes
...
before raising
otherwise, invalid values were still accepted
2014-02-20 22:57:01 -08:00
MinRK
37cb0fbdee
remove websocket url
...
websockets should follow the kernel URL
(normal behavior is unchanged, only unused configurability is removed)
2014-02-20 22:54:36 -08:00
MinRK
b51cc50357
further tests for default values in interact
...
both valid and invalid
2014-02-20 22:37:04 -08:00
MinRK
acfc2d5308
set default value from dict
2014-02-20 22:36:42 -08:00
Paul Ivanov
3b109de563
minimal KernelList
2014-02-20 17:37:46 -08:00
Brian E. Granger
4bd315bda0
Merge pull request #5147 from minrk/static-url-version
...
Some template URL changes
2014-02-20 17:05:09 -08:00
Paul Ivanov
b3c1164798
put Running tab on the page
2014-02-20 17:01:51 -08:00
Brian E. Granger
db4960769b
Merge pull request #5100 from minrk/base_kernel_url
...
remove base_kernel_url
2014-02-20 17:00:38 -08:00
Jonathan Frederic
ad03225cf6
Audit .html() calls take #2
2014-02-20 15:46:44 -08:00
Jonathan Frederic
82bbcf166d
Fixed .. typo
2014-02-20 13:14:37 -08:00
Jonathan Frederic
0e56051a01
Added parentheses to emphasize order of op.
2014-02-20 08:48:05 -08:00
Jonathan Frederic
0eebd9e05b
Added msg_throttle sync=True widget traitlet
2014-02-20 08:41:05 -08:00
Jonathan Frederic
cecf7cf06f
Fixed radio button selector for new radio button class
2014-02-19 14:48:21 -08:00
Jonathan Frederic
d1d863af86
fab css
2014-02-19 14:14:14 -08:00
Jonathan Frederic
3b8beec541
Added a class for RadioButtons container
...
with appropriate top padding...
2014-02-19 14:14:14 -08:00
Jonathan Frederic
033ea6d88c
Added bottom margin to text widget
2014-02-19 14:14:14 -08:00
Paul Ivanov
efc01b8854
remove append_json reference
...
we never had such a method
2014-02-18 23:41:10 -08:00
Paul Ivanov
7b5c834649
fix IPython typo, closes #5155
2014-02-18 21:10:25 -08:00
MinRK
69cba774d9
Some template static_url tweaks
...
- don't try to include version in static_urls that don't point to files
- use full static_urls (with extension) for backbone and underscore, so version can be computed
closes #5141
2014-02-18 14:09:56 -08:00
Jonathan Frederic
a7fb5e1e55
Merge pull request #5114 from minrk/empty-button
...
use non-breaking space for button with no description
2014-02-17 08:37:08 -08:00
MinRK
e91ef370dd
remove no-op adding abbreviations from always-empty dict
2014-02-16 15:17:23 -08:00
MinRK
8a2d92010a
set default value from signature defaults in interact
...
If available, use the default value from the signature for the initial condition,
when using range/choice abbreviations.
Not affected:
- single-value abbreviations (`@interact(a=5)` sets `a=5`)
- explicit Widgets
2014-02-16 15:11:39 -08:00
MinRK
ea8896399b
remove application/pdf->pdf transform in javascript
...
We have the old transforms because they were added before we realized it was a bad idea. We should not add new ones.
2014-02-15 13:21:37 -08:00
Thomas Kluyver
d6986cf4ec
Merge pull request #4778 from minrk/install-nbextensions
...
add APIs for installing notebook extensions
2014-02-14 15:21:15 -08:00
MinRK
1ed5b184fb
test installing nbextensions with symlink
2014-02-14 15:02:02 -08:00
MinRK
8353e85e48
test check_nbextension
2014-02-13 19:46:36 -08:00
MinRK
e903297a15
clarify with all in check_nbextension
2014-02-13 19:38:16 -08:00
MinRK
475ac234b4
typo
2014-02-13 19:37:57 -08:00
Thomas Kluyver
df0743c41c
Merge pull request #5097 from minrk/logging-some-more
...
minor notebook logging changes
2014-02-13 17:26:01 -08:00
MinRK
59d3a8ff5f
handle empty string in ToggleButtonsWidget
2014-02-13 11:08:45 -08:00
MinRK
9c452998ea
add utils.escape_html
2014-02-13 11:08:44 -08:00
MinRK
0eff2bb651
handle space-only strings, not just zero-length
2014-02-13 11:08:44 -08:00
MinRK
c50096334c
use non-breaking space for button with no description
...
to preserve button's size
reverses some inappropriate replacements of .html with .text.
closes #5113
2014-02-13 11:08:44 -08:00
MinRK
fd346d1790
fix remove event in KeyboardManager.register_events
...
only call enable on remove when focused.
fixes a bug where command mode could be entered inappropriately
when non-focused elements are removed from the page
(see first `@interact` example).
2014-02-13 10:51:33 -08:00
Min RK
3306e386d6
Merge pull request #4925 from khinsen/notebook-manager-api
...
Notebook manager API fixes
remove various `_model` suffixes
2014-02-12 21:36:47 -08:00
MinRK
a1e263785c
band-aid for completion
...
Unlike @Carreau's attempt at using proper CodeMirror completion,
this is just a band-aid to get the existing completion back to working for 2.0.
This adds a keypress handler on the completer,
which then calls insert with the charCode of the key press event,
replacing the final `elif` branch of the keydown handler.
This cannot be done with keydown,
since keydown doesn't know what character is incoming,
only the hardware key that is struck.
2014-02-12 17:21:40 -08:00
MinRK
a184724bdb
remove base_kernel_url
2014-02-11 21:26:10 -08:00
MinRK
e5df456949
minor notebook logging changes
...
log refer only on 4XX, and never log user agent
This function was ported from nbviewer, and some of the choices were not quite right for the notebook server.
2014-02-11 15:33:07 -08:00
Brian E. Granger
24c27ce5e5
Merge pull request #5059 from jdfreder/widgets-patch-fix
...
Fix incorrect `Patch` logic in widget code
2014-02-11 14:51:53 -08:00
Brian E. Granger
46c88a8875
Merge pull request #5075 from jdfreder/flex-model-2
...
More flexible box model fixes
2014-02-11 14:41:11 -08:00
Konrad Hinsen
fdb8ab37ae
Rearrange the NotebookManager methods for clarity
...
Methods are organized into three categories:
- Methods that must be implemented in subclasses
- Methods that have default implementations, but can
be overridden if required.
- Support methods meant to be called by methods in subclasses
2014-02-11 12:30:19 +01:00
Konrad Hinsen
b1c6ba2c97
Move method increment_filename from FileNotebookManager to NotebookManager
...
The implementation requires only a minor change (call notebook_exists
rather than checking for file existence) to be universally usable
in other notebook managers.
2014-02-11 12:26:57 +01:00
Konrad Hinsen
0a430f5840
Add method notebook_exists to NotebookManager.
...
It is called by IPython.html.notebook.NotebookHandler.get,
so it must be implemented by every notebook handler.
2014-02-11 12:26:06 +01:00
Konrad Hinsen
26e3e31ad8
NotebookManager API: rename *notebook_model methods to *notebook
2014-02-11 12:25:57 +01:00
Jonathan Frederic
1c564131c5
Fixed, set on recieve update triggering echos.
2014-02-10 15:46:28 -08:00
Jonathan Frederic
3d408f5241
Added a test to make sure full state was not getting sent.
2014-02-10 15:46:05 -08:00
Jonathan Frederic
7b2787e508
Fixed typo
2014-02-10 14:50:49 -08:00
Jonathan Frederic
f4f2c92285
Keep a running diff instead of forcing a full state update
2014-02-10 14:50:49 -08:00
Jonathan Frederic
770d2bd3a0
Only send diff message if diff isn't corrupt.
...
Diff will corrupt if more then one model.set(...) call is made
before model.save (or view.touch() in our case).
2014-02-10 14:50:49 -08:00
Jonathan Frederic
fbf700e5d2
Fixed typo in new test
2014-02-10 14:50:49 -08:00
Jonathan Frederic
a173e684c6
Added test that shows the problem.
2014-02-10 14:50:49 -08:00
Jonathan Frederic
5667947f9d
Revert "Let backbone get changed attrs"
...
This reverts commit 4dd4990ff146508894353e390601c659d2638ed3.
2014-02-10 14:50:49 -08:00
Jonathan Frederic
36b576b0bd
Let backbone get changed attrs
2014-02-10 14:50:49 -08:00
Jonathan Frederic
cd72883fc7
Revert "Fix incorrect usage of attrs"
...
This reverts commit 04aa0885bb143fd0409fe133ca572004ffa6dc0e.
2014-02-10 14:50:49 -08:00