Commit Graph

125 Commits

Author SHA1 Message Date
Jeremy Tuloup
068175ab0c
Update to JupyterLab 4.0.6 (#7049)
* Update to JupyterLab 4.0.6

* fix app_version

* reuse upstream config
2023-09-15 09:36:40 +02:00
adigaboy
7b329b4269
fix trusted status indication (#7036)
* fix isTrusted with check cell type

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* camelCase and redundant ;

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-09-08 10:21:01 +02:00
Jeremy Tuloup
76db867671
Update to JupyterLab 4.0.5 (#7013)
* Update to JupyterLab 4.0.5

* Update Lumino

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-08-16 13:17:17 +02:00
Mikil Lalwani
4d8ac2635c
Added documentation link in Help menu (#6993)
* Added dcumentation link

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-08-01 08:00:14 +02:00
Jeremy Tuloup
77f87de5c7
Close the browser tab when clicking on "Close and Shut Down Notebook" (#6937)
* Close the browser tab when clicking on "Close and Shut Down Notebook"

* Move menu entry to match classic

* Fix menu entries

* Add comment about the rank

* Use default `isEnabled`

* Update Playwright Snapshots

* Update Playwright Snapshots

* Add UI test

* Rename to "Close and Shut Down Notebook"

Co-Authored-By: Andrii Ieroshenko <ieroshenkoa@gmail.com>

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrii Ieroshenko <ieroshenkoa@gmail.com>
2023-06-22 09:41:45 +02:00
Jeremy Tuloup
ab57fa1d20
Customize the shell layout with the settings (#6921)
* Add settings file

* Add support for layout customization

* Fix tests

* Add `type` option

* Fix opening document widgets

* Fix opening documents

* Add defaults for Markdown Preview

* Add docs

* Add screenshots

* Add `@jupyterlab/attachments`

* Fix integrity

* Add simple UI tests for layout customization

* Lint

* Update Playwright Snapshots

* Update Playwright Snapshots

* Update docs

* Add missing null

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-06-15 09:47:29 +02:00
Eric Gentry
ee3e1c2212
Fix for "find searches only part of the file" bug (#6905)
* Enabled the Accel F shortcut by default for documentsearch.

* Update Playwright Snapshots

* Update Playwright Snapshots

* Added tentative find-plugin docs, WIP.

* Removed file with shortcut override.

* Cleanup/removal of todo.

* Update docs/source/notebook.md

Co-authored-by: Andrii Ieroshenko <ieroshenkoa@gmail.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Co-authored-by: Andrii Ieroshenko <ieroshenkoa@gmail.com>
2023-06-12 08:33:00 +02:00
Andrii Ieroshenko
92f2336793
Add option to open a notebook in NbClassic if it is installed; show "Open in..." dropdown menu if there are multiple options, show single button otherwise (#6866)
* add option to open in nbclassic if installed

* account that getOption() can return truthy 'false'

* immidiately convert nbclassicInstalled to boolean

* Capitalize NbClassic as in PyPI per @JasonWeill

* capitalize commandDescription

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/lab-extension/src/index.ts

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* add openInNewIcon based on ##6793 by @JasonWeill

* show single 'open' button if only one option is available

* add button styling

* add css class to toolbarButton

* rename addCommand to addSwitcherCommand

* set page_config["nbclassic_installed"]

* Update snapshots

* fix general.spec.ts lint problem as detected in CI run https://github.com/jupyter/notebook/actions/runs/5008582825/jobs/8976612053?pr=6866

* Use optional chaining instead of non-null assertion to fix lint error https://github.com/jupyter/notebook/actions/runs/5008628805/jobs/8976713072?pr=6866

* add new line to try to fix eslint error

* fix prettier CI errors

* Revert "fix general.spec.ts lint problem as detected in CI run https://github.com/jupyter/notebook/actions/runs/5008582825/jobs/8976612053?pr=6866"

This reverts commit 9f0b54409f6a6b2c0be750f6ddaac1d435f622ae.

* Revert "add openInNewIcon based on ##6793 by @JasonWeill"

This reverts commit eca0a4e8fafe38307a1081b24615be0b0ab8502d.

* use launchIcon instead of openInNewIcon

* fix nbclassic urlprefix

* update general snapshots to account for use of launchIcon

* update mobile snapshots to account for launchIcon

* check if extension is enabled, not installed

* add bundled server extension

* Revert "add bundled server extension"

This reverts commit 7d261db4a987980b82bb8ca917ebc8f82d76e85d.

* set page_config in initalize_handlers

---------

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
2023-06-09 07:15:07 +02:00
Jeremy Tuloup
245bc87ecf
Add the notification plugin (#6900)
* Add the notification plugin

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-06-06 18:22:21 +02:00
Ashriel
a605fa9bdb
Enhancement: Added drop shadows to markdown, text, and tree views (#6893)
* Added Drop Shadows

Adjusted drop shadows for tree view, markdown and text notebooks.

* Update: Corrected Tree View Shadows

Tree View drop shadow values are in co-ordination with the others.

* Responsive padding for main-panel

Adjusted main-panel padding to be responsive

* Update: media-query rearranged

* Update: Body selectors with filters

Added data-format body selectors to the css

* Re-written media query

Re-wrote the media query for allowing responsiveness without a refresh

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-06-01 09:11:19 +02:00
Jeremy Tuloup
fd45f31f98
Add file browser actions to the file browser toolbar (#6888)
* Add component to provide file browser actions

* Fix usesignal

* Lint

* Flex display

* CSS fixes

* Undo unrelated change

* Patch methods directly

* Fix folder selection

* Update Playwright Snapshots

* Update Playwright Snapshots

* Add link to the upstream issue

* Add UI tests

* Lint

* Tweak delete button color

* Move to a separate plugin

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-05-29 16:45:53 +02:00
Jeremy Tuloup
9863625809
Provide a custom rendermime plugin to handle local links (#6885)
* Provide a custom rendermime plugin

* Lint

* Add UI tests for local links

* Ignore check link in the test notebook

* Improve tests
2023-05-25 17:10:16 +02:00
tuncbkose
c77ebdcfbf
Enable add a cell button (#6872)
* Enable add a cell button

* workaround for Firefox

* Lint

---------

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-05-16 15:45:57 +02:00
Jeremy Tuloup
17286813b0
Update to Playwright 1.33 (#6874)
* Update to Playwright 1.33

* Update Firefox snapshots
2023-05-16 13:28:22 +02:00
Kenny Timmer
855822d648
Remove "Close Tab" menu entry (#6843)
* remove Close Tab from menu entry

* Disable the close tab menu entry

* Update snapshots

---------

Co-authored-by: timmerk <timmerk@umich.edu>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-05-14 12:04:37 +02:00
Andrii Ieroshenko
d7d110c551
Change "Interface" menu to "Open in...", shorten names of menu items inside (#6847)
* rename commandLabel

* attemp to keep longer name in command palette

* Remove trying to keep longer name for command palette

* Attempt to register 2 commands to show the same command in the command palette

* fix passing paletteCommand to palette.addItem

* account for "args" being potentially passed to label

* change command palette wording to "Open in"

* capitalize "in" in "Open In..." btn title for consistency

* Make "in" not capitalized in "Open in..."

* use 'Open in %1' string formation form

* Update snapshots

* rename commandPaletteLabel into commandDescription

* use command with description as a label in view menu

* update snapshots manually

* update more snapshots manually

* Use isPalette and isMenu

* Lint

---------

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-05-05 09:14:08 +02:00
Jeremy Tuloup
787339c09e
Update to JupyterLab 4.0.0b1 and 4.0.0b2 (#6838)
* Update to JupyterLab 4.0.0b1

* fix resolutions

* more updates

* Remove previous shortcuts plugin

* Bump `jupyter_server` dependency

* Align playwright dependency

* Update to JupyterLab 4.0.0b2

* fix some deps

* Update yarn.lock

* add util fallback

* style the footer

* fix footer background

* move mouse before taking the screnshot

* update ui tests yarn.lock

* disable the notebook footer for now

* update snapshots
2023-04-27 10:12:43 +02:00
Nicolas Brichet
f0ec5f30e9
Fixes the notebooktools (#6834)
* Fixes the notebooktools

* Updates snapshots
2023-04-05 23:28:09 +02:00
Jeremy Tuloup
7903de83e8
Update to JupyterLab 4.0.0a37 (#6777)
* Update JupyterLab and Lumino packages

* fix resolutions

* Update to TypeScript 5 final

* Reuse upstream sessionDialogs plugin

* update gitpod setup

* Update UI tests setup

* Update npmClient

* try without immutable

* add explicit playwright dep

* Update mathjax package

* update yarn.lock

* update dev dependencies

* lint

* update yarn.lock

* Fix typescript dependency

* fix metapackage
2023-03-20 13:49:22 +01:00
Jeremy Tuloup
0faa88c8b6
Update to JupyterLab 4.0.0a36 (#6773)
* Update to JupyterLab 4.0.0a36

* Update `webpack`

* Refresh deps

* fix yarn.lock

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-03-15 09:50:55 +01:00
Afshin Taylor Darian
f44ac97b74
Clean up interface switcher plugin in preparation for release (#6766)
* Clean up interface switcher plugin in preparation for release

* Use caret down icon to be consistent with the "New" dropdown in the tree page

* Update Playwright Snapshots

* Update Playwright Snapshots

* Fix button height of interface switcher

* Update packages/lab-extension/style/base.css

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-03-14 09:47:17 +01:00
pre-commit-ci[bot]
b591d61ed1
[pre-commit.ci] pre-commit autoupdate (#6762)
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/charliermarsh/ruff-pre-commit: v0.0.237 → v0.0.254](https://github.com/charliermarsh/ruff-pre-commit/compare/v0.0.237...v0.0.254)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update ruff

* Lint conftest

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
2023-03-07 15:47:57 +01:00
Jeremy Tuloup
4a0387f6c4
Update to JupyterLab 4.0.0a35 (#6757)
* Update deps

* Drop `skipLibCheck`

* Integrity fixes

* Fix deps

* Enable the file size column by default

* Fix yarn.lock

* Enable file name search toolbar item

* Update Playwright Snapshots

* Update Playwright Snapshots

* Try set overflow options explicitly

* Update Playwright Snapshots

* Update to the latest Lumino 2 rc

* Fix yarn.lock

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-03-07 14:42:48 +01:00
Jeremy Tuloup
e7b5c3701b
File browser CSS tweaks (#6738)
* File browser CSS tweaks

* Set tabsMovable to false

* Style file browser buttons

* Add missing headers

* Update Playwright Snapshots

* Update Playwright Snapshots

* Lint

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-02-20 09:26:10 +01:00
Jeremy Tuloup
dc3c26f93f
Add trusted indicator (#6736)
* Add trusted indicator

* Lint

* Add docstring

* Fix retro names

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-02-17 09:17:25 +01:00
Jeremy Tuloup
ef67879306
Update to JupyterLab 4.0.0a34 (#6732)
* Update `@jupyterlab` and `@lumino`packages

* Remove docprovider and collaboration packages

* Fix rendermime

* Drop `@types/react`

* Fix `ICompletionProviderManager`

* Bump jupyterlab Python package

* Update Jupyter Server config

* Ignore F821 for now

* Try `LabServerApp`

* Update Playwright Snapshots

* Update Playwright Snapshots

* Remove the `--collaborative` flag

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-02-15 08:34:26 +01:00
Jeremy Tuloup
80c04e1aa2
Hide the debugger button on mobile (#6731)
* Hide the debugger button on mobile

* Update Playwright Snapshots

* Update Playwright Snapshots

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2023-02-14 13:21:10 +01:00
Nicolas Brichet
905553e6dd
Resolving some accessibility issues (#6719)
* Uses different ID for the running-session widgets, the one in main view and the one in panel

* Append kernel logo image only if necessary

* Add title to the button which close sidebar

* Add landmarks roles

* Fix UI-test

* lint
2023-02-09 10:26:40 +01:00
Jeremy Tuloup
27c2bfbb80
Update to JupyterLab 4.0.0a33 (#6713)
* Update to JupyterLab 4.0.0a33

* Update Lumino packages

* Update to React 18

* Fix default browser

* Add defaultFileBrowser plugin

* Update yarn.lock

* Require Python 3.8

* Remove docprovider

* Bump Python dependencies

* Move Python bumps

* Unbump `jupyterlab_server`

* Align `jupyterlab_server`dep

* Bump jupyterlab_server

* Try with 3.10

* Manually set checkpoint text in UI tests

* Fix checkpoints value in UI tests

* Update snapshots
2023-02-07 14:52:18 +01:00
Jeremy Tuloup
df4a6bfc55
Add the Settings Editor to the landing page (#6316)
* Add the Settings Editor to the landing page

* Fix tab panel tabs

* Do not include JSON editor for now

* Hide Settings Editor command from the menu

* Update yarn.lock

* Fix integrity

* Fix yarn.lock and resolutions

* Update yarn.lock

* Allow adding and closing the settings editor

* Do not include JSON editor for now

* Update snapshots

* More snapshot updates

* More snapshot update

* Fix resolutions
2023-01-13 08:20:57 +01:00
Nicolas Brichet
a0b3a8088c
Tree view enhancement (#6588)
* Opens by default the newly created tab in tree view

* Adds a command to open the file browser when in tree view, which also fixes the broken menu entry 'file Browser' in view

* (1) Remove the menu entry 'Open Files' in tree view, which was opening a new browser tab with the same contents, and was like a duplication of 'File Browser' entry, and (2) rename the menu entry 'Open Files' to 'File Browser' for consistency

* Add test on 'File Browser' menu entry

* Fix pre-commit

* Fix test on File Browser menu entry

* update snapshots of view menu

* Do not activate newly created tree tab by default

* Do not add 'openTree' command if it already exists (meaning that the current page contains a filebrowser plugin)

* Wait for the file browser commands from JupyterLab to be fully created before create a new one

* File Browser menu entry execution depends on the current page ('tree' or other)

* Add the dependency to @jupyter-notebook/tree in application-extension

* Fix typo

* Remove dependency to tree in application-extension

* Clean unused dependency

* Delete a remaining comment
2023-01-12 13:40:28 +01:00
Jeremy Tuloup
6205bf376f
Update to JupyterLab 4.0.0a32 (#6678)
* Update packages to JupyterLab 4.0.0a32

* Update python dependency

* Update `@jupyterlab/galata`

* Require `jupyter_server>=2.0.1,<3`

* Undo `jupyter_server` bump for now

* Update to Jest 29

* More jest fixes

* Update to the latest Lumino

* Fix yarn.lock

* Fix JSON background color

* Update snapshots
2023-01-09 15:50:12 +01:00
Steven Silvester
48fb973071
CI Cleanup (#6667)
* ci cleanup

* lint

* run ui tests on ubuntu 20.04
2022-12-19 14:37:55 +01:00
Steven Silvester
22475a39ab
Adopt ruff and typing (#6658)
* adopt ruff and typing

* reinstate local hooks

* fix classifier

* fix lint

* limit ruff target

* fix doc8 test

* add integrity check

* lint

* lint

* only use mdformat for changelog

* prettier
2022-12-11 17:07:54 +01:00
Nicolas Brichet
c4a6e8bd90 Move panel related objects to a dedicated module file to improve readability 2022-11-17 15:41:12 +01:00
Jeremy Tuloup
820ee98806 Update kernel menu snapshot for firefox 2022-10-06 14:43:36 +02:00
Jeremy Tuloup
708928b2f0 Try resize workaround in tests for now
Fix order of selectors
2022-10-06 13:34:33 +02:00
Jeremy Tuloup
b893cf0d06 Wait for kernel ready before menu screenshots 2022-10-06 09:53:56 +02:00
Jeremy Tuloup
12119f97b3 Fix what looks like a rebase issue 2022-10-06 09:30:38 +02:00
Jeremy Tuloup
f6b65e3bae Tweak menu tests 2022-10-06 08:31:33 +02:00
Jeremy Tuloup
02a164d7f0 Remove shutdownAll in the menu tests 2022-10-05 23:30:53 +02:00
Jeremy Tuloup
3f8c55831a Update toc snapshot for Firefox 2022-10-05 22:59:36 +02:00
Jeremy Tuloup
55cd158fa0 Update more reference snapshots 2022-10-05 22:11:05 +02:00
Jeremy Tuloup
7d5691ed9a Try fixing UI test race conditions 2022-10-05 20:51:41 +02:00
Jeremy Tuloup
1ed8e02e7b Update viewport width for mobile tests 2022-10-05 18:03:27 +02:00
Jeremy Tuloup
d9635e35a2 Try fixing the test opening JupyterLab 2022-10-05 17:20:24 +02:00
Jeremy Tuloup
ffadcbc543 Update some reference snapshots 2022-10-05 17:08:28 +02:00
foo
22089cd1ac update snapshot 2022-10-04 17:39:02 +02:00
foo
4463ed842f Specify the 'Shut Down All' button to click in smoke tour test (the one from main panel), as there is now a side panel containing the same button 2022-10-04 17:12:24 +02:00
foo
239e5b931c Updates after rebasing v7.0.0a6 2022-10-04 14:07:38 +02:00