mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Respect cell.is_editable during find-and-replace

Browse Source 
Find and replace (searchandreplace.js) will overwrite the contents of cells even if they are marked as non-editable. Add a check against the cell's is_editable() method to ensure this only happens for editable cells.
This commit is contained in:
Adam Blake 2020-06-20 13:05:57 -07:00 committed by GitHub
parent 9fa644bbe4
commit f2db0265d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
notebook/static/notebook/js/searchandreplace.js
View File

@ -308,6 +308,10 @@ define([
var cells = get_cells(env); var cells = get_cells(env);
for (var c = 0; c < cells.length; c++) { for (var c = 0; c < cells.length; c++) {
var cell = cells[c]; var cell = cells[c];
if (!cell.is_editable()) {
continue;
}
var oldvalue = cell.code_mirror.getValue(); var oldvalue = cell.code_mirror.getValue();
var newvalue = oldvalue.replace(reg , replaceValue); var newvalue = oldvalue.replace(reg , replaceValue);
cell.code_mirror.setValue(newvalue); cell.code_mirror.setValue(newvalue);