mirror of
https://github.com/jupyter/notebook.git
synced 2024-12-27 04:20:22 +08:00
Do not inject self in IPython namespace
And do not require nemaespace either - this is bad practice, and this prevent from writing a blended content manager that works both with drive and localhost as they shoudl both export themselves to IPython.Contents module.
This commit is contained in:
parent
f8968df7e2
commit
eaf8fdc4f9
@ -1,12 +1,12 @@
|
||||
// Copyright (c) IPython Development Team.
|
||||
// Distributed under the terms of the Modified BSD License.
|
||||
|
||||
define([
|
||||
'base/js/namespace',
|
||||
'jquery',
|
||||
'base/js/utils',
|
||||
], function(IPython, $, utils) {
|
||||
define(function(require) {
|
||||
"use strict";
|
||||
|
||||
var $ = require('jquery');
|
||||
var utils = require('base/js/utils');
|
||||
|
||||
var Contents = function(options) {
|
||||
/**
|
||||
* Constructor
|
||||
@ -245,8 +245,5 @@ define([
|
||||
return this.get(path, {type: 'directory'});
|
||||
};
|
||||
|
||||
|
||||
IPython.Contents = Contents;
|
||||
|
||||
return {'Contents': Contents};
|
||||
});
|
||||
|
Loading…
Reference in New Issue
Block a user