mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-01-12 11:45:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

show traceback in widget handlers

Browse Source 
rather than logging

closes #5064
This commit is contained in:
MinRK 2014-02-07 16:43:49 -08:00
parent 4f53aa2985
commit ddc22152ea
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
IPython/html/widgets/widget.py
View File

@ -14,6 +14,7 @@ in the IPython notebook front-end.
#----------------------------------------------------------------------------- #-----------------------------------------------------------------------------
from contextlib import contextmanager from contextlib import contextmanager
from IPython.core.getipython import get_ipython
from IPython.kernel.comm import Comm from IPython.kernel.comm import Comm
from IPython.config import LoggingConfigurable from IPython.config import LoggingConfigurable
from IPython.utils.traitlets import Unicode, Dict, Instance, Bool, List, Tuple from IPython.utils.traitlets import Unicode, Dict, Instance, Bool, List, Tuple
@ -33,7 +34,11 @@ class CallbackDispatcher(LoggingConfigurable):
try: try:
local_value = callback(*args, **kwargs) local_value = callback(*args, **kwargs)
except Exception as e: except Exception as e:
self.log.warn("Exception in callback %s: %s", callback, e) ip = get_ipython()
if ip is None:
self.log.warn("Exception in callback %s: %s", callback, e, exc_info=True)
else:
ip.showtraceback()
else: else:
value = local_value if local_value is not None else value value = local_value if local_value is not None else value
return value return value
@ -54,6 +59,18 @@ class CallbackDispatcher(LoggingConfigurable):
elif not remove and callback not in self.callbacks: elif not remove and callback not in self.callbacks:
self.callbacks.append(callback) self.callbacks.append(callback)
def _show_traceback(method):
"""decorator for showing tracebacks in IPython"""
def m(self, *args, **kwargs):
try:
return(method(self, *args, **kwargs))
except Exception as e:
ip = get_ipython()
if ip is None:
self.log.warn("Exception in widget method %s: %s", method, e, exc_info=True)
else:
ip.showtraceback()
return m
class Widget(LoggingConfigurable): class Widget(LoggingConfigurable):
#------------------------------------------------------------------------- #-------------------------------------------------------------------------
@ -241,6 +258,7 @@ class Widget(LoggingConfigurable):
value != self._property_lock[1] value != self._property_lock[1]
# Event handlers # Event handlers
@_show_traceback
def _handle_msg(self, msg): def _handle_msg(self, msg):
"""Called when a msg is received from the front-end""" """Called when a msg is received from the front-end"""
data = msg['content']['data'] data = msg['content']['data']