mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-04-24 14:20:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't paste cells in chrome when keyboard manager is disabled

Browse Source 
Closes gh-1316 (the second part of it, which I hadn't noticed before ;-)

If a widget, an input box or a dialog has focus, we should allow paste
to paste text by default. We already take care to disable the keyboard
manager in these cases, so I check this to decide to handle the paste
event.

In Firefox this isn't needed, because Ctrl+V is registered as the
shortcut to bring up the paste dialog, so it only works when the
keyboard manager is enabled.
This commit is contained in:
Thomas Kluyver 2016-04-07 13:48:12 -07:00
parent 2483331584
commit d797948420
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
notebook/static/notebook/js/clipboard.js
View File

@ -68,6 +68,19 @@ function paste(event) {
event.preventDefault();
}
function paste_direct(event) {
// If the focus is in a text widget or something (kbmanager disabled),
// allow the default paste event.
// The paste dialog implementation (for Firefox) can't do this check,
// because the keyboard manager will be disabled for the dialog when we try
// to paste. In that case, the shortcut to trigger the dialog will be
// inactive anyway when a widget or something is focussed, so we don't
// need the explicit check.
if (Jupyter.keyboard_manager.enabled) {
paste(event);
}
}
function needs_text_box_for_paste_event() {
// I know this is bad, but I don't know a better way to check this
return navigator.userAgent.indexOf('Firefox') !== -1;
@ -128,7 +141,7 @@ return {setup_clipboard_events: function() {
if (needs_text_box_for_paste_event()) {
setup_paste_dialog();
} else {
document.addEventListener('paste', paste);
document.addEventListener('paste', paste_direct);
}
}};
});