mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-02-11 12:30:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7081 from jasongrout/view-promises

Browse Source 
Wait for any promises returned by a view's render method before considering the view created
This commit is contained in:
Jonathan Frederic 2014-12-02 15:32:19 -08:00
commit ce0051c428
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
IPython/html/static/widgets/js/manager.js
View File

@ -101,8 +101,7 @@ define([
var parameters = {model: model, options: options}; var parameters = {model: model, options: options};
var view = new ViewType(parameters); var view = new ViewType(parameters);
view.listenTo(model, 'destroy', view.remove); view.listenTo(model, 'destroy', view.remove);
view.render(); return Promise.resolve(view.render()).then(function() {return view;});
return view;
}).catch(utils.reject("Couldn't create a view for model id '" + String(model.id) + "'", true)); }).catch(utils.reject("Couldn't create a view for model id '" + String(model.id) + "'", true));
}); });
return model.state_change; return model.state_change;