mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-02-05 12:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Increment the pending_msgs counter immediately to avoid race conditions that send more messages

Browse Source
This commit is contained in:
Jason Grout 2015-03-24 22:32:16 +00:00
parent c9f3c8e073
commit c70f687c0e
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
IPython/html/static/widgets/js/widget.js
View File

@ -347,6 +347,7 @@ define(["widgets/js/manager",
// We haven't exceeded the throttle, send the message like // We haven't exceeded the throttle, send the message like
// normal. // normal.
this.send_sync_message(attrs, callbacks); this.send_sync_message(attrs, callbacks);
this.pending_msgs++;
} }
} }
// Since the comm is a one-way communication, assume the message // Since the comm is a one-way communication, assume the message
@ -395,8 +396,11 @@ define(["widgets/js/manager",
} }
} }
that.comm.send({method: 'backbone', sync_data: state, buffer_keys: buffer_keys}, callbacks, {}, buffers); that.comm.send({method: 'backbone', sync_data: state, buffer_keys: buffer_keys}, callbacks, {}, buffers);
that.pending_msgs++; }).catch(utils.reject("Couldn't send widget sync message"), true)
}) .catch(function(error) {
that.pending_msgs--;
return error;
});
}, },
serialize: function(model, attrs) { serialize: function(model, attrs) {