From c2701a8fb0dc378abefd0a204288883bdd390819 Mon Sep 17 00:00:00 2001 From: Grant Nestor Date: Sat, 27 Jan 2018 18:14:06 -0800 Subject: [PATCH] Make buffer time between last modified on disk and last modified on last save configurable --- notebook/static/notebook/js/notebook.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/notebook/static/notebook/js/notebook.js b/notebook/static/notebook/js/notebook.js index 39b17d2b2..edea0d509 100644 --- a/notebook/static/notebook/js/notebook.js +++ b/notebook/static/notebook/js/notebook.js @@ -2738,10 +2738,11 @@ define([ return this.contents.get(this.notebook_path, {content: false}).then( function (data) { var last_modified = new Date(data.last_modified); + var difference_buffer = that.config.data['last_modified_buffer'] || 500; // 500 ms // We want to check last_modified (disk) > that.last_modified (our last save) // In some cases the filesystem reports an inconsistent time, - // so we allow 0.5 seconds difference before complaining. - if ((last_modified.getTime() - that.last_modified.getTime()) > 500) { // 500 ms + // so we allow 0.5 seconds (configurable in nbconfig/notebook.json as `last_modified_buffer`) difference before complaining. + if ((last_modified.getTime() - that.last_modified.getTime()) > difference_buffer) { console.warn("Last saving was done on `"+that.last_modified+"`("+that._last_modified+"), "+ "while the current file seem to have been saved on `"+data.last_modified+"`"); if (that._changed_on_disk_dialog !== null) {