mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-12-15 04:00:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Focus on the main widget after a rename

Browse Source
This commit is contained in:
Jeremy Tuloup 2020-12-15 22:23:54 +01:00
parent e003877218
commit c252bd7d15
1 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
packages/application-extension/src/index.ts
View File

@ -298,12 +298,12 @@ const title: JupyterFrontEndPlugin<void> = {
docManager: IDocumentManager | null,
router: IRouter | null
) => {
// TODO: this signal might not be needed if we assume there is always only
// one notebook in the main area
const widget = new Widget();
widget.id = 'jp-title';
app.shell.add(widget, 'top', { rank: 10 });
// TODO: this signal might not be needed if we assume there is always only
// one notebook in the main area
shell.currentChanged.connect(async () => {
const current = shell.currentWidget;
if (!(current instanceof DocumentWidget)) {
@ -318,23 +318,30 @@ const title: JupyterFrontEndPlugin<void> = {
}
widget.node.onclick = async () => {
const result = await renameDialog(docManager, current.context.path);
if (result) {
const basename = PathExt.basename(result.path);
h.textContent = basename;
if (!router) {
return;
}
const current = router.current;
const matches = current.path.match(TREE_PATTERN) ?? [];
const [, route, path] = matches;
if (!route || !path) {
return;
}
const encoded = encodeURIComponent(result.path);
router.navigate(`/classic/${route}/${encoded}`, {
skipRouting: true
});
// activate the current widget to bring the focus
if (current) {
current.activate();
}
if (!result) {
return;
}
const basename = PathExt.basename(result.path);
h.textContent = basename;
if (!router) {
return;
}
const matches = router.current.path.match(TREE_PATTERN) ?? [];
const [, route, path] = matches;
if (!route || !path) {
return;
}
const encoded = encodeURIComponent(result.path);
router.navigate(`/classic/${route}/${encoded}`, {
skipRouting: true
});
};
});
}