mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-01 12:56:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Mark thread for test server as daemonic

Browse Source 
I don't understand how, but I suspect that the threaded server is
somehow involved in the hangs we see after the tests complete. This
marks it as daemonic so that if it somehow escapes it won't keep the
test process alive.
This commit is contained in:
Thomas Kluyver 2016-02-22 17:51:57 +00:00
parent 6c87dd9246
commit c1a2a26551
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
notebook/tests/launchnotebook.py
View File

@ -115,7 +115,7 @@ class NotebookTestBase(TestCase):
# set the event, so failure to start doesn't cause a hang
started.set()
app.session_manager.close()
cls.notebook_thread = Thread(target=start_thread)
cls.notebook_thread = Thread(target=start_thread, daemon=True)
cls.notebook_thread.start()
started.wait()
cls.wait_until_alive()