DEV: Tweaks to Login/LogoutHandler setup.

- Require handlers to be tornado.web.RequestHandlers.  Rename the
- NotebookApp attributes from log{in,out}_handler to log{in,out}_handler_class.
This commit is contained in:
Scott Sanderson 2014-12-19 00:52:21 -05:00
parent 8e2286911d
commit acf011bd9c

View File

@ -661,16 +661,16 @@ class NotebookApp(BaseIPythonApplication):
"""
)
login_handler = Type(
login_handler_class = Type(
default_value=LoginHandler,
klass=object,
klass=web.RequestHandler,
config=True,
help='The login handler class to use.',
)
logout_handler = Type(
logout_handler_class = Type(
default_value=LogoutHandler,
klass=object,
klass=web.RequestHandler,
config=True,
help='The logout handler class to use.',
)
@ -785,10 +785,6 @@ class NotebookApp(BaseIPythonApplication):
log=self.log,
)
# Maintaining this naming convention for backwards compatibility.
self.login_handler_class = self.login_handler
self.logout_handler_class = self.logout_handler
self.config_manager = self.config_manager_class(
parent=self,
log=self.log,