mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2024-12-21 04:10:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Download as always starts downloads in new window/tab

Browse Source 
This is a slightly worse user experience if it succeeds, because the new
tab flashes up before closing again, but it will let us display an
informative error page if it fails, without navigating the user away
from the interactive notebook view.
This commit is contained in:
Thomas Kluyver 2013-12-11 15:32:00 -08:00
parent 30e8939a27
commit 9da24dda50
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
IPython/html/static/notebook/js/menubar.js
View File

@ -83,11 +83,7 @@ var IPython = (function (IPython) {
notebook_name + '.ipynb' notebook_name + '.ipynb'
) + "?download=" + download.toString(); ) + "?download=" + download.toString();
if (download) { window.open(url);
window.location.assign(url);
} else {
window.open(url);
}
} }
MenuBar.prototype.bind_events = function () { MenuBar.prototype.bind_events = function () {