From 9da24dda503a7b5a4ceecf57069e2a1a34d02b6e Mon Sep 17 00:00:00 2001 From: Thomas Kluyver Date: Wed, 11 Dec 2013 15:32:00 -0800 Subject: [PATCH] Download as always starts downloads in new window/tab This is a slightly worse user experience if it succeeds, because the new tab flashes up before closing again, but it will let us display an informative error page if it fails, without navigating the user away from the interactive notebook view. --- IPython/html/static/notebook/js/menubar.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/IPython/html/static/notebook/js/menubar.js b/IPython/html/static/notebook/js/menubar.js index 8036960ec..a43c76a31 100644 --- a/IPython/html/static/notebook/js/menubar.js +++ b/IPython/html/static/notebook/js/menubar.js @@ -83,11 +83,7 @@ var IPython = (function (IPython) { notebook_name + '.ipynb' ) + "?download=" + download.toString(); - if (download) { - window.location.assign(url); - } else { - window.open(url); - } + window.open(url); } MenuBar.prototype.bind_events = function () {