mirror of
https://github.com/jupyter/notebook.git
synced 2024-12-21 04:10:17 +08:00
Download as always starts downloads in new window/tab
This is a slightly worse user experience if it succeeds, because the new tab flashes up before closing again, but it will let us display an informative error page if it fails, without navigating the user away from the interactive notebook view.
This commit is contained in:
parent
30e8939a27
commit
9da24dda50
@ -83,11 +83,7 @@ var IPython = (function (IPython) {
|
||||
notebook_name + '.ipynb'
|
||||
) + "?download=" + download.toString();
|
||||
|
||||
if (download) {
|
||||
window.location.assign(url);
|
||||
} else {
|
||||
window.open(url);
|
||||
}
|
||||
window.open(url);
|
||||
}
|
||||
|
||||
MenuBar.prototype.bind_events = function () {
|
||||
|
Loading…
Reference in New Issue
Block a user