mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-13 13:17:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update widget selection containers to reflect how viewlist works

Browse Source 
add_child takes a model and returns a view.  remove_child takes a view and removes it.
the pop_child_view method is now gone.
This commit is contained in:
Jason Grout 2014-11-25 01:57:11 +00:00
parent 247ebf16f0
commit 9553f30222
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
IPython/html/static/widgets/js/widget_selectioncontainer.js
View File

@ -14,7 +14,7 @@ define([
this.containers = [];
this.model_containers = {};
this.children_views = new widget.ViewList(this.add_child_model, this.remove_child_model, this);
this.children_views = new widget.ViewList(this.add_child_view, this.remove_child_view, this);
this.listenTo(this.model, 'change:children', function(model, value) {
this.children_views.update(value);
}, this);
@ -68,16 +68,17 @@ define([
}
},
remove_child_model: function(model) {
remove_child_view: function(view) {
// Called when a child is removed from children list.
// TODO: does this handle two different views of the same model as children?
var model = view.model;
var accordion_group = this.model_containers[model.id];
this.containers.splice(accordion_group.container_index, 1);
delete this.model_containers[model.id];
accordion_group.remove();
this.pop_child_view(model);
},
add_child_model: function(model) {
add_child_view: function(model) {
// Called when a child is added to children list.
var index = this.containers.length;
var uuid = utils.uuid();
@ -143,7 +144,7 @@ define([
TabView.__super__.initialize.apply(this, arguments);
this.containers = [];
this.children_views = new widget.ViewList(this.add_child_model, this.remove_child_model, this);
this.children_views = new widget.ViewList(this.add_child_view, this.remove_child_view, this);
this.listenTo(this.model, 'change:children', function(model, value) {
this.children_views.update(value);
}, this);
@ -168,16 +169,15 @@ define([
this.$tabs.css(name, value);
},
remove_child_model: function(model) {
remove_child_view: function(view) {
// Called when a child is removed from children list.
var view = this.pop_child_view(model);
this.containers.splice(view.parent_tab.tab_text_index, 1);
view.parent_tab.remove();
view.parent_container.remove();
view.remove();
},
add_child_model: function(model) {
add_child_view: function(model) {
// Called when a child is added to children list.
var index = this.containers.length;
var uuid = utils.uuid();