mirror/notebook
2
0
Fork 0
mirror of https://github.com/jupyter/notebook.git synced 2025-03-01 12:56:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Workaround for socket permission errors on Cygwin (#4584)

Browse Source 
* Workaround for wrong errno on socket bind permission errors on Cygwin.

* [ci skip] Add period to comment

Co-authored-by: Steven Silvester <stslve@amazon.com>
This commit is contained in:
E. M. Bray 2020-06-07 15:28:55 +02:00 committed by GitHub
parent dbfa82c3e7
commit 8e7c99ad8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
notebook/notebookapp.py
View File

@ -1725,13 +1725,20 @@ class NotebookApp(JupyterApp):
try:
self.http_server.listen(port, self.ip)
except socket.error as e:
eacces = (errno.EACCES, getattr(errno, 'WSAEACCES', errno.EACCES))
if sys.platform == 'cygwin':
# Cygwin has a bug that causes EPERM to be returned in this
# case instead of EACCES:
# https://cygwin.com/ml/cygwin/2019-04/msg00160.html
eacces += (errno.EPERM,)
if e.errno == errno.EADDRINUSE:
if self.port_retries:
self.log.info(_('The port %i is already in use, trying another port.') % port)
else:
self.log.info(_('The port %i is already in use.') % port)
continue
elif e.errno in (errno.EACCES, getattr(errno, 'WSAEACCES', errno.EACCES)):
elif e.errno in eacces:
self.log.warning(_("Permission to listen on port %i denied.") % port)
continue
else: